28949 2009-09-03 08:01:38 -0700 [Qt] Page content is not displayed in case of HTTP status error 2009-09-03 12:36:19 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned oldest_to_newest 144520 0 yael 2009-09-03 08:01:38 -0700 In case of HTTP status error, the web server might still send useful information about the error. If a server sent content, the content should be displayed to the user. Besides, other browsers display that content. 144526 1 38991 yael 2009-09-03 08:20:32 -0700 Created attachment 38991 Patch If the server sends content with the HTTP status code, display the content instead of throwing an error. 144554 2 38991 hausmann 2009-09-03 11:46:45 -0700 Comment on attachment 38991 Patch r=me. I would suggest re-positioning the comments though when landing, by keeping the original comment and moving the new comment you added next to the !m_responseDataSent at the end of that line. 144568 3 yael 2009-09-03 12:36:19 -0700 Landed in 48028 38991 2009-09-03 08:20:32 -0700 2009-09-03 11:46:45 -0700 Patch 28949.patch text/plain 3396 yael SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODAyMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDktMDMgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gUGFnZSBjb250ZW50IGlzIG5vdCBkaXNwbGF5ZWQgaW4gY2FzZSBvZiBIVFRQIHN0YXR1 cyBlcnJvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mjg5NDkKKworICAgICAgICBJZiB0aGUgc2VydmVyIHNlbnQgY29udGVudCwgc2hvdyBpdCB0byB0 aGUgdXNlciBpbnN0ZWFkIG9mIGFuIGVycm9yLAorICAgICAgICBldmVuIGlmIHRoZSBIVFRQIHN0 YXR1cyBjb2RlIGlzIG5vdCBzdWNjZXNzLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9x dC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpRTmV0d29ya1Jl cGx5SGFuZGxlcjo6UU5ldHdvcmtSZXBseUhhbmRsZXIpOgorICAgICAgICAoV2ViQ29yZTo6UU5l dHdvcmtSZXBseUhhbmRsZXI6OmZpbmlzaCk6CisgICAgICAgIChXZWJDb3JlOjpRTmV0d29ya1Jl cGx5SGFuZGxlcjo6Zm9yd2FyZERhdGEpOgorICAgICAgICAoV2ViQ29yZTo6UU5ldHdvcmtSZXBs eUhhbmRsZXI6OnJlc2V0U3RhdGUpOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvcXQvUU5l dHdvcmtSZXBseUhhbmRsZXIuaDoKKwogMjAwOS0wOS0wMyAgVml0YWx5IFJlcGVzaGtvICA8dml0 YWx5ckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5k ZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlI YW5kbGVyLmNwcAkocmV2aXNpb24gNDgwMTcpCisrKyBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv cXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzUsNiArMTM1 LDcgQEAKICAgICAsIG1fcmVwbHkoMCkKICAgICAsIG1fcmVkaXJlY3RlZChmYWxzZSkKICAgICAs IG1fcmVzcG9uc2VTZW50KGZhbHNlKQorICAgICwgbV9yZXNwb25zZURhdGFTZW50KGZhbHNlKQog ICAgICwgbV9sb2FkTW9kZShsb2FkTW9kZSkKICAgICAsIG1fc2hvdWxkU3RhcnQodHJ1ZSkKICAg ICAsIG1fc2hvdWxkRmluaXNoKGZhbHNlKQpAQCAtMjI1LDkgKzIyNiwxMiBAQAogICAgICAgICBy ZXNldFN0YXRlKCk7CiAgICAgICAgIHN0YXJ0KCk7CiAgICAgfSBlbHNlIGlmIChtX3JlcGx5LT5l cnJvcigpICE9IFFOZXR3b3JrUmVwbHk6Ok5vRXJyb3IKLSAgICAgICAgICAgICAgIC8vIGEgd2Vi IHBhZ2UgdGhhdCByZXR1cm5zIDQwMS80MDMvNDA0IGNhbiBzdGlsbCBoYXZlIGNvbnRlbnQKLSAg ICAgICAgICAgICAgICYmIG1fcmVwbHktPmVycm9yKCkgIT0gUU5ldHdvcmtSZXBseTo6Q29udGVu dE9wZXJhdGlvbk5vdFBlcm1pdHRlZEVycm9yCisgICAgICAgICAgICAgICAvLyBJZiB0aGUgd2Vi IHBhZ2Ugc2VudCBjb250ZW50LCBsZXQncyBnaXZlIGl0IHRvIHRoZSB1c2VyLgorICAgICAgICAg ICAgICAgJiYgKChtX3JlcGx5LT5lcnJvcigpICE9IFFOZXR3b3JrUmVwbHk6OkNvbnRlbnRPcGVy YXRpb25Ob3RQZXJtaXR0ZWRFcnJvcgogICAgICAgICAgICAgICAgJiYgbV9yZXBseS0+ZXJyb3Io KSAhPSBRTmV0d29ya1JlcGx5OjpDb250ZW50Tm90Rm91bmRFcnJvcgorICAgICAgICAgICAgICAg JiYgbV9yZXBseS0+ZXJyb3IoKSAhPSBRTmV0d29ya1JlcGx5OjpQcm90b2NvbFVua25vd25FcnJv cgorICAgICAgICAgICAgICAgJiYgbV9yZXBseS0+ZXJyb3IoKSAhPSBRTmV0d29ya1JlcGx5OjpV bmtub3duQ29udGVudEVycm9yKQorICAgICAgICAgICAgICAgfHwgIW1fcmVzcG9uc2VEYXRhU2Vu dCkKICAgICAgICAgICAgICAgICYmIG1fcmVwbHktPmVycm9yKCkgIT0gUU5ldHdvcmtSZXBseTo6 QXV0aGVudGljYXRpb25SZXF1aXJlZEVycm9yCiAgICAgICAgICAgICAgICAmJiBtX3JlcGx5LT5l cnJvcigpICE9IFFOZXR3b3JrUmVwbHk6OlByb3h5QXV0aGVudGljYXRpb25SZXF1aXJlZEVycm9y KSB7CiAgICAgICAgIFFVcmwgdXJsID0gbV9yZXBseS0+dXJsKCk7CkBAIC0zNDcsOCArMzUxLDEw IEBACiAgICAgaWYgKCFjbGllbnQpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmICghZGF0YS5p c0VtcHR5KCkpCisgICAgaWYgKCFkYXRhLmlzRW1wdHkoKSkgeworICAgICAgICBtX3Jlc3BvbnNl RGF0YVNlbnQgPSB0cnVlOwogICAgICAgICBjbGllbnQtPmRpZFJlY2VpdmVEYXRhKG1fcmVzb3Vy Y2VIYW5kbGUsIGRhdGEuY29uc3REYXRhKCksIGRhdGEubGVuZ3RoKCksIGRhdGEubGVuZ3RoKCkg LypGaXhNZSovKTsKKyAgICB9CiB9CiAKIHZvaWQgUU5ldHdvcmtSZXBseUhhbmRsZXI6OnN0YXJ0 KCkKQEAgLTQyMSw2ICs0MjcsNyBAQAogewogICAgIG1fcmVkaXJlY3RlZCA9IGZhbHNlOwogICAg IG1fcmVzcG9uc2VTZW50ID0gZmFsc2U7CisgICAgbV9yZXNwb25zZURhdGFTZW50ID0gZmFsc2U7 CiAgICAgbV9zaG91bGRTdGFydCA9IHRydWU7CiAgICAgbV9zaG91bGRGaW5pc2ggPSBmYWxzZTsK ICAgICBtX3Nob3VsZFNlbmRSZXNwb25zZSA9IGZhbHNlOwpJbmRleDogV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmgJKHJldmlzaW9uIDQ4 MDE3KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVy LmgJKHdvcmtpbmcgY29weSkKQEAgLTczLDYgKzczLDcgQEAKICAgICBSZXNvdXJjZUhhbmRsZSog bV9yZXNvdXJjZUhhbmRsZTsKICAgICBib29sIG1fcmVkaXJlY3RlZDsKICAgICBib29sIG1fcmVz cG9uc2VTZW50OworICAgIGJvb2wgbV9yZXNwb25zZURhdGFTZW50OwogICAgIExvYWRNb2RlIG1f bG9hZE1vZGU7CiAgICAgUU5ldHdvcmtBY2Nlc3NNYW5hZ2VyOjpPcGVyYXRpb24gbV9tZXRob2Q7 CiAgICAgUU5ldHdvcmtSZXF1ZXN0IG1fcmVxdWVzdDsK