28947 2009-09-03 07:27:02 -0700 ASSERT executing the webhistory unittest in a debug build 2009-10-06 04:57:32 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned commit-queue oldest_to_newest 144510 0 xan.lopez 2009-09-03 07:27:02 -0700 /webkit/webhistoryitem/get_data: ASSERTION FAILED: isMainThread() (../../WebCore/platform/text/TextEncodingRegistry.cpp:176 void WebCore::buildBaseTextCodecMaps()) Program received signal SIGSEGV, Segmentation fault. 0x014d7e48 in buildBaseTextCodecMaps () at ../../WebCore/platform/text/TextEncodingRegistry.cpp:176 176 ASSERT(isMainThread()); Current language: auto; currently c++ Missing separate debuginfos, use: debuginfo-install libgcc-4.4.0-0.31.i586 libstdc++-4.4.0-0.31.i586 libxml2-2.7.3-2.fc10.i386 (gdb) bt #0 0x014d7e48 in buildBaseTextCodecMaps () at ../../WebCore/platform/text/TextEncodingRegistry.cpp:176 #1 0x014d811f in WebCore::atomicCanonicalTextEncodingName (name=0x1d5eb8c "UTF-8") at ../../WebCore/platform/text/TextEncodingRegistry.cpp:241 #2 0x014d57ff in TextEncoding (this=0x29d8c00, name=0x1d5eb8c "UTF-8") at ../../WebCore/platform/text/TextEncoding.cpp:61 #3 0x014d6402 in WebCore::UTF8Encoding () at ../../WebCore/platform/text/TextEncoding.cpp:266 #4 0x014689dc in KURL (this=0xbfffeb94, base=@0xbfffebd0, relative=@0xbfffebcc) at ../../WebCore/platform/KURL.cpp:319 #5 0x00ec783a in webkit_web_history_item_new_with_data (uri=0x8048709 "http://example.com/", title=0x8048700 "Example1") at ../../WebKit/gtk/webkit/webkitwebhistoryitem.cpp:300 #6 0x0804824e in web_history_item_fixture_setup (fixture=0x804d928, data=0x0) at ../../WebKit/gtk/tests/testwebhistoryitem.c:33 #7 0x00c79077 in test_case_run (tc=0x804c808) at gtestutils.c:1129 #8 0x00c7934c in g_test_run_suite_internal (suite=0x8076540, path=0xcbb04c "") at gtestutils.c:1179 #9 0x00c79401 in g_test_run_suite_internal (suite=0x8076530, path=0xcbb04c "") at gtestutils.c:1189 #10 0x00c79401 in g_test_run_suite_internal (suite=0x8076510, path=0xcbb04c "") at gtestutils.c:1189 #11 0x00c79588 in IA__g_test_run_suite (suite=0x8076510) at gtestutils.c:1230 #12 0x00c7876c in IA__g_test_run () at gtestutils.c:862 #13 0x08048623 in main (argc=1, argv=0xbfffef14) at ../../WebKit/gtk/tests/testwebhistoryitem.c:71 (gdb) 144511 1 xan.lopez 2009-09-03 07:29:28 -0700 This was touched recently in r47911, which claimed to be also fixing a possible ASSERT in debug builds. Mmmm :) 152618 2 40701 alex 2009-10-06 01:44:00 -0700 Created attachment 40701 Patch fixing the problem The problem was caused because webkit_init was not called before the instantiation of a KURL. Apparently webkit_init is being called in the class_init but it is not enough in these cases. If we want a more general solution we can check all the places that could cause a problem like this or comment that webkit_init should be called by the programs before doing anything (but this would mean adding the function to the API if it is not). Anyway we have to consider that if someone uses webkit library and tries to create a KURL is going to have problems if they do not call webkit_init in advance calling other API functions. 152619 3 xan.lopez 2009-10-06 01:47:42 -0700 (In reply to comment #2) > Created an attachment (id=40701) [details] > Patch fixing the problem > > The problem was caused because webkit_init was not called before the > instantiation of a KURL. Apparently webkit_init is being called in the > class_init but it is not enough in these cases. If we want a more general > solution we can check all the places that could cause a problem like this or > comment that webkit_init should be called by the programs before doing anything > (but this would mean adding the function to the API if it is not). Anyway we > have to consider that if someone uses webkit library and tries to create a KURL > is going to have problems if they do not call webkit_init in advance calling > other API functions. Keep in mind that KURL and everything else in WebCore is not public API, so that is not a problem. The problem is that we might have lots of other functions where calls to WebCore are made before any class_init is called, which as shown in this test can cause problems. 152620 4 40702 alex 2009-10-06 01:53:52 -0700 Created attachment 40702 Fixed Changelog style Sorry about that :) 152621 5 40702 xan.lopez 2009-10-06 01:56:48 -0700 Comment on attachment 40702 Fixed Changelog style r=me, thanks! 152673 6 40702 commit-queue 2009-10-06 04:57:29 -0700 Comment on attachment 40702 Fixed Changelog style Clearing flags on attachment: 40702 Committed r49172: <http://trac.webkit.org/changeset/49172> 152674 7 commit-queue 2009-10-06 04:57:32 -0700 All reviewed patches have been landed. Closing bug. 40701 2009-10-06 01:44:00 -0700 2009-10-06 01:53:52 -0700 Patch fixing the problem webhistoryitem_assertion_28947.patch text/plain 1550 alex ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggYTllZjM0NC4uYTJiOWQ5MSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0xMC0wNiAg QWxlamFuZHJvIEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBoYXZlIHRvIGNhbGwgZ19vYmplY3Rf bmV3IGZpcnN0IHRvIGluaXRpYWxpemUgd2Via2l0IHRocmVhZGluZworCWJlZm9yZSBjcmVhdGlu ZyB0aGUgS1VSTC4KKworICAgICAgICAqIFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmhpc3Rv cnlpdGVtLmNwcDoKKwkKIDIwMDktMTAtMDMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KIAogICAgICAgICBNb3JlIGJ1aWxkIGZpeGluZy4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHdlYmhpc3RvcnlpdGVtLmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtp dHdlYmhpc3RvcnlpdGVtLmNwcAppbmRleCAwMTc4YzZiLi5hYWI4YjUxIDEwMDY0NAotLS0gYS9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJoaXN0b3J5aXRlbS5jcHAKKysrIGIvV2ViS2l0L2d0 ay93ZWJraXQvd2Via2l0d2ViaGlzdG9yeWl0ZW0uY3BwCkBAIC0yOTcsMTIgKzI5NywxMSBAQCBX ZWJLaXRXZWJIaXN0b3J5SXRlbSogd2Via2l0X3dlYl9oaXN0b3J5X2l0ZW1fbmV3KCkKICAqLwog V2ViS2l0V2ViSGlzdG9yeUl0ZW0qIHdlYmtpdF93ZWJfaGlzdG9yeV9pdGVtX25ld193aXRoX2Rh dGEoY29uc3QgZ2NoYXIqIHVyaSwgY29uc3QgZ2NoYXIqIHRpdGxlKQogewotICAgIFdlYkNvcmU6 OktVUkwgaGlzdG9yeVVyaShXZWJDb3JlOjpLVVJMKCksIHVyaSk7Ci0gICAgV2ViQ29yZTo6U3Ry aW5nIGhpc3RvcnlUaXRsZSA9IFdlYkNvcmU6OlN0cmluZzo6ZnJvbVVURjgodGl0bGUpOwotCiAg ICAgV2ViS2l0V2ViSGlzdG9yeUl0ZW0qIHdlYkhpc3RvcnlJdGVtID0gV0VCS0lUX1dFQl9ISVNU T1JZX0lURU0oZ19vYmplY3RfbmV3KFdFQktJVF9UWVBFX1dFQl9ISVNUT1JZX0lURU0sIE5VTEwp KTsKICAgICBXZWJLaXRXZWJIaXN0b3J5SXRlbVByaXZhdGUqIHByaXYgPSB3ZWJIaXN0b3J5SXRl bS0+cHJpdjsKIAorICAgIFdlYkNvcmU6OktVUkwgaGlzdG9yeVVyaShXZWJDb3JlOjpLVVJMKCks IHVyaSk7CisgICAgV2ViQ29yZTo6U3RyaW5nIGhpc3RvcnlUaXRsZSA9IFdlYkNvcmU6OlN0cmlu Zzo6ZnJvbVVURjgodGl0bGUpOwogICAgIFJlZlB0cjxXZWJDb3JlOjpIaXN0b3J5SXRlbT4gaXRl bSA9IFdlYkNvcmU6Okhpc3RvcnlJdGVtOjpjcmVhdGUoaGlzdG9yeVVyaSwgaGlzdG9yeVRpdGxl LCAwKTsKICAgICBwcml2LT5oaXN0b3J5SXRlbSA9IGl0ZW0ucmVsZWFzZSgpLnJlbGVhc2VSZWYo KTsKICAgICB3ZWJraXRfaGlzdG9yeV9pdGVtX2FkZCh3ZWJIaXN0b3J5SXRlbSwgcHJpdi0+aGlz dG9yeUl0ZW0pOwo= 40702 2009-10-06 01:53:52 -0700 2009-10-06 04:57:28 -0700 Fixed Changelog style webhistoryitem_assertion_28947.patch text/plain 1680 alex ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggYTllZjM0NC4uMWQ4MTk3MSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMC0wNiAg QWxlamFuZHJvIEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBU1NFUlQgZXhlY3V0aW5nIHRoZSB3ZWJo aXN0b3J5IHVuaXR0ZXN0IGluIGEgZGVidWcgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4OTQ3CisKKyAgICAgICAgV2UgaGF2ZSB0byBjYWxs IGdfb2JqZWN0X25ldyBmaXJzdCB0byBpbml0aWFsaXplIHdlYmtpdCB0aHJlYWRpbmcKKyAgICAg ICAgYmVmb3JlIGNyZWF0aW5nIHRoZSBLVVJMLgorCisgICAgICAgICogV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2ViaGlzdG9yeWl0ZW0uY3BwOgorCiAyMDA5LTEwLTAzICBBZGFtIEJhcnRoICA8 YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTW9yZSBidWlsZCBmaXhpbmcuCmRpZmYgLS1n aXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJoaXN0b3J5aXRlbS5jcHAgYi9XZWJLaXQv Z3RrL3dlYmtpdC93ZWJraXR3ZWJoaXN0b3J5aXRlbS5jcHAKaW5kZXggMDE3OGM2Yi4uYWFiOGI1 MSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViaGlzdG9yeWl0ZW0uY3Bw CisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmhpc3RvcnlpdGVtLmNwcApAQCAtMjk3 LDEyICsyOTcsMTEgQEAgV2ViS2l0V2ViSGlzdG9yeUl0ZW0qIHdlYmtpdF93ZWJfaGlzdG9yeV9p dGVtX25ldygpCiAgKi8KIFdlYktpdFdlYkhpc3RvcnlJdGVtKiB3ZWJraXRfd2ViX2hpc3Rvcnlf aXRlbV9uZXdfd2l0aF9kYXRhKGNvbnN0IGdjaGFyKiB1cmksIGNvbnN0IGdjaGFyKiB0aXRsZSkK IHsKLSAgICBXZWJDb3JlOjpLVVJMIGhpc3RvcnlVcmkoV2ViQ29yZTo6S1VSTCgpLCB1cmkpOwot ICAgIFdlYkNvcmU6OlN0cmluZyBoaXN0b3J5VGl0bGUgPSBXZWJDb3JlOjpTdHJpbmc6OmZyb21V VEY4KHRpdGxlKTsKLQogICAgIFdlYktpdFdlYkhpc3RvcnlJdGVtKiB3ZWJIaXN0b3J5SXRlbSA9 IFdFQktJVF9XRUJfSElTVE9SWV9JVEVNKGdfb2JqZWN0X25ldyhXRUJLSVRfVFlQRV9XRUJfSElT VE9SWV9JVEVNLCBOVUxMKSk7CiAgICAgV2ViS2l0V2ViSGlzdG9yeUl0ZW1Qcml2YXRlKiBwcml2 ID0gd2ViSGlzdG9yeUl0ZW0tPnByaXY7CiAKKyAgICBXZWJDb3JlOjpLVVJMIGhpc3RvcnlVcmko V2ViQ29yZTo6S1VSTCgpLCB1cmkpOworICAgIFdlYkNvcmU6OlN0cmluZyBoaXN0b3J5VGl0bGUg PSBXZWJDb3JlOjpTdHJpbmc6OmZyb21VVEY4KHRpdGxlKTsKICAgICBSZWZQdHI8V2ViQ29yZTo6 SGlzdG9yeUl0ZW0+IGl0ZW0gPSBXZWJDb3JlOjpIaXN0b3J5SXRlbTo6Y3JlYXRlKGhpc3RvcnlV cmksIGhpc3RvcnlUaXRsZSwgMCk7CiAgICAgcHJpdi0+aGlzdG9yeUl0ZW0gPSBpdGVtLnJlbGVh c2UoKS5yZWxlYXNlUmVmKCk7CiAgICAgd2Via2l0X2hpc3RvcnlfaXRlbV9hZGQod2ViSGlzdG9y eUl0ZW0sIHByaXYtPmhpc3RvcnlJdGVtKTsK