28942 2009-09-03 03:46:07 -0700 [V8] DOM Storage bindings: Event Handler should create StorageEvents 2009-09-04 03:28:44 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 benm benm eric jorlow oldest_to_newest 144474 0 benm 2009-09-03 03:46:07 -0700 On Android we're failing a set of DOM storage layout tests when running with V8. It seems that the event handling code in V8DOMWrapper.cpp does not generate Storage Events and the code in the custom storage binding (V8StorageCustom.cpp) ignores the length attribute in the setter but not in the getter. 144481 1 38981 benm 2009-09-03 04:53:32 -0700 Created attachment 38981 Proposed patch 144518 2 jorlow 2009-09-03 07:44:26 -0700 In what cases do we do the wrong thing for length? IIRC, I tested these scenarios pretty carefully and found that it wasn't necessary, but that was a while ago. If there are any, could you please add a layout test to verify the behavior? If not, I think we should leave it as is. 144524 3 jorlow 2009-09-03 08:09:51 -0700 Nm. Apparently we're failing one that we're excluding right now for chrome and this fixes it. :-) 144525 4 benm 2009-09-03 08:18:13 -0700 (In reply to comment #3) > Nm. Apparently we're failing one that we're excluding right now for chrome and > this fixes it. :-) Yes -- just to follow up it's the storage/domstorage/localstorage/complex-keys.html test I was seeing fail. The problem is that in the binding for name/indexed property setters, we silently ignore cases when trying to set the length property but we do create a new property named 'length' if it is set through the setItem function. Now in that layout test after calling setItem("length", 0) on line 92, we query the length through a named and indexed access and as we do not special case length in the indexed/named getter of the bindings we end up returning the value 0 (as in the property we added through setItem), rather than actual number of items in the object as the layout test result expects. 144717 5 38981 eric 2009-09-04 00:23:58 -0700 Comment on attachment 38981 Proposed patch The ChnageLog should list the tests that this changes/causes v8 to pass. If there are no tests, then this change needs tests. :( 144770 6 39048 benm 2009-09-04 02:55:35 -0700 Created attachment 39048 Rejigged Changelog Added tests that now pass to the changelog. 144775 7 39048 eric 2009-09-04 03:15:34 -0700 Comment on attachment 39048 Rejigged Changelog LGTM. I can't remember if you're a committer, assuming not, cq+. 144776 8 benm 2009-09-04 03:17:54 -0700 (In reply to comment #7) > (From update of attachment 39048 [details]) > LGTM. I can't remember if you're a committer, assuming not, cq+. Thanks - I am a committer, should be fine to let the cq handle this one though. 144779 9 39048 eric 2009-09-04 03:28:40 -0700 Comment on attachment 39048 Rejigged Changelog Clearing flags on attachment: 39048 Committed r48047: <http://trac.webkit.org/changeset/48047> 144780 10 eric 2009-09-04 03:28:44 -0700 All reviewed patches have been landed. Closing bug. 38981 2009-09-03 04:53:32 -0700 2009-09-04 02:55:35 -0700 Proposed patch 28942.txt text/plain 2123 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODAxNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDktMDMgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtWOF0g RE9NIFN0b3JhZ2UgYmluZGluZ3M6IEV2ZW50IEhhbmRsZXIgc2hvdWxkIGNyZWF0ZSBTdG9yYWdl RXZlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y ODk0MgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcDogQ3JlYXRlIFN0 b3JhZ2VFdmVudHMuCisgICAgICAgIChXZWJDb3JlOjpWOERPTVdyYXBwZXI6OmNvbnZlcnRFdmVu dFRvVjhPYmplY3QpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0b3JhZ2VDdXN0 b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6c3RvcmFnZUdldHRlcik6IENoZWNrIGlmIHdlIGFy ZSByZXRyaWV2aW5nIHRoZSBsZW5ndGggcHJvcGVydHkgYW5kIHJldHVybiB0aGUgbnVtYmVyIG9m IGl0ZW1zIGluIHRoZSBvYmplY3QgcmF0aGVyIHRoYW4gYSBwcm9wZXJ0eSBuYW1lZCBsZW5ndGgg d2hlbiBpbnZva2luZyB0aGUgZ2V0SXRlbSgpIG1lbWJlciBvZiBsb2NhbC9zZXNzaW9uU3RvcmFn ZS4KKwogMjAwOS0wOS0wMyAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4RE9NV3JhcHBlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9WOERP TVdyYXBwZXIuY3BwCShyZXZpc2lvbiA0ODAxNSkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhE T01XcmFwcGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEyNiw2ICsxMTI2LDEwIEBAIHY4OjpI YW5kbGU8djg6OlZhbHVlPiBWOERPTVdyYXBwZXI6OmNvbnYKICAgICBlbHNlIGlmIChldmVudC0+ aXNFcnJvckV2ZW50KCkpCiAgICAgICAgIHR5cGUgPSBWOENsYXNzSW5kZXg6OkVSUk9SRVZFTlQ7 CiAjZW5kaWYKKyNpZiBFTkFCTEUoRE9NX1NUT1JBR0UpCisgICAgZWxzZSBpZiAoZXZlbnQtPmlz U3RvcmFnZUV2ZW50KCkpCisgICAgICAgIHR5cGUgPSBWOENsYXNzSW5kZXg6OlNUT1JBR0VFVkVO VDsKKyNlbmRpZgogCiAKICAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHJlc3VsdCA9IGluc3Rh bnRpYXRlVjhPYmplY3QodHlwZSwgVjhDbGFzc0luZGV4OjpFVkVOVCwgZXZlbnQpOwpJbmRleDog V2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhTdG9yYWdlQ3VzdG9tLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0b3JhZ2VDdXN0b20uY3BwCShyZXZp c2lvbiA0ODAxNSkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4U3RvcmFnZUN1c3Rv bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYwLDcgKzYwLDcgQEAgc3RhdGljIHY4OjpIYW5kbGU8 djg6OlZhbHVlPiBzdG9yYWdlR2V0dAogICAgIFN0b3JhZ2UqIHN0b3JhZ2UgPSBWOERPTVdyYXBw ZXI6OmNvbnZlcnRUb05hdGl2ZU9iamVjdDxTdG9yYWdlPihWOENsYXNzSW5kZXg6OlNUT1JBR0Us IGluZm8uSG9sZGVyKCkpOwogICAgIFN0cmluZyBuYW1lID0gdG9XZWJDb3JlU3RyaW5nKHY4TmFt ZSk7CiAKLSAgICBpZiAoc3RvcmFnZS0+Y29udGFpbnMobmFtZSkpCisgICAgaWYgKHN0b3JhZ2Ut PmNvbnRhaW5zKG5hbWUpICYmIG5hbWUgIT0gImxlbmd0aCIpCiAgICAgICAgIHJldHVybiB2OFN0 cmluZyhzdG9yYWdlLT5nZXRJdGVtKG5hbWUpKTsKIAogICAgIHJldHVybiBub3RIYW5kbGVkQnlJ bnRlcmNlcHRvcigpOwo= 39048 2009-09-04 02:55:35 -0700 2009-09-04 03:28:40 -0700 Rejigged Changelog 28942-2.txt text/plain 3041 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODAxNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzAgQEAKKzIwMDktMDktMDMgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtWOF0g RE9NIFN0b3JhZ2UgYmluZGluZ3M6IEV2ZW50IEhhbmRsZXIgc2hvdWxkIGNyZWF0ZSBTdG9yYWdl RXZlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y ODk0MgorICAgICAgICAKKyAgICAgICAgVGVzdHM6CisgICAgICAgIENhdXNlcyB0aGUgZm9sbG93 aW5nIHRlc3RzIHRoYXQgd2VyZSBmYWlsaW5nIHdpdGggVjggdG8gcGFzczoKKyAgICAgICAgKiBz dG9yYWdlL2RvbXN0b3JhZ2UvbG9jYWxzdG9yYWdlL29uc3RvcmFnZS1hdHRyaWJ1dGUtc2V0d2lu ZG93Lmh0bWwKKyAgICAgICAgKiBzdG9yYWdlL2RvbXN0b3JhZ2UvbG9jYWxzdG9yYWdlL2NvbXBs ZXgta2V5cy5odG1sCisgICAgICAgICogc3RvcmFnZS9kb21zdG9yYWdlL2xvY2Fsc3RvcmFnZS9v bnN0b3JhZ2UtYXR0cmlidXRlLW1hcmt1cC5odG1sCisgICAgICAgICogc3RvcmFnZS9kb21zdG9y YWdlL2xvY2Fsc3RvcmFnZS9zaW1wbGUtZXZlbnRzLmh0bWwKKyAgICAgICAgKiBzdG9yYWdlL2Rv bXN0b3JhZ2UvbG9jYWxzdG9yYWdlL29uc3RvcmFnZS1hdHRyaWJ1dGUtc2V0LWF0dHJpYnV0ZS5o dG1sCisgICAgICAgICogc3RvcmFnZS9kb21zdG9yYWdlL2xvY2Fsc3RvcmFnZS9pbmRleC1nZXQt YW5kLXNldC5odG1sCisgICAgICAgICogc3RvcmFnZS9kb21zdG9yYWdlL3Nlc3Npb25zdG9yYWdl L29uc3RvcmFnZS1hdHRyaWJ1dGUtc2V0d2luZG93Lmh0bWwKKyAgICAgICAgKiBzdG9yYWdlL2Rv bXN0b3JhZ2Uvc2Vzc2lvbnN0b3JhZ2Uvb25zdG9yYWdlLWF0dHJpYnV0ZS1tYXJrdXAuaHRtbAor ICAgICAgICAqIHN0b3JhZ2UvZG9tc3RvcmFnZS9zZXNzaW9uc3RvcmFnZS9zaW1wbGUtZXZlbnRz Lmh0bWwKKyAgICAgICAgKiBzdG9yYWdlL2RvbXN0b3JhZ2Uvc2Vzc2lvbnN0b3JhZ2Uvb25zdG9y YWdlLWF0dHJpYnV0ZS1zZXQtYXR0cmlidXRlLmh0bWwKKyAgICAgICAgKiBzdG9yYWdlL2RvbXN0 b3JhZ2Uvc2Vzc2lvbnN0b3JhZ2UvaW5kZXgtZ2V0LWFuZC1zZXQuaHRtbAorCisgICAgICAgIENv ZGUgY2hhbmdlczoKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6VjhET01XcmFwcGVyOjpjb252ZXJ0RXZlbnRUb1Y4T2JqZWN0KTogIENy ZWF0ZSBTdG9yYWdlRXZlbnRzLgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0b3Jh Z2VDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6c3RvcmFnZUdldHRlcik6IENoZWNrIGlm IHdlIGFyZSByZXRyaWV2aW5nIHRoZSBsZW5ndGggcHJvcGVydHkgYW5kIHJldHVybiB0aGUgbnVt YmVyIG9mIGl0ZW1zIGluIHRoZSBvYmplY3QgcmF0aGVyIHRoYW4gYSBwcm9wZXJ0eSBuYW1lZCBs ZW5ndGggd2hlbiBpbnZva2luZyB0aGUgZ2V0SXRlbSgpIG1lbWJlciBvZiBsb2NhbC9zZXNzaW9u U3RvcmFnZS4KKwogMjAwOS0wOS0wMyAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92 OC9WOERPTVdyYXBwZXIuY3BwCShyZXZpc2lvbiA0ODAxNSkKKysrIFdlYkNvcmUvYmluZGluZ3Mv djgvVjhET01XcmFwcGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEyNiw2ICsxMTI2LDEwIEBA IHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOERPTVdyYXBwZXI6OmNvbnYKICAgICBlbHNlIGlmIChl dmVudC0+aXNFcnJvckV2ZW50KCkpCiAgICAgICAgIHR5cGUgPSBWOENsYXNzSW5kZXg6OkVSUk9S RVZFTlQ7CiAjZW5kaWYKKyNpZiBFTkFCTEUoRE9NX1NUT1JBR0UpCisgICAgZWxzZSBpZiAoZXZl bnQtPmlzU3RvcmFnZUV2ZW50KCkpCisgICAgICAgIHR5cGUgPSBWOENsYXNzSW5kZXg6OlNUT1JB R0VFVkVOVDsKKyNlbmRpZgogCiAKICAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHJlc3VsdCA9 IGluc3RhbnRpYXRlVjhPYmplY3QodHlwZSwgVjhDbGFzc0luZGV4OjpFVkVOVCwgZXZlbnQpOwpJ bmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhTdG9yYWdlQ3VzdG9tLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0b3JhZ2VDdXN0b20uY3Bw CShyZXZpc2lvbiA0ODAxNSkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4U3RvcmFn ZUN1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYwLDcgKzYwLDcgQEAgc3RhdGljIHY4OjpI YW5kbGU8djg6OlZhbHVlPiBzdG9yYWdlR2V0dAogICAgIFN0b3JhZ2UqIHN0b3JhZ2UgPSBWOERP TVdyYXBwZXI6OmNvbnZlcnRUb05hdGl2ZU9iamVjdDxTdG9yYWdlPihWOENsYXNzSW5kZXg6OlNU T1JBR0UsIGluZm8uSG9sZGVyKCkpOwogICAgIFN0cmluZyBuYW1lID0gdG9XZWJDb3JlU3RyaW5n KHY4TmFtZSk7CiAKLSAgICBpZiAoc3RvcmFnZS0+Y29udGFpbnMobmFtZSkpCisgICAgaWYgKHN0 b3JhZ2UtPmNvbnRhaW5zKG5hbWUpICYmIG5hbWUgIT0gImxlbmd0aCIpCiAgICAgICAgIHJldHVy biB2OFN0cmluZyhzdG9yYWdlLT5nZXRJdGVtKG5hbWUpKTsKIAogICAgIHJldHVybiBub3RIYW5k bGVkQnlJbnRlcmNlcHRvcigpOwo=