28926 2009-09-02 17:06:37 -0700 Should crash if JIT code buffer allocation fails. 2009-09-02 17:33:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 144337 0 barraclough 2009-09-02 17:06:37 -0700 <rdar://problem/7031922> 144338 1 38948 barraclough 2009-09-02 17:08:02 -0700 Created attachment 38948 The patch 144340 2 38948 sam 2009-09-02 17:10:57 -0700 Comment on attachment 38948 The patch > Index: JavaScriptCore/jit/ExecutableAllocatorPosix.cpp > =================================================================== > --- JavaScriptCore/jit/ExecutableAllocatorPosix.cpp (revision 47901) > +++ JavaScriptCore/jit/ExecutableAllocatorPosix.cpp (working copy) > @@ -44,7 +44,10 @@ void ExecutableAllocator::intializePageS > > ExecutablePool::Allocation ExecutablePool::systemAlloc(size_t n) > { > - ExecutablePool::Allocation alloc = { reinterpret_cast<char*>(mmap(NULL, n, INITIAL_PROTECTION_FLAGS, MAP_PRIVATE | MAP_ANON, VM_TAG_FOR_EXECUTABLEALLOCATOR_MEMORY, 0)), n }; > + void* allocation = mmap(NULL, n, INITIAL_PROTECTION_FLAGS, MAP_PRIVATE | MAP_ANON, VM_TAG_FOR_EXECUTABLEALLOCATOR_MEMORY, 0); > + if (allocation == (void*)-1) Can we use the MAP_FAILED constant here? Otherwise, r=me 144350 3 barraclough 2009-09-02 17:33:40 -0700 Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/jit/ExecutableAllocatorPosix.cpp Sending JavaScriptCore/jit/ExecutableAllocatorWin.cpp Transmitting file data ... Committed revision 48000. 38948 2009-09-02 17:08:02 -0700 2009-09-02 17:10:57 -0700 The patch patch.CRASH.txt text/plain 2321 barraclough SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ3OTk4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDktMDIgIEdhdmluIEJh cnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAgIFNob3VsZCBjcmFz aCBpZiBKSVQgY29kZSBidWZmZXIgYWxsb2NhdGlvbiBmYWlscy4KKworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg5MjYKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzcwMzE5MjI+CisKKyAgICAgICAgKiBqaXQvRXhlY3V0YWJsZUFsbG9jYXRvclBvc2l4 LmNwcDoKKyAgICAgICAgKEpTQzo6RXhlY3V0YWJsZVBvb2w6OnN5c3RlbUFsbG9jKToKKyAgICAg ICAgKiBqaXQvRXhlY3V0YWJsZUFsbG9jYXRvcldpbi5jcHA6CisgICAgICAgIChKU0M6OkV4ZWN1 dGFibGVQb29sOjpzeXN0ZW1BbGxvYyk6CisKIDIwMDktMDktMDIgIEtldmluIE9sbGl2aWVyICA8 a2V2aW5vQHRoZW9sbGl2aWVycy5jb20+CiAKICAgICAgICAgd2FmIGJ1aWxkIGZpeGVzIGZvciBX aW5kb3dzL01TVkMuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRv clBvc2l4LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFs bG9jYXRvclBvc2l4LmNwcAkocmV2aXNpb24gNDc5MDEpCisrKyBKYXZhU2NyaXB0Q29yZS9qaXQv RXhlY3V0YWJsZUFsbG9jYXRvclBvc2l4LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDQsNyArNDQs MTAgQEAgdm9pZCBFeGVjdXRhYmxlQWxsb2NhdG9yOjppbnRpYWxpemVQYWdlUwogCiBFeGVjdXRh YmxlUG9vbDo6QWxsb2NhdGlvbiBFeGVjdXRhYmxlUG9vbDo6c3lzdGVtQWxsb2Moc2l6ZV90IG4p CiB7Ci0gICAgRXhlY3V0YWJsZVBvb2w6OkFsbG9jYXRpb24gYWxsb2MgPSB7IHJlaW50ZXJwcmV0 X2Nhc3Q8Y2hhcio+KG1tYXAoTlVMTCwgbiwgSU5JVElBTF9QUk9URUNUSU9OX0ZMQUdTLCBNQVBf UFJJVkFURSB8IE1BUF9BTk9OLCBWTV9UQUdfRk9SX0VYRUNVVEFCTEVBTExPQ0FUT1JfTUVNT1JZ LCAwKSksIG4gfTsKKyAgICB2b2lkKiBhbGxvY2F0aW9uID0gbW1hcChOVUxMLCBuLCBJTklUSUFM X1BST1RFQ1RJT05fRkxBR1MsIE1BUF9QUklWQVRFIHwgTUFQX0FOT04sIFZNX1RBR19GT1JfRVhF Q1VUQUJMRUFMTE9DQVRPUl9NRU1PUlksIDApOworICAgIGlmIChhbGxvY2F0aW9uID09ICh2b2lk KiktMSkKKyAgICAgICAgQ1JBU0goKTsKKyAgICBFeGVjdXRhYmxlUG9vbDo6QWxsb2NhdGlvbiBh bGxvYyA9IHsgcmVpbnRlcnByZXRfY2FzdDxjaGFyKj4oYWxsb2NhdGlvbiksIG4gfTsKICAgICBy ZXR1cm4gYWxsb2M7CiB9CiAKSW5kZXg6IEphdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxs b2NhdG9yV2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJs ZUFsbG9jYXRvcldpbi5jcHAJKHJldmlzaW9uIDQ3OTAxKQorKysgSmF2YVNjcmlwdENvcmUvaml0 L0V4ZWN1dGFibGVBbGxvY2F0b3JXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Miw3ICs0Miwx MCBAQCB2b2lkIEV4ZWN1dGFibGVBbGxvY2F0b3I6OmludGlhbGl6ZVBhZ2VTCiAKIEV4ZWN1dGFi bGVQb29sOjpBbGxvY2F0aW9uIEV4ZWN1dGFibGVQb29sOjpzeXN0ZW1BbGxvYyhzaXplX3QgbikK IHsKLSAgICBFeGVjdXRhYmxlUG9vbDo6QWxsb2NhdGlvbiBhbGxvYyA9IHtyZWludGVycHJldF9j YXN0PGNoYXIqPihWaXJ0dWFsQWxsb2MoMCwgbiwgTUVNX0NPTU1JVCB8IE1FTV9SRVNFUlZFLCBQ QUdFX0VYRUNVVEVfUkVBRFdSSVRFKSksIG59OworICAgIHZvaWQqIGFsbG9jYXRpb24gPSBWaXJ0 dWFsQWxsb2MoMCwgbiwgTUVNX0NPTU1JVCB8IE1FTV9SRVNFUlZFLCBQQUdFX0VYRUNVVEVfUkVB RFdSSVRFKTsKKyAgICBpZiAoIWFsbG9jYXRpb24pCisgICAgICAgIENSQVNIKCk7CisgICAgRXhl Y3V0YWJsZVBvb2w6OkFsbG9jYXRpb24gYWxsb2MgPSB7cmVpbnRlcnByZXRfY2FzdDxjaGFyKj4o YWxsb2NhdGlvbiksIG59OwogICAgIHJldHVybiBhbGxvYzsKIH0KIAo=