28920 2009-09-02 13:51:31 -0700 curl DNS lookup occurs on multiple threads but storage is not threadsafe 2009-09-02 14:08:52 -0700 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 kevinwatters webkit-unassigned kevino oldest_to_newest 144295 0 kevinwatters 2009-09-02 13:51:31 -0700 libcurl expects the user of the library to provide synchronization of shared data via the curl_share_setopt function. I'm seeing sporadic crashes in libcurl DNS code in wxWebKit on Windows, where libcurl uses a background thread to do DNS lookups. 144297 1 38941 kevinwatters 2009-09-02 13:53:07 -0700 Created attachment 38941 Use Mutexes and curl_share_setopt to protect libcurl shared data 144304 2 kevino 2009-09-02 14:08:52 -0700 Landed in r47993, thanks! 38941 2009-09-02 13:53:07 -0700 2009-09-02 13:54:07 -0700 Use Mutexes and curl_share_setopt to protect libcurl shared data curl_threading.patch text/plain 2862 kevinwatters SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Nzk5MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDktMDIgIEtldmluIFdhdHRlcnMgIDxrZXZpbndhdHRlcnNA Z21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFByb3RlY3QgbGliY3VybCBzaGFyZWQgZGF0YSB3aXRoIE11dGV4IG9iamVjdHMgdmlhIGN1 cmxfc2V0X3NoYXJlX29wdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI4OTIwCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3Vy Y2VIYW5kbGVNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNoYXJlZFJlc291cmNlTXV0 ZXgpOgorICAgICAgICAoV2ViQ29yZTo6Y3VybF9sb2NrX2NhbGxiYWNrKToKKyAgICAgICAgKFdl YkNvcmU6OmN1cmxfdW5sb2NrX2NhbGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNl SGFuZGxlTWFuYWdlcjo6UmVzb3VyY2VIYW5kbGVNYW5hZ2VyKToKKwogMjAwOS0wOS0wMiAgRGly ayBTY2h1bHplICA8a3JpdEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMg U2VpZGVsLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5k bGVNYW5hZ2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3Vy bC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCShyZXZpc2lvbiA0Nzk5MCkKKysrIFdlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTQ2LDYgKzQ2LDcgQEAKIAogI2luY2x1ZGUgPGVycm5vLmg+CiAjaW5jbHVkZSA8 c3RkaW8uaD4KKyNpbmNsdWRlIDx3dGYvVGhyZWFkaW5nLmg+CiAjaW5jbHVkZSA8d3RmL1ZlY3Rv ci5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC03Niw2ICs3NywzOSBAQAogICAgIHJldHVy biBDU3RyaW5nKCk7CiB9CiAKK3N0YXRpYyBNdXRleCogc2hhcmVkUmVzb3VyY2VNdXRleChjdXJs X2xvY2tfZGF0YSBkYXRhKSB7CisgICAgREVGSU5FX1NUQVRJQ19MT0NBTChNdXRleCwgY29va2ll TXV0ZXgsICgpKTsKKyAgICBERUZJTkVfU1RBVElDX0xPQ0FMKE11dGV4LCBkbnNNdXRleCwgKCkp OworICAgIERFRklORV9TVEFUSUNfTE9DQUwoTXV0ZXgsIHNoYXJlTXV0ZXgsICgpKTsKKworICAg IHN3aXRjaCAoZGF0YSkgeworICAgICAgICBjYXNlIENVUkxfTE9DS19EQVRBX0NPT0tJRToKKyAg ICAgICAgICAgIHJldHVybiAmY29va2llTXV0ZXg7CisgICAgICAgIGNhc2UgQ1VSTF9MT0NLX0RB VEFfRE5TOgorICAgICAgICAgICAgcmV0dXJuICZkbnNNdXRleDsKKyAgICAgICAgY2FzZSBDVVJM X0xPQ0tfREFUQV9TSEFSRToKKyAgICAgICAgICAgIHJldHVybiAmc2hhcmVNdXRleDsKKyAgICAg ICAgZGVmYXVsdDoKKyAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICAg ICAgcmV0dXJuIE5VTEw7CisgICAgfQorfQorCisvLyBsaWJjdXJsIGRvZXMgbm90IGltcGxlbWVu dCBpdHMgb3duIHRocmVhZCBzeW5jaHJvbml6YXRpb24gcHJpbWl0aXZlcy4KKy8vIHRoZXNlIHR3 byBmdW5jdGlvbnMgcHJvdmlkZSBtdXRleGVzIGZvciBjb29raWVzLCBhbmQgZm9yIHRoZSBnbG9i YWwgRE5TCisvLyBjYWNoZS4KK3N0YXRpYyB2b2lkIGN1cmxfbG9ja19jYWxsYmFjayhDVVJMKiBo YW5kbGUsIGN1cmxfbG9ja19kYXRhIGRhdGEsIGN1cmxfbG9ja19hY2Nlc3MgYWNjZXNzLCB2b2lk KiB1c2VyUHRyKQoreworICAgIGlmIChNdXRleCogbXV0ZXggPSBzaGFyZWRSZXNvdXJjZU11dGV4 KGRhdGEpKQorICAgICAgICBtdXRleC0+bG9jaygpOworfQorCitzdGF0aWMgdm9pZCBjdXJsX3Vu bG9ja19jYWxsYmFjayhDVVJMKiBoYW5kbGUsIGN1cmxfbG9ja19kYXRhIGRhdGEsIHZvaWQqIHVz ZXJQdHIpCit7CisgICAgaWYgKE11dGV4KiBtdXRleCA9IHNoYXJlZFJlc291cmNlTXV0ZXgoZGF0 YSkpCisgICAgICAgIG11dGV4LT51bmxvY2soKTsKK30KKwogUmVzb3VyY2VIYW5kbGVNYW5hZ2Vy OjpSZXNvdXJjZUhhbmRsZU1hbmFnZXIoKQogICAgIDogbV9kb3dubG9hZFRpbWVyKHRoaXMsICZS ZXNvdXJjZUhhbmRsZU1hbmFnZXI6OmRvd25sb2FkVGltZXJDYWxsYmFjaykKICAgICAsIG1fY29v a2llSmFyRmlsZU5hbWUoMCkKQEAgLTg3LDYgKzEyMSw4IEBACiAgICAgbV9jdXJsU2hhcmVIYW5k bGUgPSBjdXJsX3NoYXJlX2luaXQoKTsKICAgICBjdXJsX3NoYXJlX3NldG9wdChtX2N1cmxTaGFy ZUhhbmRsZSwgQ1VSTFNIT1BUX1NIQVJFLCBDVVJMX0xPQ0tfREFUQV9DT09LSUUpOwogICAgIGN1 cmxfc2hhcmVfc2V0b3B0KG1fY3VybFNoYXJlSGFuZGxlLCBDVVJMU0hPUFRfU0hBUkUsIENVUkxf TE9DS19EQVRBX0ROUyk7CisgICAgY3VybF9zaGFyZV9zZXRvcHQobV9jdXJsU2hhcmVIYW5kbGUs IENVUkxTSE9QVF9MT0NLRlVOQywgY3VybF9sb2NrX2NhbGxiYWNrKTsKKyAgICBjdXJsX3NoYXJl X3NldG9wdChtX2N1cmxTaGFyZUhhbmRsZSwgQ1VSTFNIT1BUX1VOTE9DS0ZVTkMsIGN1cmxfdW5s b2NrX2NhbGxiYWNrKTsKIH0KIAogUmVzb3VyY2VIYW5kbGVNYW5hZ2VyOjp+UmVzb3VyY2VIYW5k bGVNYW5hZ2VyKCkK