<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>28916</bug_id>
          
          <creation_ts>2009-09-02 13:03:15 -0700</creation_ts>
          <short_desc>patches marked cq+ without review will hang the commit-queue</short_desc>
          <delta_ts>2009-09-08 14:11:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>28605</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Eric Seidel (no email)">eric</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>144270</commentid>
    <comment_count>0</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-09-02 13:03:15 -0700</bug_when>
    <thetext>patches marked cq+ without review will hang the commit-queue

The queue spins infinitely.  It thinks it has something to land, but then when it goes to land it, it doesn&apos;t find a patch and thus it just loops indefinitely. :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>144272</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-09-02 13:03:35 -0700</bug_when>
    <thetext>https://bugs.webkit.org/show_bug.cgi?id=28887 caused the hang this evening.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>145532</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-09-08 14:11:50 -0700</bug_when>
    <thetext>This will be fixed by the patch on bug 28605.  The fix was to make the commit queue call the fetch_patches_from_commit_queue up front instead of fetch_bug_ids_from_commit_queue so that it is sure to validate the patches before passing them off to land-patches.

*** This bug has been marked as a duplicate of bug 28605 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>