289143 2025-03-04 21:27:12 -0800 Percentage height becomes auto if containing block height is auto 2025-03-10 09:52:47 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 289438 InRadar, WPTImpact P2 Normal --- 1 ahmad.saleem792 ahmad.saleem792 bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 2100512 0 ahmad.saleem792 2025-03-04 21:27:12 -0800 Hi Team, While going through CSS2 WPT failures for Safari/WebKit, I came across where we can take Blink's fix. Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/1617833 WebKIt Source: https://github.com/WebKit/WebKit/blob/525bcff5a71657880a48e871e964f677bd003856/Source/WebCore/rendering/RenderBlock.cpp#L486 WPT Test Case: https://wpt.fyi/results/css/CSS2/normal-flow/margin-collapse-through-percentage-height-block.html?label=master&label=experimental&aligned WPT Test Case Live Link: https://wpt.live/css/CSS2/normal-flow/margin-collapse-through-percentage-height-block.html It can be fix via: ``` if (logicalHeightLength.isPercentOrCalculated() && !document().inQuirksMode()) { hasAutoHeight = true; if (RenderBlock* cb = containingBlock()) { if (!is<RenderView>(*cb) && (cb->style().logicalHeight().isFixed() || cb->isRenderTableCell())) hasAutoHeight = false; } } ``` Just raising, so we can fix it. Thanks! 2100514 1 webkit-bug-importer 2025-03-04 21:27:48 -0800 <rdar://problem/146207504> 2100535 2 ahmad.saleem792 2025-03-04 23:35:17 -0800 Pull request: https://github.com/WebKit/WebKit/pull/41905 2101952 3 ahmad.saleem792 2025-03-10 09:52:47 -0700 *** This bug has been marked as a duplicate of bug 289438 ***