288970 2025-03-03 08:20:00 -0800 [Win] Fix ISO_MALLOC export macros on Windows 2025-03-07 15:37:16 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build PC Windows 11 RESOLVED FIXED InRadar P2 Normal --- 283311 1 ian.grunert webkit-unassigned fujii webkit-bug-importer oldest_to_newest 2099876 0 ian.grunert 2025-03-03 08:20:00 -0800 On Windows - if a class has a 'dllexport' attribute, all it's members get 'dllexport'-ed by default. Adding the 'dllexport' attribute to a member of that class generates an error: attribute 'dllexport' cannot be applied to member of 'dllexport' class This problem means using WTF_MAKE_TZONE_OR_ISO_ALLOCATED_EXPORT on a WEBCORE_EXPORT class causes a compilation error on Windows when libpas is enabled. To get around this, we can split WTF_MAKE_TZONE_OR_ISO_ALLOCATED_EXPORT and WTF_MAKE_TZONE_OR_ISO_ALLOCATED_EXPORT_IN_EXPORTED_CLASS, so WTF_MAKE_TZONE_OR_ISO_ALLOCATED_EXPORT_IN_EXPORTED_CLASS can be made into WTF_NOEXPORT on Windows. 2101505 1 ian.grunert 2025-03-07 15:06:47 -0800 Pull request: https://github.com/WebKit/WebKit/pull/41773 2101518 2 ews-feeder 2025-03-07 15:36:49 -0800 Committed 291811@main (a4ec5bc90ef5): <https://commits.webkit.org/291811@main> Reviewed commits have been landed. Closing PR #41773 and removing active labels. 2101519 3 webkit-bug-importer 2025-03-07 15:37:16 -0800 <rdar://problem/146515863>