28887 2009-09-01 13:12:57 -0700 Expose functions to change the focus ring color for Linux Chromium 2009-09-02 13:46:00 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 estade webkit-unassigned agl eric oldest_to_newest 143983 0 estade 2009-09-01 13:12:57 -0700 we will use this to make the focus ring match the system theme. 143987 1 38882 estade 2009-09-01 13:15:23 -0700 Created attachment 38882 patch 143988 2 estade 2009-09-01 13:15:55 -0700 chromium side is http://codereview.chromium.org/173642 144017 3 agl 2009-09-01 15:53:00 -0700 I am not a WebKit reviewer. You'll have to send it to someone who is, but LGTM. 144112 4 38882 levin 2009-09-01 22:16:45 -0700 Comment on attachment 38882 patch > Index: WebCore/rendering/RenderThemeChromiumLinux.h > + void setFocusRingColor(const Color& color); Parameter names shouldn't be included if they don't add information, so remove "color" on landing this. 144242 5 estade 2009-09-02 10:36:59 -0700 thanks for the review. I am not a committer. 144243 6 agl 2009-09-02 10:38:05 -0700 estate: if you update the patch, I can mark it for commit queue. 144255 7 38934 estade 2009-09-02 11:32:29 -0700 Created attachment 38934 ditched variable name updated 144274 8 38934 eric 2009-09-02 13:04:51 -0700 Comment on attachment 38934 ditched variable name Turns out the commit-queue spins if patches are marked cq+ w/o being reviewd. :( bug 28916. I'll fix it. But for now, markign this r+ too. :) 144275 9 38934 eric 2009-09-02 13:05:40 -0700 Comment on attachment 38934 ditched variable name Rejecting patch 38934 from commit-queue. This patch will require manual commit. WebKitTools/Scripts/build-webkit failed with exit code 1 144277 10 estade 2009-09-02 13:10:26 -0700 does the above message mean that it failed to compile? 144281 11 38934 eric 2009-09-02 13:20:48 -0700 Comment on attachment 38934 ditched variable name build-webkit was broken for a moment. Not sure why the bots weren't showing it. 144285 12 38934 eric 2009-09-02 13:31:33 -0700 Comment on attachment 38934 ditched variable name Rejecting patch 38934 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None 144286 13 38934 eric 2009-09-02 13:34:18 -0700 Comment on attachment 38934 ditched variable name The commit-queue hates us tonight. Race condition during commit. bug 28316. 144290 14 38934 eric 2009-09-02 13:45:56 -0700 Comment on attachment 38934 ditched variable name Clearing flags on attachment: 38934 Committed r47992: <http://trac.webkit.org/changeset/47992> 144291 15 eric 2009-09-02 13:46:00 -0700 All reviewed patches have been landed. Closing bug. 38882 2009-09-01 13:15:23 -0700 2009-09-02 13:04:13 -0700 patch focusring.diff text/plain 2669 estade SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Nzk0NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDktMDEgIEV2YW4gU3RhZGUgIDxlc3RhZGVAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4 cG9zZSBmdW5jdGlvbnMgdG8gY2hhbmdlIHRoZSBmb2N1cyByaW5nIGNvbG9yIGZvciBMaW51eCBD aHJvbWl1bQorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yODg4NworCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUNocm9taXVtTGludXg6OlJlbmRlclRo ZW1lQ2hyb21pdW1MaW51eCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUNocm9taXVt TGludXg6OnNldEZvY3VzUmluZ0NvbG9yKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1l Q2hyb21pdW1MaW51eDo6cGxhdGZvcm1Gb2N1c1JpbmdDb2xvcik6CisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5oOgorCiAyMDA5LTA4LTMxICBKb24gSG9uZXlj dXR0ICA8amhvbmV5Y3V0dEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHRoZSB3b3JrYXJv dW5kIGFkZGVkIGluIHI0NzMxNi4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1l Q2hyb21pdW1MaW51eC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWVDaHJvbWl1bUxpbnV4LmNwcAkocmV2aXNpb24gNDc5NDYpCisrKyBXZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUaGVtZUNocm9taXVtTGludXguY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NCw2 ICs0NCw3IEBAIFBhc3NSZWZQdHI8UmVuZGVyVGhlbWU+IFJlbmRlclRoZW1lOjp0aGUKIH0KIAog UmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4OjpSZW5kZXJUaGVtZUNocm9taXVtTGludXgoKQorICAg IDogbV91c2VEZWZhdWx0Rm9jdXNSaW5nQ29sb3IodHJ1ZSkKIHsKIH0KIApAQCAtOTEsNiArOTIs MTkgQEAgQ29sb3IgUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4OjppbmFjdGl2ZQogICAgIHJldHVy biBDb2xvcigweDMyLCAweDMyLCAweDMyKTsKIH0KIAordm9pZCBSZW5kZXJUaGVtZUNocm9taXVt TGludXg6OnNldEZvY3VzUmluZ0NvbG9yKGNvbnN0IENvbG9yJiBjb2xvcikKK3sKKyAgICBtX2Zv Y3VzUmluZ0NvbG9yID0gY29sb3I7CisgICAgbV91c2VEZWZhdWx0Rm9jdXNSaW5nQ29sb3IgPSBm YWxzZTsKK30KKworQ29sb3IgUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4OjpwbGF0Zm9ybUZvY3Vz UmluZ0NvbG9yKCkgY29uc3QKK3sKKyAgICBpZiAobV91c2VEZWZhdWx0Rm9jdXNSaW5nQ29sb3Ip CisgICAgICAgIHJldHVybiBSZW5kZXJUaGVtZUNocm9taXVtU2tpYTo6cGxhdGZvcm1Gb2N1c1Jp bmdDb2xvcigpOworICAgIHJldHVybiBtX2ZvY3VzUmluZ0NvbG9yOworfQorCiBib29sIFJlbmRl clRoZW1lQ2hyb21pdW1MaW51eDo6c3VwcG9ydHNDb250cm9sVGludHMoKSBjb25zdAogewogICAg IHJldHVybiB0cnVlOwpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1 bUxpbnV4LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJv bWl1bUxpbnV4LmgJKHJldmlzaW9uIDQ3OTQ2KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWVDaHJvbWl1bUxpbnV4LmgJKHdvcmtpbmcgY29weSkKQEAgLTQ5LDEyICs0OSwxOCBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZpcnR1YWwgQ29sb3IgaW5hY3RpdmVMaXN0Qm94 U2VsZWN0aW9uQmFja2dyb3VuZENvbG9yKCkgY29uc3Q7CiAgICAgICAgIHZpcnR1YWwgQ29sb3Ig aW5hY3RpdmVMaXN0Qm94U2VsZWN0aW9uRm9yZWdyb3VuZENvbG9yKCkgY29uc3Q7CiAKKyAgICAg ICAgdm9pZCBzZXRGb2N1c1JpbmdDb2xvcihjb25zdCBDb2xvciYgY29sb3IpOworICAgICAgICB2 aXJ0dWFsIENvbG9yIHBsYXRmb3JtRm9jdXNSaW5nQ29sb3IoKSBjb25zdDsKKwogICAgIHByaXZh dGU6CiAgICAgICAgIFJlbmRlclRoZW1lQ2hyb21pdW1MaW51eCgpOwogICAgICAgICB2aXJ0dWFs IH5SZW5kZXJUaGVtZUNocm9taXVtTGludXgoKTsKIAogICAgICAgICAvLyBBIGdlbmVyYWwgbWV0 aG9kIGFza2luZyBpZiBhbnkgY29udHJvbCB0aW50aW5nIGlzIHN1cHBvcnRlZCBhdCBhbGwuCiAg ICAgICAgIHZpcnR1YWwgYm9vbCBzdXBwb3J0c0NvbnRyb2xUaW50cygpIGNvbnN0OworCisgICAg ICAgIENvbG9yIG1fZm9jdXNSaW5nQ29sb3I7CisgICAgICAgIGJvb2wgbV91c2VEZWZhdWx0Rm9j dXNSaW5nQ29sb3I7CiAgICAgfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 38934 2009-09-02 11:32:29 -0700 2009-09-02 13:45:56 -0700 ditched variable name focusring.diff text/plain 2663 estade SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Nzk0NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDktMDEgIEV2YW4gU3RhZGUgIDxlc3RhZGVAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4 cG9zZSBmdW5jdGlvbnMgdG8gY2hhbmdlIHRoZSBmb2N1cyByaW5nIGNvbG9yIGZvciBMaW51eCBD aHJvbWl1bQorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yODg4NworCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUNocm9taXVtTGludXg6OlJlbmRlclRo ZW1lQ2hyb21pdW1MaW51eCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUNocm9taXVt TGludXg6OnNldEZvY3VzUmluZ0NvbG9yKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1l Q2hyb21pdW1MaW51eDo6cGxhdGZvcm1Gb2N1c1JpbmdDb2xvcik6CisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5oOgorCiAyMDA5LTA4LTMxICBKb24gSG9uZXlj dXR0ICA8amhvbmV5Y3V0dEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHRoZSB3b3JrYXJv dW5kIGFkZGVkIGluIHI0NzMxNi4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1l Q2hyb21pdW1MaW51eC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWVDaHJvbWl1bUxpbnV4LmNwcAkocmV2aXNpb24gNDc5NDYpCisrKyBXZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUaGVtZUNocm9taXVtTGludXguY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NCw2 ICs0NCw3IEBAIFBhc3NSZWZQdHI8UmVuZGVyVGhlbWU+IFJlbmRlclRoZW1lOjp0aGUKIH0KIAog UmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4OjpSZW5kZXJUaGVtZUNocm9taXVtTGludXgoKQorICAg IDogbV91c2VEZWZhdWx0Rm9jdXNSaW5nQ29sb3IodHJ1ZSkKIHsKIH0KIApAQCAtOTEsNiArOTIs MTkgQEAgQ29sb3IgUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4OjppbmFjdGl2ZQogICAgIHJldHVy biBDb2xvcigweDMyLCAweDMyLCAweDMyKTsKIH0KIAordm9pZCBSZW5kZXJUaGVtZUNocm9taXVt TGludXg6OnNldEZvY3VzUmluZ0NvbG9yKGNvbnN0IENvbG9yJiBjb2xvcikKK3sKKyAgICBtX2Zv Y3VzUmluZ0NvbG9yID0gY29sb3I7CisgICAgbV91c2VEZWZhdWx0Rm9jdXNSaW5nQ29sb3IgPSBm YWxzZTsKK30KKworQ29sb3IgUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4OjpwbGF0Zm9ybUZvY3Vz UmluZ0NvbG9yKCkgY29uc3QKK3sKKyAgICBpZiAobV91c2VEZWZhdWx0Rm9jdXNSaW5nQ29sb3Ip CisgICAgICAgIHJldHVybiBSZW5kZXJUaGVtZUNocm9taXVtU2tpYTo6cGxhdGZvcm1Gb2N1c1Jp bmdDb2xvcigpOworICAgIHJldHVybiBtX2ZvY3VzUmluZ0NvbG9yOworfQorCiBib29sIFJlbmRl clRoZW1lQ2hyb21pdW1MaW51eDo6c3VwcG9ydHNDb250cm9sVGludHMoKSBjb25zdAogewogICAg IHJldHVybiB0cnVlOwpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1 bUxpbnV4LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJv bWl1bUxpbnV4LmgJKHJldmlzaW9uIDQ3OTQ2KQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWVDaHJvbWl1bUxpbnV4LmgJKHdvcmtpbmcgY29weSkKQEAgLTQ5LDEyICs0OSwxOCBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZpcnR1YWwgQ29sb3IgaW5hY3RpdmVMaXN0Qm94 U2VsZWN0aW9uQmFja2dyb3VuZENvbG9yKCkgY29uc3Q7CiAgICAgICAgIHZpcnR1YWwgQ29sb3Ig aW5hY3RpdmVMaXN0Qm94U2VsZWN0aW9uRm9yZWdyb3VuZENvbG9yKCkgY29uc3Q7CiAKKyAgICAg ICAgdm9pZCBzZXRGb2N1c1JpbmdDb2xvcihjb25zdCBDb2xvciYpOworICAgICAgICB2aXJ0dWFs IENvbG9yIHBsYXRmb3JtRm9jdXNSaW5nQ29sb3IoKSBjb25zdDsKKwogICAgIHByaXZhdGU6CiAg ICAgICAgIFJlbmRlclRoZW1lQ2hyb21pdW1MaW51eCgpOwogICAgICAgICB2aXJ0dWFsIH5SZW5k ZXJUaGVtZUNocm9taXVtTGludXgoKTsKIAogICAgICAgICAvLyBBIGdlbmVyYWwgbWV0aG9kIGFz a2luZyBpZiBhbnkgY29udHJvbCB0aW50aW5nIGlzIHN1cHBvcnRlZCBhdCBhbGwuCiAgICAgICAg IHZpcnR1YWwgYm9vbCBzdXBwb3J0c0NvbnRyb2xUaW50cygpIGNvbnN0OworCisgICAgICAgIENv bG9yIG1fZm9jdXNSaW5nQ29sb3I7CisgICAgICAgIGJvb2wgbV91c2VEZWZhdWx0Rm9jdXNSaW5n Q29sb3I7CiAgICAgfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=