28883 2009-09-01 11:57:10 -0700 [V8] FileList cannot be accessed via index in Chromium. 2009-09-01 13:17:50 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jianli jianli dglazkov levin oldest_to_newest 143967 0 jianli 2009-09-01 11:57:10 -0700 Need to fix V8 binding code to access the indexed property of FileList. 143973 1 38877 jianli 2009-09-01 12:11:11 -0700 Created attachment 38877 Proposed Patch 143974 2 38877 dglazkov 2009-09-01 12:14:25 -0700 Comment on attachment 38877 Proposed Patch r=me. 143976 3 levin 2009-09-01 12:18:57 -0700 Hmm.. twice reviewed :) Consider fixing these on landing. > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > +2009-09-01 Jian Li <jianli@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + [V8] FileList cannot be accessed via index in Chromium. > + https://bugs.webkit.org/show_bug.cgi?id=28883 > + > + The test is covered by clipboard-file-access.html. Tested by clipboard-file-access.html. > diff --git a/WebCore/bindings/v8/custom/V8FileListCustom.cpp b/WebCore/bindings/v8/custom/V8FileListCustom.cpp > +#include "config.h" > +#include "FileList.h" > + > +#include "File.h" I don't understand why there is a blank line here. > + > +#include "V8Binding.h" > +#include "V8CustomBinding.h" > +INDEXED_PROPERTY_GETTER(FileList) > +{ > + INC_STATS("DOM.FileList.IndexedPropertyGetter"); > + FileList* imp = V8DOMWrapper::convertToNativeObject<FileList>(V8ClassIndex::FILELIST, info.Holder()); Use full words for variables "imp". Perhaps "fileList" instead? > + RefPtr<File> result = imp->item(index); "result" doesn't sound like a very descriptive variable name. How about "file"? 143990 4 jianli 2009-09-01 13:17:50 -0700 All fixed and committed as http://trac.webkit.org/changeset/47947. 38877 2009-09-01 12:11:11 -0700 2009-09-01 12:14:25 -0700 Proposed Patch 28883 text/plain 5104 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDQ2Nzk5YS4uZTY4N2VmOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0wOS0wMSAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW1Y4XSBGaWxlTGlzdCBjYW5ub3QgYmUgYWNjZXNzZWQgdmlhIGluZGV4IGlu IENocm9taXVtLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Mjg4ODMKKworICAgICAgICBUaGUgdGVzdCBpcyBjb3ZlcmVkIGJ5IGNsaXBib2FyZC1maWxl LWFjY2Vzcy5odG1sLgorCisgICAgICAgICogV2ViQ29yZS5neXBpOgorICAgICAgICAqIGJpbmRp bmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOERPTVdyYXBwZXI6 OmdldFRlbXBsYXRlKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhDdXN0b21CaW5k aW5nLmg6CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4RmlsZUxpc3RDdXN0b20uY3Bw OiBBZGRlZC4KKwogMjAwOS0wOS0wMSAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCmRpZmYgLS1naXQg YS9XZWJDb3JlL1dlYkNvcmUuZ3lwaSBiL1dlYkNvcmUvV2ViQ29yZS5neXBpCmluZGV4IGYwYmRk NTguLmE5MzVjMzMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS5neXBpCisrKyBiL1dlYkNv cmUvV2ViQ29yZS5neXBpCkBAIC02MzcsNiArNjM3LDcgQEAKICAgICAgICAgICAgICdiaW5kaW5n cy92OC9jdXN0b20vVjhEb2N1bWVudEN1c3RvbS5jcHAnLAogICAgICAgICAgICAgJ2JpbmRpbmdz L3Y4L2N1c3RvbS9WOEVsZW1lbnRDdXN0b20uY3BwJywKICAgICAgICAgICAgICdiaW5kaW5ncy92 OC9jdXN0b20vVjhFdmVudEN1c3RvbS5jcHAnLAorICAgICAgICAgICAgJ2JpbmRpbmdzL3Y4L2N1 c3RvbS9WOEZpbGVMaXN0Q3VzdG9tLmNwcCcsCiAgICAgICAgICAgICAnYmluZGluZ3MvdjgvY3Vz dG9tL1Y4SFRNTEF1ZGlvRWxlbWVudENvbnN0cnVjdG9yLmNwcCcsCiAgICAgICAgICAgICAnYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTENhbnZhc0VsZW1lbnRDdXN0b20uY3BwJywKICAgICAgICAg ICAgICdiaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MQ29sbGVjdGlvbkN1c3RvbS5jcHAnLApkaWZm IC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwIGIvV2ViQ29yZS9i aW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCmluZGV4IGViMWFkNzcuLmM2ZTBjYWQgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcAorKysgYi9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKQEAgLTQ5MSw2ICs0OTEsOSBAQCB2ODo6UGVy c2lzdGVudDx2ODo6RnVuY3Rpb25UZW1wbGF0ZT4gVjhET01XcmFwcGVyOjpnZXRUZW1wbGF0ZShW OENsYXNzSW5kZXg6OlY4VwogICAgIGNhc2UgVjhDbGFzc0luZGV4OjpDTElFTlRSRUNUTElTVDoK ICAgICAgICAgZGVzY3JpcHRvci0+SW5zdGFuY2VUZW1wbGF0ZSgpLT5TZXRJbmRleGVkUHJvcGVy dHlIYW5kbGVyKFVTRV9JTkRFWEVEX1BST1BFUlRZX0dFVFRFUihDbGllbnRSZWN0TGlzdCkpOwog ICAgICAgICBicmVhazsKKyAgICBjYXNlIFY4Q2xhc3NJbmRleDo6RklMRUxJU1Q6CisgICAgICAg IGRlc2NyaXB0b3ItPkluc3RhbmNlVGVtcGxhdGUoKS0+U2V0SW5kZXhlZFByb3BlcnR5SGFuZGxl cihVU0VfSU5ERVhFRF9QUk9QRVJUWV9HRVRURVIoRmlsZUxpc3QpKTsKKyAgICAgICAgYnJlYWs7 CiAjaWYgRU5BQkxFKERBVEFHUklEKQogICAgIGNhc2UgVjhDbGFzc0luZGV4OjpEQVRBR1JJRENP TFVNTkxJU1Q6CiAgICAgICAgIGRlc2NyaXB0b3ItPkluc3RhbmNlVGVtcGxhdGUoKS0+U2V0SW5k ZXhlZFByb3BlcnR5SGFuZGxlcihVU0VfSU5ERVhFRF9QUk9QRVJUWV9HRVRURVIoRGF0YUdyaWRD b2x1bW5MaXN0KSk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEN1 c3RvbUJpbmRpbmcuaCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q3VzdG9tQmluZGlu Zy5oCmluZGV4IDEwNzViZjguLmFlOWY5Y2UgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3Mv djgvY3VzdG9tL1Y4Q3VzdG9tQmluZGluZy5oCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3Vz dG9tL1Y4Q3VzdG9tQmluZGluZy5oCkBAIC00NzcsNiArNDc3LDcgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogICAgICAgICBERUNMQVJFX0NBTExCQUNLKFNRTFJlc3VsdFNldFJvd0xpc3RJdGVtKTsK IAogICAgICAgICBERUNMQVJFX0lOREVYRURfUFJPUEVSVFlfR0VUVEVSKENsaWVudFJlY3RMaXN0 KTsKKyAgICAgICAgREVDTEFSRV9JTkRFWEVEX1BST1BFUlRZX0dFVFRFUihGaWxlTGlzdCk7CiAg IAogI2lmIEVOQUJMRShEQVRBR1JJRCkKICAgICAgICAgREVDTEFSRV9QUk9QRVJUWV9BQ0NFU1NP UihIVE1MRGF0YUdyaWRFbGVtZW50RGF0YVNvdXJjZSk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L2N1c3RvbS9WOEZpbGVMaXN0Q3VzdG9tLmNwcCBiL1dlYkNvcmUvYmluZGluZ3Mv djgvY3VzdG9tL1Y4RmlsZUxpc3RDdXN0b20uY3BwCm5ldyBmaWxlIG1vZGUgMTAwNzU1CmluZGV4 IDAwMDAwMDAuLjk0ZGYyZGUKLS0tIC9kZXYvbnVsbAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4 L2N1c3RvbS9WOEZpbGVMaXN0Q3VzdG9tLmNwcApAQCAtMCwwICsxLDU1IEBACisvKgorICogQ29w eXJpZ2h0IChDKSAyMDA5IEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKgorICog UmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBv ciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0 aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCisgKiBtZXQ6CisgKgorICogICAgICogUmVkaXN0 cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQK KyAqIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlz Y2xhaW1lci4KKyAqICAgICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJl cHJvZHVjZSB0aGUgYWJvdmUKKyAqIGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25k aXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIKKyAqIGluIHRoZSBkb2N1bWVudGF0 aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUKKyAqIGRpc3RyaWJ1 dGlvbi4KKyAqICAgICAqIE5laXRoZXIgdGhlIG5hbWUgb2YgR29vZ2xlIEluYy4gbm9yIHRoZSBu YW1lcyBvZiBpdHMKKyAqIGNvbnRyaWJ1dG9ycyBtYXkgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHBy b21vdGUgcHJvZHVjdHMgZGVyaXZlZCBmcm9tCisgKiB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3Bl Y2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMg UFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFORCBDT05UUklCVVRPUlMKKyAqICJB UyBJUyIgQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBC VVQgTk9UCisgKiBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5U QUJJTElUWSBBTkQgRklUTkVTUyBGT1IKKyAqIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRSBESVND TEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUCisgKiBPV05FUiBPUiBDT05U UklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwK KyAqIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJ TkcsIEJVVCBOT1QKKyAqIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09P RFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLAorICogREFUQSwgT1IgUFJPRklUUzsgT1IgQlVT SU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZCisgKiBUSEVPUlkg T0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBU T1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFO WSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNF RCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2luY2x1ZGUgImNv bmZpZy5oIgorI2luY2x1ZGUgIkZpbGVMaXN0LmgiCisKKyNpbmNsdWRlICJGaWxlLmgiCisKKyNp bmNsdWRlICJWOEJpbmRpbmcuaCIKKyNpbmNsdWRlICJWOEN1c3RvbUJpbmRpbmcuaCIKKyNpbmNs dWRlICJWOFByb3h5LmgiCisKKyNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+CisKK25hbWVzcGFjZSBX ZWJDb3JlIHsKKworSU5ERVhFRF9QUk9QRVJUWV9HRVRURVIoRmlsZUxpc3QpCit7CisgICAgSU5D X1NUQVRTKCJET00uRmlsZUxpc3QuSW5kZXhlZFByb3BlcnR5R2V0dGVyIik7CisgICAgRmlsZUxp c3QqIGltcCA9IFY4RE9NV3JhcHBlcjo6Y29udmVydFRvTmF0aXZlT2JqZWN0PEZpbGVMaXN0PihW OENsYXNzSW5kZXg6OkZJTEVMSVNULCBpbmZvLkhvbGRlcigpKTsKKyAgICBSZWZQdHI8RmlsZT4g cmVzdWx0ID0gaW1wLT5pdGVtKGluZGV4KTsKKyAgICBpZiAoIXJlc3VsdCkKKyAgICAgICAgcmV0 dXJuIG5vdEhhbmRsZWRCeUludGVyY2VwdG9yKCk7CisKKyAgICByZXR1cm4gVjhET01XcmFwcGVy Ojpjb252ZXJ0VG9WOE9iamVjdChWOENsYXNzSW5kZXg6OkZJTEUsIHJlc3VsdC5yZWxlYXNlKCkp OworfQorCit9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==