288819 2025-02-28 02:34:56 -0800 [css-grid] `ASSERT(!isCalculated())` in `Length::value()` is hit under `RenderGrid::computeAutoRepeatTracksCount()` when loading https://kizu.dev/position-driven-styles/ 2025-05-01 07:34:57 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/52275 InRadar P2 Normal --- 1 graouts sgill26 bfulgham koivisto sgill26 simon.fraser webkit-bug-importer zalan zsun oldest_to_newest 2099163 0 graouts 2025-02-28 02:34:56 -0800 If you load https://kizu.dev/position-driven-styles/ with a ToT (291310@main) debug build, you hit `ASSERT(!isCalculated())` in `Length::value()` under a line `RenderGrid::computeAutoRepeatTracksCount()`. This occurs as the `transform` computed style is requested. 2099164 1 graouts 2025-02-28 02:38:07 -0800 This page uses Scroll-driven Animations and that assertion is not hit if that flag is disabled. However the stack trace does not involve the animation code. 2101328 2 webkit-bug-importer 2025-03-07 02:35:15 -0800 <rdar://problem/146466356> 2114309 3 475098 sgill26 2025-04-30 14:28:28 -0700 Created attachment 475098 Reduced test case Attaching reduced test case. It seems like this code is attempting to apply the following logic from the spec when it comes to determine the count of the auto repeat rows: "For this purpose, each track is treated as its max track sizing function if that is definite or else its min track sizing function if that is definite. If both are definite, floor the max track sizing function by the min track sizing function. If neither are definite, the number of repetitions is one." https://drafts.csswg.org/css-grid-2/#auto-repeat We seem to fail to consider calc values here and presumably we should be using valueForLength in order to compute a proper value 2114320 4 sgill26 2025-04-30 14:50:28 -0700 Pull request: https://github.com/WebKit/WebKit/pull/44764 2114359 5 sgill26 2025-04-30 20:36:34 -0700 Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/52275 2114410 6 ews-feeder 2025-05-01 07:34:54 -0700 Committed 294374@main (417c5cd1cddf): <https://commits.webkit.org/294374@main> Reviewed commits have been landed. Closing PR #44764 and removing active labels. 475098 2025-04-30 14:28:28 -0700 2025-04-30 14:28:28 -0700 Reduced test case reduced.html text/html 449 sgill26 PCFET0NUWVBFIGh0bWw+IA0KPGh0bWw+DQo8aGVhZD4NCjxzdHlsZT4NCiAgLmdyaWQgew0KICAg IGRpc3BsYXk6IGdyaWQ7DQogICAgd2lkdGg6IDEwMHB4Ow0KICAgIGdyaWQtdGVtcGxhdGUtY29s dW1uczogcmVwZWF0KGF1dG8tZml0LCBtaW5tYXgoY2FsYygxMDAlIC0gMTBweCksIGNhbGMoMTAw JSAtIDEwMHB4KSkpOw0KICAgIGJhY2tncm91bmQtY29sb3I6IGdyZWVuOw0KICB9DQo8L3N0eWxl Pg0KPC9oZWFkPg0KICA8Ym9keT4NCiAgICA8cD5UZXN0IHBhc3NlcyBpZiB0aGVyZSBpcyBhIGZp bGxlZCBncmVlbiBzcXVhcmUuPC9wPg0KICAgIDxkaXYgY2xhc3M9ImdyaWQiPg0KICAgICAgPGRp diBzdHlsZT0iaGVpZ2h0OiA1MHB4OyI+PC9kaXY+DQogICAgICA8ZGl2IHN0eWxlPSJoZWlnaHQ6 IDUwcHg7Ij48L2Rpdj4NCiAgICA8L2Rpdj4NCiAgPC9ib2R5Pg0KPC9odG1sPg0KDQo=