28881 2009-09-01 11:38:02 -0700 svn-create-patch should check if the repo path is the same when trying to find the root 2009-09-02 18:45:09 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca webkit-unassigned abarth ddkilzer eric mrowe pkasting oldest_to_newest 143956 0 andersca 2009-09-01 11:38:02 -0700 Currently, when svn-create-patch checks for the repository root it only checks if the repository UUID is the same. It needs to check that the repository path is the same as well. 143968 1 ddkilzer 2009-09-01 12:00:21 -0700 svn-create-patch switched from repository root to UUID in r46134. <http://trac.webkit.org/changeset/46134> For situations where you have two nested working directories that are from the same repository (but at different repository roots), it's necessary to check both the repository root and the UUID. 143984 2 38881 ddkilzer 2009-09-01 13:13:37 -0700 Created attachment 38881 Patch v1 144127 3 38881 eric 2009-09-02 00:27:36 -0700 Comment on attachment 38881 Patch v1 Looks good to me. So sad that we don't have unit tests for this sort of thing. :( It's possible to test this stuff via scm.py for sure. cq- for ChangeLog patch and because yor'e a committer. 144199 4 abarth 2009-09-02 06:26:40 -0700 We have this bug in one of the bugzilla-tool python modules too (probably scm.py). 144224 5 38881 ddkilzer 2009-09-02 08:55:39 -0700 Comment on attachment 38881 Patch v1 (In reply to comment #4) > We have this bug in one of the bugzilla-tool python modules too (probably > scm.py). Will fix scm.py as well. 144336 6 ddkilzer 2009-09-02 16:52:07 -0700 (In reply to comment #3) > (From update of attachment 38881 [details]) > Looks good to me. So sad that we don't have unit tests for this sort of thing. > :( It's possible to test this stuff via scm.py for sure. cq- for ChangeLog > patch and because yor'e a committer. (In reply to comment #4) > We have this bug in one of the bugzilla-tool python modules too (probably > scm.py). I filed Bug 28925 instead. Don't have time to work on this right now, and it's not causing any known issues for WebKit contributors. 144366 7 ddkilzer 2009-09-02 18:45:09 -0700 Committed r48003: <http://trac.webkit.org/changeset/48003> 38881 2009-09-01 13:13:37 -0700 2009-09-02 08:55:39 -0700 Patch v1 bug-28881-20090901131336.patch text/plain 2641 ddkilzer ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2Mjk2Y2ViLi5hYjBjYTczIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMDktMDkt MDEgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAorICAgICAgICA8aHR0cDov L3dlYmtpdC5vcmcvYi8yODg4MT4gc3ZuLWNyZWF0ZS1wYXRjaCBzaG91bGQgY2hlY2sgaWYgdGhl IHJlcG8gcGF0aCBpcyB0aGUgc2FtZSB3aGVuIHRyeWluZyB0byBmaW5kIHRoZSByb290CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL1ZD U1V0aWxzLnBtOgorICAgICAgICAoZGV0ZXJtaW5lU3ZuUm9vdCk6IEFkZGVkIGJhY2sgY2hlY2sg Zm9yIHJlcG9zaXRvcnkgcm9vdCB0aGF0CisgICAgICAgIHdhcyByZW1vdmVkIGluIHI0NjEzNCB3 aGVuIHRoaXMgY29kZSBsaXZlZCBpbiBzdm4tY3JlYXRlLXBhdGNoLgorICAgICAgICBJdCdzIG5l Y2Vzc2FyeSB0byBjaGVjayBib3RoIHRoZSByZXBvc2l0b3J5IHJvb3QgYW5kIHRoZQorICAgICAg ICByZXBvc2l0b3J5IFVVSUQgaW4gY2FzZSB0d28gZGlmZmVyZW50IHdvcmtpbmcgZGlyZWN0b3Jp ZXMgYXJlCisgICAgICAgIGNoZWNrZWQgb3V0IGZyb20gdGhlIHNhbWUgcmVwb3NpdG9yeS4KKwor MjAwOS0wOS0wMSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCiAgICAgICAg IDxodHRwOi8vd2Via2l0Lm9yZy9iLzI4ODgwPiBzdm4tYXBwbHkgLS1mb3JjZSBkb2Vzbid0IGFj dHVhbGx5IHdvcmsKIAogICAgICAgICBSZXZpZXdlZCBieSBCcmFkeSBFaWRzb24uCmRpZmYgLS1n aXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtIGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy9WQ1NVdGlscy5wbQppbmRleCA1NzE0ODdkLi45MWZmMmQ5IDEwMDY0NAotLS0gYS9XZWJLaXRU b29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtCisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvVkNTVXRp bHMucG0KQEAgLTEyOCwyOCArMTI4LDM4IEBAIHN1YiBkZXRlcm1pbmVTVk5Sb290KCkKICAgICBt eSAkbGFzdCA9ICcnOwogICAgIG15ICRwYXRoID0gJy4nOwogICAgIG15ICRwYXJlbnQgPSAnLi4n OworICAgIG15ICRyZXBvc2l0b3J5Um9vdDsKICAgICBteSAkcmVwb3NpdG9yeVVVSUQ7CiAgICAg d2hpbGUgKDEpIHsKKyAgICAgICAgbXkgJHRoaXNSb290OwogICAgICAgICBteSAkdGhpc1VVSUQ7 CiAgICAgICAgICMgSWdub3JlIGVycm9yIG1lc3NhZ2VzIGluIGNhc2Ugd2UndmUgcnVuIHBhc3Qg dGhlIHJvb3Qgb2YgdGhlIGNoZWNrb3V0LgogICAgICAgICBvcGVuIElORk8sICJzdm4gaW5mbyAn JHBhdGgnIDI+ICRkZXZOdWxsIHwiIG9yIGRpZTsKICAgICAgICAgd2hpbGUgKDxJTkZPPikgewor ICAgICAgICAgICAgaWYgKC9eUmVwb3NpdG9yeSBSb290OiAoLispLykgeworICAgICAgICAgICAg ICAgICR0aGlzUm9vdCA9ICQxOworICAgICAgICAgICAgfQogICAgICAgICAgICAgaWYgKC9eUmVw b3NpdG9yeSBVVUlEOiAoLispLykgewogICAgICAgICAgICAgICAgICR0aGlzVVVJRCA9ICQxOwot ICAgICAgICAgICAgICAgIHsgbG9jYWwgJC8gPSB1bmRlZjsgPElORk8+OyB9ICAjIENvbnN1bWUg dGhlIHJlc3Qgb2YgdGhlIGlucHV0LgorICAgICAgICAgICAgfQorICAgICAgICAgICAgaWYgKCR0 aGlzUm9vdCAmJiAkdGhpc1VVSUQpIHsKKyAgICAgICAgICAgICAgICBsb2NhbCAkLyA9IHVuZGVm OworICAgICAgICAgICAgICAgIDxJTkZPPjsgIyBDb25zdW1lIHRoZSByZXN0IG9mIHRoZSBpbnB1 dC4KICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAgICBjbG9zZSBJTkZPOwogCiAgICAg ICAgICMgSXQncyBwb3NzaWJsZSAoZS5nLiBmb3IgZGV2ZWxvcGVycyBvZiBzb21lIHBvcnRzKSB0 byBoYXZlIGEgV2ViS2l0CiAgICAgICAgICMgY2hlY2tvdXQgaW4gYSBzdWJkaXJlY3Rvcnkgb2Yg YW5vdGhlciBjaGVja291dC4gIFNvIGFib3J0IGlmIHRoZQotICAgICAgICAjIHJlcG9zaXRvcnkg VVVJRCBzdWRkZW5seSBjaGFuZ2VzLgorICAgICAgICAjIHJlcG9zaXRvcnkgcm9vdCBvciB0aGUg cmVwb3NpdG9yeSBVVUlEIHN1ZGRlbmx5IGNoYW5nZXMuCiAgICAgICAgIGxhc3QgaWYgISR0aGlz VVVJRDsKLSAgICAgICAgaWYgKCEkcmVwb3NpdG9yeVVVSUQpIHsKLSAgICAgICAgICAgICRyZXBv c2l0b3J5VVVJRCA9ICR0aGlzVVVJRDsKLSAgICAgICAgfQorICAgICAgICAkcmVwb3NpdG9yeVVV SUQgPSAkdGhpc1VVSUQgaWYgISRyZXBvc2l0b3J5VVVJRDsKICAgICAgICAgbGFzdCBpZiAkdGhp c1VVSUQgbmUgJHJlcG9zaXRvcnlVVUlEOwogCisgICAgICAgIGxhc3QgaWYgISR0aGlzUm9vdDsK KyAgICAgICAgJHJlcG9zaXRvcnlSb290ID0gJHRoaXNSb290IGlmICEkcmVwb3NpdG9yeVJvb3Q7 CisgICAgICAgIGxhc3QgaWYgJHRoaXNSb290IG5lICRyZXBvc2l0b3J5Um9vdDsKKwogICAgICAg ICAkbGFzdCA9ICRwYXRoOwogICAgICAgICAkcGF0aCA9IEZpbGU6OlNwZWMtPmNhdGRpcigkcGFy ZW50LCAkcGF0aCk7CiAgICAgfQ==