28860 2009-08-31 16:48:22 -0700 SVGSVGElement suspend methods argument/return types incorrect 2009-09-01 04:12:03 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED P2 Trivial --- 1 heycam webkit-unassigned eric oldest_to_newest 143753 0 heycam 2009-08-31 16:48:22 -0700 Should be "unsigned" rather than "unsigned long". 143755 1 38844 heycam 2009-08-31 16:50:49 -0700 Created attachment 38844 Patch v1 Not adding any tests since the methods aren't implemented yet anyway. 143782 2 38844 eric 2009-09-01 00:24:38 -0700 Comment on attachment 38844 Patch v1 I would probably have called "maxWaitMilliseconds" "maxWaitInMilliseconds". Looks fine though. :) 143786 3 38844 eric 2009-09-01 00:38:31 -0700 Comment on attachment 38844 Patch v1 Rejecting patch 38844 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 143797 4 38844 eric 2009-09-01 02:17:54 -0700 Comment on attachment 38844 Patch v1 media/video-seeking.html -> failed I think it's just another flakey media test. :( 143843 5 38844 eric 2009-09-01 04:11:59 -0700 Comment on attachment 38844 Patch v1 Clearing flags on attachment: 38844 Committed r47926: <http://trac.webkit.org/changeset/47926> 143844 6 eric 2009-09-01 04:12:03 -0700 All reviewed patches have been landed. Closing bug. 38844 2009-08-31 16:50:49 -0700 2009-09-01 04:11:59 -0700 Patch v1 28860.patch text/plain 2104 heycam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzkxNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDgtMzEgIENhbWVyb24gTWNDb3JtYWNrICA8Y2FtQG1jYy5p ZC5hdT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBT VkdTVkdFbGVtZW50IHN1c3BlbmQgbWV0aG9kcyBhcmd1bWVudC9yZXR1cm4gdHlwZXMgaW5jb3Jy ZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODg2 MAorCisgICAgICAgIEFsc28gZml4IHRoZSBzdHlsZSBvZiB0aGUgYXJndW1lbnQgbmFtZXMuCisK KyAgICAgICAgKiBzdmcvU1ZHU1ZHRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdT VkdFbGVtZW50OjpzdXNwZW5kUmVkcmF3KToKKyAgICAgICAgKFdlYkNvcmU6OlNWR1NWR0VsZW1l bnQ6OnVuc3VzcGVuZFJlZHJhdyk6CisgICAgICAgICogc3ZnL1NWR1NWR0VsZW1lbnQuaDoKKwog MjAwOS0wOC0zMSAgQnJpYW4gV2VpbnN0ZWluICA8YndlaW5zdGVpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL3N2Zy9TVkdTVkdF bGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3N2Zy9TVkdTVkdFbGVtZW50LmNwcAko cmV2aXNpb24gNDc5MTApCisrKyBXZWJDb3JlL3N2Zy9TVkdTVkdFbGVtZW50LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMzA3LDEzICszMDcsMTMgQEAgdm9pZCBTVkdTVkdFbGVtZW50OjpzdmdBdHRy aWJ1dGVDaGFuZ2VkKAogICAgICAgICByZW5kZXJlcigpLT5zZXROZWVkc0xheW91dCh0cnVlKTsK IH0KIAotdW5zaWduZWQgbG9uZyBTVkdTVkdFbGVtZW50OjpzdXNwZW5kUmVkcmF3KHVuc2lnbmVk IGxvbmcgLyogbWF4X3dhaXRfbWlsbGlzZWNvbmRzICovKQordW5zaWduZWQgU1ZHU1ZHRWxlbWVu dDo6c3VzcGVuZFJlZHJhdyh1bnNpZ25lZCAvKiBtYXhXYWl0TWlsbGlzZWNvbmRzICovKQogewog ICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQgbWUgKHNlZSBidWcgMTEyNzUpCiAgICAgcmV0dXJuIDA7 CiB9CiAKLXZvaWQgU1ZHU1ZHRWxlbWVudDo6dW5zdXNwZW5kUmVkcmF3KHVuc2lnbmVkIGxvbmcg Lyogc3VzcGVuZF9oYW5kbGVfaWQgKi8pCit2b2lkIFNWR1NWR0VsZW1lbnQ6OnVuc3VzcGVuZFJl ZHJhdyh1bnNpZ25lZCAvKiBzdXNwZW5kSGFuZGxlSWQgKi8pCiB7CiAgICAgLy8gRklYTUU6IElt cGxlbWVudCBtZSAoc2VlIGJ1ZyAxMTI3NSkKIH0KSW5kZXg6IFdlYkNvcmUvc3ZnL1NWR1NWR0Vs ZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3N2Zy9TVkdTVkdFbGVtZW50LmgJKHJldmlz aW9uIDQ3OTEwKQorKysgV2ViQ29yZS9zdmcvU1ZHU1ZHRWxlbWVudC5oCSh3b3JraW5nIGNvcHkp CkBAIC05NCw4ICs5NCw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgZmxvYXQgZ2V0 Q3VycmVudFRpbWUoKSBjb25zdDsKICAgICAgICAgdm9pZCBzZXRDdXJyZW50VGltZShmbG9hdCBz ZWNvbmRzKTsKIAotICAgICAgICB1bnNpZ25lZCBsb25nIHN1c3BlbmRSZWRyYXcodW5zaWduZWQg bG9uZyBtYXhfd2FpdF9taWxsaXNlY29uZHMpOwotICAgICAgICB2b2lkIHVuc3VzcGVuZFJlZHJh dyh1bnNpZ25lZCBsb25nIHN1c3BlbmRfaGFuZGxlX2lkKTsKKyAgICAgICAgdW5zaWduZWQgc3Vz cGVuZFJlZHJhdyh1bnNpZ25lZCBtYXhXYWl0TWlsbGlzZWNvbmRzKTsKKyAgICAgICAgdm9pZCB1 bnN1c3BlbmRSZWRyYXcodW5zaWduZWQgc3VzcGVuZEhhbmRsZUlkKTsKICAgICAgICAgdm9pZCB1 bnN1c3BlbmRSZWRyYXdBbGwoKTsKICAgICAgICAgdm9pZCBmb3JjZVJlZHJhdygpOwogCg==