28858 2009-08-31 14:50:51 -0700 Element.baseURI parses xml:base attribute incorrectly 2019-02-06 09:02:35 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ap ap cdumez oldest_to_newest 143730 0 38835 ap 2009-08-31 14:50:51 -0700 Created attachment 38835 test case Element.baseURI parses xml:base attribute as if it were an absolute URL returned by KURL::string(). Instead, an actual base URL should be used as a base for it (one for parent element or the document, I'm not sure). See the attached test case, on which Firefox behaves differently. Depending on attribute value, we can also get an assertion failure now (no crash in release mode). 143734 1 38836 ap 2009-08-31 14:57:20 -0700 Created attachment 38836 proper test case (will assert) Actually, I was wrong - in this case, the behavior is correct, as baseURI() falls back to a different code path for invalid base URLs. I cannot see any release-mode bugs possibly caused by this. 143737 2 38837 ap 2009-08-31 15:29:19 -0700 Created attachment 38837 proposed fix 143745 3 ap 2009-08-31 15:49:47 -0700 Committed revision 47910. 1502800 4 lforschler 2019-02-06 09:02:35 -0800 Mass moving XML DOM bugs to the "DOM" Component. 38835 2009-08-31 14:50:51 -0700 2009-08-31 14:57:20 -0700 test case base.xhtml application/xhtml+xml 198 ap PD94bWwgdmVyc2lvbj0iMS4wIj8+PD9URVNULVNUWUxFIFBJREFUQT8+CjxodG1sIHhtbG5zPSdo dHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sJz4KPGEgaHJlZj0iYSIgeG1sOmJhc2U9ImIiPmFz ZGE8L2E+PHNjcmlwdD5hbGVydChkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgiYSIpWzBd LmJhc2VVUkkpPC9zY3JpcHQ+CjwvaHRtbD4K 38836 2009-08-31 14:57:20 -0700 2009-08-31 14:57:20 -0700 proper test case (will assert) base.xhtml application/xhtml+xml 200 ap 77u/PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz4KPGh0bWwgeG1sbnM9J2h0 dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwnPgo8YSBocmVmPSJhIiB4bWw6YmFzZT0i0ZEiPmFu Y2hvcjwvYT48c2NyaXB0PmFsZXJ0KGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJhIilb MF0uYmFzZVVSSSk8L3NjcmlwdD4KPC9odG1sPgo= 38837 2009-08-31 15:29:19 -0700 2009-08-31 15:31:14 -0700 proposed fix XMLBase.txt text/plain 2899 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzkwOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDgtMzEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODg1OAorICAgICAgICBF bGVtZW50LmJhc2VVUkkgcGFyc2VzIHhtbDpiYXNlIGF0dHJpYnV0ZSBpbmNvcnJlY3RseQorCisg ICAgICAgIFRlc3Q6IGZhc3QvZG9tL2Jhc2UtYXR0cmlidXRlLXBhcnNpbmcueGh0bWwKKworICAg ICAgICAqIGRvbS9FbGVtZW50LmNwcDogKFdlYkNvcmU6OkVsZW1lbnQ6OmJhc2VVUkkpOiBBdm9p ZCBhc3NlcnRpb24gZmFpbHVyZSAobm8gY2hhbmdlIGluCisgICAgICAgIHJlbGVhc2UgbW9kZSku CisKIDIwMDktMDgtMzEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9kb20vRWxlbWVu dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vRWxlbWVudC5jcHAJKHJldmlzaW9uIDQ3 OTA3KQorKysgV2ViQ29yZS9kb20vRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY4Miw3 ICs2ODIsNyBAQCB2b2lkIEVsZW1lbnQ6OnNldFByZWZpeChjb25zdCBBdG9taWNTdHJpCiAKIEtV UkwgRWxlbWVudDo6YmFzZVVSSSgpIGNvbnN0CiB7Ci0gICAgS1VSTCBiYXNlKFBhcnNlZFVSTFN0 cmluZywgZ2V0QXR0cmlidXRlKGJhc2VBdHRyKSk7CisgICAgS1VSTCBiYXNlKEtVUkwoKSwgZ2V0 QXR0cmlidXRlKGJhc2VBdHRyKSk7CiAgICAgaWYgKCFiYXNlLnByb3RvY29sKCkuaXNFbXB0eSgp KQogICAgICAgICByZXR1cm4gYmFzZTsKIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNDc5MDgpCisrKyBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAw OS0wOC0zMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTI4ODU4CisgICAgICAgIEVsZW1lbnQuYmFzZVVSSSBwYXJz ZXMgeG1sOmJhc2UgYXR0cmlidXRlIGluY29ycmVjdGx5CisKKyAgICAgICAgKiBmYXN0L2RvbS9i YXNlLWF0dHJpYnV0ZS1wYXJzaW5nLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFz dC9kb20vYmFzZS1hdHRyaWJ1dGUtcGFyc2luZy54aHRtbDogQWRkZWQuCisKIDIwMDktMDgtMzEg IEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEFkbGVyLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vYmFzZS1hdHRyaWJ1dGUtcGFy c2luZy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vYmFz ZS1hdHRyaWJ1dGUtcGFyc2luZy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9iYXNlLWF0dHJpYnV0ZS1wYXJzaW5nLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSwzIEBACitUZXN0IGhvdyB4bWw6YmFzZSB2YWx1ZSBpcyBwYXJzZWQg KGJ1ZyAyODg1OCkuIFBhc3NlZCBpZiBubyBhc3NlcnRpb24gZmFpbHVyZS4KKworCkluZGV4OiBM YXlvdXRUZXN0cy9mYXN0L2RvbS9iYXNlLWF0dHJpYnV0ZS1wYXJzaW5nLnhodG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2Jhc2UtYXR0cmlidXRlLXBhcnNpbmcueGh0bWwJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9iYXNlLWF0dHJpYnV0ZS1wYXJz aW5nLnhodG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEzIEBACivvu788P3htbCB2ZXJzaW9u PSIxLjAiIGVuY29kaW5nPSJ1dGYtOCI/PgorPGh0bWwgeG1sbnM9J2h0dHA6Ly93d3cudzMub3Jn LzE5OTkveGh0bWwnPgorPGRpdiB4bWw6YmFzZT0iZGl2LyI+Cis8cCB4bWw6YmFzZT0i0ZEiPlRl c3QgaG93IHhtbDpiYXNlIHZhbHVlIGlzIHBhcnNlZCAoPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4ODU4Ij5idWcgMjg4NTg8L2E+KS4gUGFzc2VkIGlm IG5vIGFzc2VydGlvbiBmYWlsdXJlLjwvcD4KKzxwIGlkPSJyZXN1bHQiPjwvcD4KKzxzY3JpcHQ+ CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9s bGVyLmR1bXBBc1RleHQoKTsKK2Vsc2UKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVz dWx0IikuaW5uZXJIVE1MID0gIlJlc3VsdDogIiArIGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdO YW1lKCJhIilbMF0uYmFzZVVSSTsKKzwvc2NyaXB0PgorPC9kaXY+Cis8L2h0bWw+Cg==