28856 2009-08-31 14:26:04 -0700 console log message repeat count double what it should be 2009-09-01 07:41:39 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pmuellr pfeldman joepeck pfeldman timothy oldest_to_newest 143724 0 pmuellr 2009-08-31 14:26:04 -0700 Steps: 1. Traverse to a web page in a WebKit nightly 2. Open Web Inspector 3. Open the console. 4. Enter the text 'console.log("message")' and press Enter. Expected: to see the unadorned message in the console. Actual: message with a colored prefix of "2" indicating the message has been logged twice. 5. Enter the text 'console.log("message");console.log("message")' and press Enter. Expected: to see the message with a colored prefix of "2" indicating the message has been logged twice. Actual: message with a colored prefix of "4". 143757 1 joepeck 2009-08-31 16:59:46 -0700 WebInspector.addMessageToConsole gets called twice, which makes me think that this is coming from the C++ side of things, not JavaScript. Nothing jumped out at me in the last few Console.cpp changes. Also, CC'ing some people on this, you can always use: http://bugs.webkit.decenturl.com/new-web-inspector-bug 143876 2 pmuellr 2009-09-01 06:47:27 -0700 I was poking around ConsoleMessage.cpp and friends and noticed a "sameness" check for the messages in InspectorController::addConsoleMessage(), so I naively just commented out the line: m_previousMessage->incrementCount(); result is never seeing a repeat count in the console. So at this point, I'm guessing that this repeatCount calculation is required, and the one in addMessage() in ConsoleView.js needs tweaking. 143881 3 38864 pfeldman 2009-09-01 07:23:07 -0700 Created attachment 38864 fix merge (too much fuzz) 143885 4 pfeldman 2009-09-01 07:41:39 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/InjectedScript.js Committed r47933 38864 2009-09-01 07:23:07 -0700 2009-09-01 07:31:28 -0700 fix merge (too much fuzz) fuzz text/plain 1236 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTllNzE4YS4uMTdhYmI2ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wOS0wMSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCisKKyAgICAgICAgV2ViSW5zcGVjdG9yOiBjb25zb2xlIGxvZyBtZXNzYWdlIHJl cGVhdCBjb3VudCBkb3VibGUuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI4ODU2CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0luamVj dGVkU2NyaXB0LmpzOgorICAgICAgICAoSW5qZWN0ZWRTY3JpcHQuX2V2YWx1YXRlT24pOgorCiAy MDA5LTA5LTAxICBKYW4gTWljaGFlbCBBbG9uem8gIDxqbWFsb256b0B3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE1hcmsgUm93ZS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9JbmplY3RlZFNjcmlwdC5qcwppbmRleCAxYzAyOWMzLi5hZWU4NDBlIDEwMDY0NAotLS0g YS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKKysrIGIvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzCkBAIC01MDUsNyArNTA1 LDYgQEAgSW5qZWN0ZWRTY3JpcHQuX2V2YWx1YXRlT24gPSBmdW5jdGlvbihldmFsRnVuY3Rpb24s IG9iamVjdCwgZXhwcmVzc2lvbikKICAgICAgICAgdmFyIHZhbHVlID0gZXZhbEZ1bmN0aW9uLmNh bGwob2JqZWN0LCBleHByZXNzaW9uKTsKICAgICAgICAgaWYgKHZhbHVlID09PSBudWxsKQogICAg ICAgICAgICAgcmV0dXJuIHsgdmFsdWU6IG51bGwgfTsKLSAgICAgICAgdmFyIHZhbHVlID0gZXZh bEZ1bmN0aW9uLmNhbGwob2JqZWN0LCBleHByZXNzaW9uKTsKICAgICAgICAgdmFyIHdyYXBwZXIg PSBJbnNwZWN0b3JDb250cm9sbGVyLndyYXBPYmplY3QodmFsdWUpOwogICAgICAgICBpZiAodHlw ZW9mIHdyYXBwZXIgPT09ICJvYmplY3QiICYmIHdyYXBwZXIuZXhjZXB0aW9uKSB7CiAgICAgICAg ICAgICByZXN1bHQudmFsdWUgPSB3cmFwcGVyLmV4Y2VwdGlvbjsK