<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>288500</bug_id>
          
          <creation_ts>2025-02-25 10:14:14 -0800</creation_ts>
          <short_desc>Remove unused WebKit::WebExtensionSQLiteDatabase::m_lastErrorCode field</short_desc>
          <delta_ts>2025-03-06 11:18:44 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=289269</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>285893</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Kilzer (:ddkilzer)">ddkilzer</reporter>
          <assigned_to name="David Kilzer (:ddkilzer)">ddkilzer</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2097850</commentid>
    <comment_count>0</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2025-02-25 10:14:14 -0800</bug_when>
    <thetext>Remove unused WebKit::WebExtensionSQLiteDatabase::m_lastErrorCode field.

Newer versions of clang complain about the unused private field:

    Source/WebKit/Shared/Extensions/WebExtensionSQLiteDatabase.h:99:9: error: private field &apos;m_lastErrorCode&apos; is not used [-Werror,-Wunused-private-field]
           99 |     int m_lastErrorCode;
              |         ^
        1 error generated.

Regressed in:

    Create a C++ implementation of WebExtensionSQLite classes
    https://webkit.org/b/285893
    &lt;rdar://problem/142853044&gt;
    https://commits.webkit.org/289200@main</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2097853</commentid>
    <comment_count>1</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2025-02-25 10:16:16 -0800</bug_when>
    <thetext>&lt;rdar://145510149&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2097855</commentid>
    <comment_count>2</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2025-02-25 10:18:57 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/41304</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2097904</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2025-02-25 12:53:30 -0800</bug_when>
    <thetext>Committed 291045@main (ddba6dc8ce80): &lt;https://commits.webkit.org/291045@main&gt;

Reviewed commits have been landed. Closing PR #41304 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>