288478 2025-02-25 06:14:46 -0800 REGRESSION(290957@main): Build broken with USE_GTK4=OFF and ENABLE_WK_WEB_EXTENSIONS=OFF 2025-02-25 13:43:04 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 288484 P2 Normal --- 285379 1 aperez aperez oldest_to_newest 2097765 0 aperez 2025-02-25 06:14:46 -0800 If either -DUSE_GTK4=OFF or -DENABLE_WK_WEB_EXTENSIONS=OFF are passed to CMake, the build fails 2097768 1 aperez 2025-02-25 06:18:45 -0800 Even after a few (needed) local fixes, we can still get into this situation: ld.lld: error: duplicate symbol: webkit_web_extension_get_type >>> defined at WebKitWebExtension.cpp >>> Source/WebKit/CMakeFiles/WebKit.dir/WebProcess/InjectedBundle/API/glib/WebKitWebExtension.cpp.o:(webkit_web_extension_get_type) >>> defined at WebKitWebExtension.cpp >>> Source/WebKit/CMakeFiles/WebKit.dir/UIProcess/API/glib/WebKitWebExtension.cpp.o:(.text.webkit_web_extension_get_type+0x0) This means we cannot have WebExtensions support at all with !ENABLE(2022_GLIB_API)... unless we change the name of the newly added WebKitWebExtension to something else. 2097906 2 ap 2025-02-25 12:55:28 -0800 Is this just a dupe of bug 288484 at this point? 2097952 3 aperez 2025-02-25 13:43:04 -0800 (In reply to Alexey Proskuryakov from comment #2) > Is this just a dupe of bug 288484 at this point? Yes, I intended to fix the issue first but it was getting complicated and decided instead to revert the patches that had landed on main. Let's close this as well. *** This bug has been marked as a duplicate of bug 288484 ***