28834 2009-08-30 07:24:01 -0700 Compiling ScriptController failed because localStorage isn't defined. 2009-09-01 19:06:49 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC All RESOLVED FIXED P2 Critical --- 0 simon.maxime webkit-unassigned eric jorlow oldest_to_newest 143551 0 simon.maxime 2009-08-30 07:24:01 -0700 Since r47846, WebKit build fails on systems which didn't enable DOM_STORAGE. So I would suggest to add #if ENABLE(DOM_STORAGE) … #endif around the code introduced by this revision. I think I can produce a patch for this, but should I also add this preprocessing around the v8 code? 143552 1 38791 simon.maxime 2009-08-30 07:50:08 -0700 Created attachment 38791 Patch v1 143600 2 38791 eric 2009-08-31 03:05:39 -0700 Comment on attachment 38791 Patch v1 I'm entertained that you fixed it for both ScriptControllers. :) Thanks! 143605 3 38791 eric 2009-08-31 03:19:01 -0700 Comment on attachment 38791 Patch v1 Clearing flags on attachment: 38791 Committed r47887: <http://trac.webkit.org/changeset/47887> 143606 4 eric 2009-08-31 03:19:04 -0700 All reviewed patches have been landed. Closing bug. 144100 5 jorlow 2009-09-01 19:06:49 -0700 Doh! Sorry about that. :-( 38791 2009-08-30 07:50:08 -0700 2009-08-31 03:19:00 -0700 Patch v1 bug-28834-20090830165005.patch text/plain 2143 simon.maxime ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Zjk4NDRkMS4uNmMzMGIwOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOC0zMCAgTWF4aW1lIFNpbW9u ICA8c2ltb24ubWF4aW1lQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBCdWlsZCBmaXggZm9yIHBsYXRmb3JtcyB3aGljaCBkb24ndCBl bmFibGUgRE9NX1NUT1JBR0UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yODgzNAorCisgICAgICAgICogYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRDb250cm9sbGVyOjpldmFsdWF0ZSk6Cisg ICAgICAgICogYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpTY3JpcHRDb250cm9sbGVyOjpldmFsdWF0ZSk6CisKIDIwMDktMDgtMjkgIEFkZWxlIFBl dGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJu c3RlaW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIu Y3BwIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmNwcAppbmRleCA1ZTM0 MjYxLi5lYjk0ZjQ1IDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRy b2xsZXIuY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5jcHAK QEAgLTExOSwxMSArMTE5LDEzIEBAIFNjcmlwdFZhbHVlIFNjcmlwdENvbnRyb2xsZXI6OmV2YWx1 YXRlKGNvbnN0IFNjcmlwdFNvdXJjZUNvZGUmIHNvdXJjZUNvZGUpCiAgICAgLy8gc28gd2Ugc3Rh cnQgdGhlIGtlZXAgYWxpdmUgdGltZXIgaGVyZS4KICAgICBtX2ZyYW1lLT5rZWVwQWxpdmUoKTsK IAorI2lmIEVOQUJMRShET01fU1RPUkFHRSkKICAgICAvLyBSZWxlYXNlIGFueSBsb2NhbFN0b3Jh Z2UgbG9ja3Mgd2UgbWF5IHN0aWxsIGhhdmUuCiAgICAgUGFnZSogcGFnZSA9IG1fZnJhbWUtPnBh Z2UoKTsKICAgICBTdG9yYWdlTmFtZXNwYWNlKiBsb2NhbFN0b3JhZ2UgPSBwYWdlID8gcGFnZS0+ Z3JvdXAoKS5sb2NhbFN0b3JhZ2UoKSA6IDA7CiAgICAgaWYgKGxvY2FsU3RvcmFnZSkKICAgICAg ICAgbG9jYWxTdG9yYWdlLT51bmxvY2soKTsKKyNlbmRpZgogCiAgICAgaWYgKGNvbXAuY29tcGxU eXBlKCkgPT0gTm9ybWFsIHx8IGNvbXAuY29tcGxUeXBlKCkgPT0gUmV0dXJuVmFsdWUpIHsKICAg ICAgICAgbV9zb3VyY2VVUkwgPSBzYXZlZFNvdXJjZVVSTDsKZGlmZiAtLWdpdCBhL1dlYkNvcmUv YmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Nj cmlwdENvbnRyb2xsZXIuY3BwCmluZGV4IDA3MzliNzUuLjJmOThjYzQgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAKKysrIGIvV2ViQ29yZS9iaW5k aW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcApAQCAtMjIyLDExICsyMjIsMTMgQEAgU2NyaXB0 VmFsdWUgU2NyaXB0Q29udHJvbGxlcjo6ZXZhbHVhdGUoY29uc3QgU2NyaXB0U291cmNlQ29kZSYg c291cmNlQ29kZSkKICAgICAvLyBzbyB3ZSBzdGFydCB0aGUga2VlcCBhbGl2ZSB0aW1lciBoZXJl LgogICAgIG1fZnJhbWUtPmtlZXBBbGl2ZSgpOwogCisjaWYgRU5BQkxFKERPTV9TVE9SQUdFKQog ICAgIC8vIFJlbGVhc2UgYW55IGxvY2FsU3RvcmFnZSBsb2NrcyB3ZSBtYXkgc3RpbGwgaGF2ZS4K ICAgICBQYWdlKiBwYWdlID0gbV9mcmFtZS0+cGFnZSgpOwogICAgIFN0b3JhZ2VOYW1lc3BhY2Uq IGxvY2FsU3RvcmFnZSA9IHBhZ2UgPyBwYWdlLT5ncm91cCgpLmxvY2FsU3RvcmFnZSgpIDogMDsK ICAgICBpZiAobG9jYWxTdG9yYWdlKQogICAgICAgICBsb2NhbFN0b3JhZ2UtPnVubG9jaygpOwor I2VuZGlmCiAKICAgICBpZiAob2JqZWN0LklzRW1wdHkoKSB8fCBvYmplY3QtPklzVW5kZWZpbmVk KCkpCiAgICAgICAgIHJldHVybiBTY3JpcHRWYWx1ZSgpOw==