28825 2009-08-28 19:53:37 -0700 Provide a WebView preference to disable DNS prefetching 2010-07-01 12:34:18 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 opendarwin timothy ap psolanki oldest_to_newest 143496 0 opendarwin 2009-08-28 19:53:37 -0700 As far as I can tell, DNS prefetching is enabled by default in the WebKit trunk, and there is no way to disable it. I'm looking at the trunk as of git commit de240fc8d016a25d9f4b05f65195414375159b3c, corresponding to svn r47855. At WebCore/dom/Document.cpp:4370 there is the following code: m_isDNSPrefetchEnabled = securityOrigin()->protocol() == "http"; So DNS prefetch appears to be on for any http document. I've verified this in the debugger and via packet traces. There should be a WebView preference to disable DNS prefetching. This could be either part of WebPreferences or a direct accessor pair on WebView. I've listed some concerns about DNS prefetching at https://bugs.webkit.org/show_bug.cgi?id=20690#c4 and there are probably a number of other concerns that I'm not even qualified to imagine. I believe that item 2) is ok in the current implementation, but 1) and 3) still need to be addressed. It's not clear whether 4) has been handled adequately -- it appears that the DNS queue is limited to 64 requests, but I haven't tested how these requests impact the system, especially with other internet apps running simultanously, such as a syndicated feed reader. In any case, I think that people would have very legitimate reasons for wanting to disable DNS prefetching. 143512 1 mrowe 2009-08-29 11:40:50 -0700 <rdar://problem/7181249> 214052 2 opendarwin 2010-04-19 08:51:28 -0700 Is anybody working on this? DNS prefetching has now been in the trunk for 19 months: http://trac.webkit.org/changeset/36650/trunk 19 months, yet there is still no way to turn it off, short of modifying the WebKit code yourself and recompiling. I don't understand how the original patch was even accepted without a way of turning off DNS prefetching. People using the WebKit nightly builds are probably unaware that DNS prefetching is on, because nobody has publicly mentioned this feature, e.g., on the WebKit blog. It was such a stealth update that the svn commit message itself was empty. (Probably an oversight, but a pretty bad one for an important change like this.) I hope at least that rdar://problem/7181249 is blocking the release of DNS prefetching in Mac OS X. I've been checking after each release if it's there and haven't seen it yet. I can guarantee that there will be a public stink if this goes into Mac OS X without any way of disabling it. I would submit a patch myself, but I don't feel qualified. I have only a passing familiarity with C++ and with the WebKit architecture. 245475 3 60270 timothy 2010-07-01 12:22:08 -0700 Created attachment 60270 Proposed patch 245477 4 60270 darin 2010-07-01 12:24:12 -0700 Comment on attachment 60270 Proposed patch > + [NSNumber numberWithBool:YES], WebKitDNSPrefetchingEnabledPreferenceKey, Why the strange formatting here? The lines are not lined up, but there are extra spaces. 245480 5 timothy 2010-07-01 12:29:52 -0700 Fixed the spacing issue. Thanks! 245486 6 timothy 2010-07-01 12:34:18 -0700 Landed in r62284. 60270 2010-07-01 12:22:08 -0700 2010-07-01 12:24:44 -0700 Proposed patch 0001-Provide-a-WebView-preference-to-disable-DNS-prefetch.patch text/plain 11256 timothy RnJvbSA2NGI0OGVmNzMxMzBiMjg1YzIyMWI5ZTFlYzk1MjdiNTVhOTc0MWIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBUaHUsIDEgSnVsIDIwMTAgMTI6MjA6NDkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBQcm92 aWRlIGEgV2ViVmlldyBwcmVmZXJlbmNlIHRvIGRpc2FibGUgRE5TIHByZWZldGNoaW5nLgoKaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4ODI1CnJkYXI6Ly9wcm9ibGVt LzcxODEyNDkKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKV2ViQ29yZToKCiogV2ViQ29y ZS5iYXNlLmV4cDogQWRkZWQgU2V0dGluZ3M6OnNldEROU1ByZWZldGNoaW5nRW5hYmxlZC4KKiBk b20vRG9jdW1lbnQuY3BwOgooV2ViQ29yZTo6RG9jdW1lbnQ6OmluaXRETlNQcmVmZXRjaCk6IENo ZWNrIHNldHRpbmdzLT5kbnNQcmVmZXRjaGluZ0VuYWJsZWQoKS4KKiBwYWdlL1NldHRpbmdzLmNw cDoKKFdlYkNvcmU6OlNldHRpbmdzOjpTZXR0aW5ncyk6IFNldCBtX2Ruc1ByZWZldGNoaW5nRW5h YmxlZCB0byB0cnVlLgooV2ViQ29yZTo6U2V0dGluZ3M6OnNldEROU1ByZWZldGNoaW5nRW5hYmxl ZCk6IEFkZGVkLiBTZXQgbV9kbnNQcmVmZXRjaGluZ0VuYWJsZWQuCiogcGFnZS9TZXR0aW5ncy5o OgooV2ViQ29yZTo6U2V0dGluZ3M6OmRuc1ByZWZldGNoaW5nRW5hYmxlZCk6IEFkZGVkLiBSZXR1 cm4gbV9kbnNQcmVmZXRjaGluZ0VuYWJsZWQuCgpXZWJLaXQvbWFjOgoKKiBXZWJWaWV3L1dlYlBy ZWZlcmVuY2VLZXlzUHJpdmF0ZS5oOiBBZGRlZCBXZWJLaXRETlNQcmVmZXRjaGluZ0VuYWJsZWRQ cmVmZXJlbmNlS2V5LgoqIFdlYlZpZXcvV2ViUHJlZmVyZW5jZXMubW06CigrW1dlYlByZWZlcmVu Y2VzIGluaXRpYWxpemVdKTogU2V0IFdlYktpdEROU1ByZWZldGNoaW5nRW5hYmxlZFByZWZlcmVu Y2VLZXkgdG8gWUVTLgooLVtXZWJQcmVmZXJlbmNlcyBpc0ROU1ByZWZldGNoaW5nRW5hYmxlZF0p OiBBZGRlZC4gUmV0dXJuIFdlYktpdEROU1ByZWZldGNoaW5nRW5hYmxlZFByZWZlcmVuY2VLZXkn cyB2YWx1ZS4KKC1bV2ViUHJlZmVyZW5jZXMgc2V0RE5TUHJlZmV0Y2hpbmdFbmFibGVkOl0pOiBB ZGRlZC4gU2V0IFdlYktpdEROU1ByZWZldGNoaW5nRW5hYmxlZFByZWZlcmVuY2VLZXkncyB2YWx1 ZS4KKiBXZWJWaWV3L1dlYlByZWZlcmVuY2VzUHJpdmF0ZS5oOiBBZGRlZCBpc0ROU1ByZWZldGNo aW5nRW5hYmxlZCBhbmQgc2V0RE5TUHJlZmV0Y2hpbmdFbmFibGVkOi4KKiBXZWJWaWV3L1dlYlZp ZXcubW06CigtW1dlYlZpZXcgX3ByZWZlcmVuY2VzQ2hhbmdlZE5vdGlmaWNhdGlvbjpdKTogQ2Fs bCBXZWJDb3JlOjpTZXR0aW5nczo6c2V0RE5TUHJlZmV0Y2hpbmdFbmFibGVkLgotLS0KIFdlYkNv cmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTggKysrKysrKysr KysrKysrKysrCiBXZWJDb3JlL1dlYkNvcmUuYmFzZS5leHAgICAgICAgICAgICAgICAgICAgICAg fCAgICAzICsrLQogV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwICAgICAgICAgICAgICAgICAgICAg IHwgICAgNCArKystCiBXZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwICAgICAgICAgICAgICAgICAg ICAgfCAgICA2ICsrKysrKwogV2ViQ29yZS9wYWdlL1NldHRpbmdzLmggICAgICAgICAgICAgICAg ICAgICAgIHwgICAgNCArKysrCiBXZWJLaXQvbWFjL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg ICAgICAgICAgfCAgIDE4ICsrKysrKysrKysrKysrKysrKwogV2ViS2l0L21hYy9XZWJWaWV3L1dl YlByZWZlcmVuY2VLZXlzUHJpdmF0ZS5oIHwgICAgMSArCiBXZWJLaXQvbWFjL1dlYlZpZXcvV2Vi UHJlZmVyZW5jZXMubW0gICAgICAgICAgfCAgIDExICsrKysrKysrKysrCiBXZWJLaXQvbWFjL1dl YlZpZXcvV2ViUHJlZmVyZW5jZXNQcml2YXRlLmggICAgfCAgICAzICsrKwogV2ViS2l0L21hYy9X ZWJWaWV3L1dlYlZpZXcubW0gICAgICAgICAgICAgICAgIHwgICAgMSArCiAxMCBmaWxlcyBjaGFu Z2VkLCA2NyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNv cmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzA5YmI2ZC4uYzRkNTFmNiAx MDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyMSBAQAorMjAxMC0wNy0wMSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBs ZS5jb20+CisKKyAgICAgICAgUHJvdmlkZSBhIFdlYlZpZXcgcHJlZmVyZW5jZSB0byBkaXNhYmxl IEROUyBwcmVmZXRjaGluZy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mjg4MjUKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vNzE4MTI0OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZS5iYXNl LmV4cDogQWRkZWQgU2V0dGluZ3M6OnNldEROU1ByZWZldGNoaW5nRW5hYmxlZC4KKyAgICAgICAg KiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmluaXRETlNQ cmVmZXRjaCk6IENoZWNrIHNldHRpbmdzLT5kbnNQcmVmZXRjaGluZ0VuYWJsZWQoKS4KKyAgICAg ICAgKiBwYWdlL1NldHRpbmdzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNldHRpbmdzOjpTZXR0 aW5ncyk6IFNldCBtX2Ruc1ByZWZldGNoaW5nRW5hYmxlZCB0byB0cnVlLgorICAgICAgICAoV2Vi Q29yZTo6U2V0dGluZ3M6OnNldEROU1ByZWZldGNoaW5nRW5hYmxlZCk6IEFkZGVkLiBTZXQgbV9k bnNQcmVmZXRjaGluZ0VuYWJsZWQuCisgICAgICAgICogcGFnZS9TZXR0aW5ncy5oOgorICAgICAg ICAoV2ViQ29yZTo6U2V0dGluZ3M6OmRuc1ByZWZldGNoaW5nRW5hYmxlZCk6IEFkZGVkLiBSZXR1 cm4gbV9kbnNQcmVmZXRjaGluZ0VuYWJsZWQuCisKIDIwMTAtMDctMDEgIE5pa29sYXMgWmltbWVy bWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGlyayBT Y2h1bHplLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9XZWJDb3JlLmJhc2UuZXhwIGIvV2ViQ29yZS9X ZWJDb3JlLmJhc2UuZXhwCmluZGV4IGVhMzQ5YjAuLjU3ZTBmM2IgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvV2ViQ29yZS5iYXNlLmV4cAorKysgYi9XZWJDb3JlL1dlYkNvcmUuYmFzZS5leHAKQEAgLTUw NiwxMCArNTA2LDEwIEBAIF9fWk43V2ViQ29yZTRLVVJMQzFFTlNfMThQYXJzZWRVUkxTdHJpbmdU YWdFUktOU182U3RyaW5nRQogX19aTjdXZWJDb3JlNEtVUkxDMUVQNU5TVVJMCiBfX1pON1dlYkNv cmU0S1VSTEMxRVBLN19fQ0ZVUkwKIF9fWk43V2ViQ29yZTRLVVJMQzFFUktTMF9SS05TXzZTdHJp bmdFCitfX1pON1dlYkNvcmU0Tm9kZTEwcmVuZGVyUmVjdEVQYgogX19aTjdXZWJDb3JlNE5vZGUx N3N0b3BJZ25vcmluZ0xlYWtzRXYKIF9fWk43V2ViQ29yZTROb2RlMThzdGFydElnbm9yaW5nTGVh a3NFdgogX19aTjdXZWJDb3JlNE5vZGUxOXNldE5lZWRzU3R5bGVSZWNhbGNFTlNfMTVTdHlsZUNo YW5nZVR5cGVFCi1fX1pON1dlYkNvcmU0Tm9kZTEwcmVuZGVyUmVjdEVQYgogX19aTjdXZWJDb3Jl NFBhZ2UxMnNldEdyb3VwTmFtZUVSS05TXzZTdHJpbmdFCiBfX1pON1dlYkNvcmU0UGFnZTEzZGlk U3RvcFBsdWdpbkVQTlNfMTRIYWx0YWJsZVBsdWdpbkUKIF9fWk43V2ViQ29yZTRQYWdlMTRkaWRT dGFydFBsdWdpbkVQTlNfMTRIYWx0YWJsZVBsdWdpbkUKQEAgLTY2Niw2ICs2NjYsNyBAQCBfX1pO N1dlYkNvcmU4U2V0dGluZ3MyM3NldE5lZWRzVGlnZXJNYWlsUXVpcmtzRWIKIF9fWk43V2ViQ29y ZThTZXR0aW5nczIzc2V0UGx1Z2luQWxsb3dlZFJ1blRpbWVFagogX19aTjdXZWJDb3JlOFNldHRp bmdzMjNzZXRVc2VzRW5jb2RpbmdEZXRlY3RvckViCiBfX1pON1dlYkNvcmU4U2V0dGluZ3MyNHNl dEFwcGxpY2F0aW9uQ2hyb21lTW9kZUViCitfX1pON1dlYkNvcmU4U2V0dGluZ3MyNHNldEROU1By ZWZldGNoaW5nRW5hYmxlZEViCiBfX1pON1dlYkNvcmU4U2V0dGluZ3MyNHNldFRleHRBcmVhc0Fy ZVJlc2l6YWJsZUViCiBfX1pON1dlYkNvcmU4U2V0dGluZ3MyNXNldERldmVsb3BlckV4dHJhc0Vu YWJsZWRFYgogX19aTjdXZWJDb3JlOFNldHRpbmdzMjVzZXRGcmFtZUZsYXR0ZW5pbmdFbmFibGVk RWIKZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1dlYkNvcmUvZG9tL0Rv Y3VtZW50LmNwcAppbmRleCA5ZTkxNGY5Li40MjFjM2NlIDEwMDY0NAotLS0gYS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAKKysrIGIvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC00ODUxLDgg KzQ4NTEsMTAgQEAgSFRNTENhbnZhc0VsZW1lbnQqIERvY3VtZW50OjpnZXRDU1NDYW52YXNFbGVt ZW50KGNvbnN0IFN0cmluZyYgbmFtZSkKIAogdm9pZCBEb2N1bWVudDo6aW5pdEROU1ByZWZldGNo KCkKIHsKKyAgICBTZXR0aW5ncyogc2V0dGluZ3MgPSB0aGlzLT5zZXR0aW5ncygpOworCiAgICAg bV9oYXZlRXhwbGljaXRseURpc2FibGVkRE5TUHJlZmV0Y2ggPSBmYWxzZTsKLSAgICBtX2lzRE5T UHJlZmV0Y2hFbmFibGVkID0gc2VjdXJpdHlPcmlnaW4oKS0+cHJvdG9jb2woKSA9PSAiaHR0cCI7 CisgICAgbV9pc0ROU1ByZWZldGNoRW5hYmxlZCA9IHNldHRpbmdzICYmIHNldHRpbmdzLT5kbnNQ cmVmZXRjaGluZ0VuYWJsZWQoKSAmJiBzZWN1cml0eU9yaWdpbigpLT5wcm90b2NvbCgpID09ICJo dHRwIjsKIAogICAgIC8vIEluaGVyaXQgRE5TIHByZWZldGNoIG9wdC1vdXQgZnJvbSBwYXJlbnQg ZnJhbWUgICAgCiAgICAgaWYgKERvY3VtZW50KiBwYXJlbnQgPSBwYXJlbnREb2N1bWVudCgpKSB7 CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwIGIvV2ViQ29yZS9wYWdlL1Nl dHRpbmdzLmNwcAppbmRleCA0Y2RmNWY4Li5mMTAwNjg4IDEwMDY0NAotLS0gYS9XZWJDb3JlL3Bh Z2UvU2V0dGluZ3MuY3BwCisrKyBiL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5jcHAKQEAgLTEzNSw2 ICsxMzUsNyBAQCBTZXR0aW5nczo6U2V0dGluZ3MoUGFnZSogcGFnZSkKICAgICAsIG1faHRtbDVQ YXJzZXJFbmFibGVkKHRydWUpCiAgICAgLCBtX2h0bWw1VHJlZUJ1aWxkZXJFbmFibGVkKGZhbHNl KSAvLyBXaWxsIGJlIGRlbGV0ZWQgc29vbiwgZG8gbm90IHVzZS4KICAgICAsIG1fcGFnaW5hdGVE dXJpbmdMYXlvdXRFbmFibGVkKGZhbHNlKQorICAgICwgbV9kbnNQcmVmZXRjaGluZ0VuYWJsZWQo dHJ1ZSkKIHsKICAgICAvLyBBIEZyYW1lIG1heSBub3QgaGF2ZSBiZWVuIGNyZWF0ZWQgeWV0LCBz byB3ZSBpbml0aWFsaXplIHRoZSBBdG9taWNTdHJpbmcgCiAgICAgLy8gaGFzaCBiZWZvcmUgdHJ5 aW5nIHRvIHVzZSBpdC4KQEAgLTUyNSw2ICs1MjYsMTEgQEAgdm9pZCBTZXR0aW5nczo6c2V0VXNl c0VuY29kaW5nRGV0ZWN0b3IoYm9vbCB1c2VzRW5jb2RpbmdEZXRlY3RvcikKICAgICBtX3VzZXNF bmNvZGluZ0RldGVjdG9yID0gdXNlc0VuY29kaW5nRGV0ZWN0b3I7CiB9CiAKK3ZvaWQgU2V0dGlu Z3M6OnNldEROU1ByZWZldGNoaW5nRW5hYmxlZChib29sIGRuc1ByZWZldGNoaW5nRW5hYmxlZCkK K3sKKyAgICBtX2Ruc1ByZWZldGNoaW5nRW5hYmxlZCA9IGRuc1ByZWZldGNoaW5nRW5hYmxlZDsK K30KKwogdm9pZCBTZXR0aW5nczo6c2V0QWxsb3dTY3JpcHRzVG9DbG9zZVdpbmRvd3MoYm9vbCBh bGxvd1NjcmlwdHNUb0Nsb3NlV2luZG93cykKIHsKICAgICBtX2FsbG93U2NyaXB0c1RvQ2xvc2VX aW5kb3dzID0gYWxsb3dTY3JpcHRzVG9DbG9zZVdpbmRvd3M7CmRpZmYgLS1naXQgYS9XZWJDb3Jl L3BhZ2UvU2V0dGluZ3MuaCBiL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCmluZGV4IDcwMmFjMGQu LjJhYzVkMjcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCisrKyBiL1dlYkNv cmUvcGFnZS9TZXR0aW5ncy5oCkBAIC0xNTIsNiArMTUyLDkgQEAgbmFtZXNwYWNlIFdlYkNvcmUg ewogICAgICAgICB2b2lkIHNldFVzZXNFbmNvZGluZ0RldGVjdG9yKGJvb2wpOwogICAgICAgICBi b29sIHVzZXNFbmNvZGluZ0RldGVjdG9yKCkgY29uc3QgeyByZXR1cm4gbV91c2VzRW5jb2RpbmdE ZXRlY3RvcjsgfQogCisgICAgICAgIHZvaWQgc2V0RE5TUHJlZmV0Y2hpbmdFbmFibGVkKGJvb2wp OworICAgICAgICBib29sIGRuc1ByZWZldGNoaW5nRW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1f ZG5zUHJlZmV0Y2hpbmdFbmFibGVkOyB9CisKICAgICAgICAgdm9pZCBzZXRVc2VyU3R5bGVTaGVl dExvY2F0aW9uKGNvbnN0IEtVUkwmKTsKICAgICAgICAgY29uc3QgS1VSTCYgdXNlclN0eWxlU2hl ZXRMb2NhdGlvbigpIGNvbnN0IHsgcmV0dXJuIG1fdXNlclN0eWxlU2hlZXRMb2NhdGlvbjsgfQog CkBAIC0zODksNiArMzkyLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBib29sIG1f aHRtbDVQYXJzZXJFbmFibGVkOiAxOwogICAgICAgICBib29sIG1faHRtbDVUcmVlQnVpbGRlckVu YWJsZWQ6IDE7IC8vIFdpbGwgYmUgZGVsZXRlZCBzb29uLCBkbyBub3QgdXNlLgogICAgICAgICBi b29sIG1fcGFnaW5hdGVEdXJpbmdMYXlvdXRFbmFibGVkIDogMTsKKyAgICAgICAgYm9vbCBtX2Ru c1ByZWZldGNoaW5nRW5hYmxlZCA6IDE7CiAgICAgCiAjaWYgVVNFKFNBRkFSSV9USEVNRSkKICAg ICAgICAgc3RhdGljIGJvb2wgZ1Nob3VsZFBhaW50TmF0aXZlQ29udHJvbHM7CmRpZmYgLS1naXQg YS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1dlYktpdC9tYWMvQ2hhbmdlTG9nCmluZGV4IGI3NDhl ZmMuLjE0ZjhmOTMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9tYWMvQ2hhbmdlTG9nCisrKyBiL1dlYktp dC9tYWMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDctMDEgIFRpbW90aHkgSGF0 Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFByb3ZpZGUgYSBXZWJWaWV3IHBy ZWZlcmVuY2UgdG8gZGlzYWJsZSBETlMgcHJlZmV0Y2hpbmcuCisKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4ODI1CisgICAgICAgIHJkYXI6Ly9wcm9i bGVtLzcxODEyNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFdlYlZpZXcvV2ViUHJlZmVyZW5jZUtleXNQcml2YXRlLmg6IEFkZGVkIFdlYktpdERO U1ByZWZldGNoaW5nRW5hYmxlZFByZWZlcmVuY2VLZXkuCisgICAgICAgICogV2ViVmlldy9XZWJQ cmVmZXJlbmNlcy5tbToKKyAgICAgICAgKCtbV2ViUHJlZmVyZW5jZXMgaW5pdGlhbGl6ZV0pOiBT ZXQgV2ViS2l0RE5TUHJlZmV0Y2hpbmdFbmFibGVkUHJlZmVyZW5jZUtleSB0byBZRVMuCisgICAg ICAgICgtW1dlYlByZWZlcmVuY2VzIGlzRE5TUHJlZmV0Y2hpbmdFbmFibGVkXSk6IEFkZGVkLiBS ZXR1cm4gV2ViS2l0RE5TUHJlZmV0Y2hpbmdFbmFibGVkUHJlZmVyZW5jZUtleSdzIHZhbHVlLgor ICAgICAgICAoLVtXZWJQcmVmZXJlbmNlcyBzZXRETlNQcmVmZXRjaGluZ0VuYWJsZWQ6XSk6IEFk ZGVkLiBTZXQgV2ViS2l0RE5TUHJlZmV0Y2hpbmdFbmFibGVkUHJlZmVyZW5jZUtleSdzIHZhbHVl LgorICAgICAgICAqIFdlYlZpZXcvV2ViUHJlZmVyZW5jZXNQcml2YXRlLmg6IEFkZGVkIGlzRE5T UHJlZmV0Y2hpbmdFbmFibGVkIGFuZCBzZXRETlNQcmVmZXRjaGluZ0VuYWJsZWQ6LgorICAgICAg ICAqIFdlYlZpZXcvV2ViVmlldy5tbToKKyAgICAgICAgKC1bV2ViVmlldyBfcHJlZmVyZW5jZXND aGFuZ2VkTm90aWZpY2F0aW9uOl0pOiBDYWxsIFdlYkNvcmU6OlNldHRpbmdzOjpzZXRETlNQcmVm ZXRjaGluZ0VuYWJsZWQuCisKIDIwMTAtMDYtMjkgIFpvbHRhbiBIZXJjemVnICA8emhlcmN6ZWdA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOaWtvbGFzIFppbW1lcm1hbm4uCmRp ZmYgLS1naXQgYS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZUtleXNQcml2YXRlLmgg Yi9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZUtleXNQcml2YXRlLmgKaW5kZXggODY3 MjFmNy4uYTI4YmU0OSAxMDA2NDQKLS0tIGEvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVu Y2VLZXlzUHJpdmF0ZS5oCisrKyBiL1dlYktpdC9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlS2V5 c1ByaXZhdGUuaApAQCAtOTYsNiArOTYsNyBAQAogI2RlZmluZSBXZWJLaXRIVE1MNVBhcnNlckVu YWJsZWRQcmVmZXJlbmNlS2V5IEAiV2ViS2l0SFRNTDVQYXJzZXJFbmFibGVkIgogI2RlZmluZSBX ZWJLaXRIVE1MNVRyZWVCdWlsZGVyRW5hYmxlZFByZWZlcmVuY2VLZXkgQCJXZWJLaXRIVE1MNVRy ZWVCdWlsZGVyRW5hYmxlZCIgLy8gVGVtcG9yYXJ5LCBkbyBub3QgdXNlLgogI2RlZmluZSBXZWJL aXRQYWdpbmF0ZUR1cmluZ0xheW91dEVuYWJsZWRQcmVmZXJlbmNlS2V5IEAiV2ViS2l0UGFnaW5h dGVEdXJpbmdMYXlvdXRFbmFibGVkIgorI2RlZmluZSBXZWJLaXRETlNQcmVmZXRjaGluZ0VuYWJs ZWRQcmVmZXJlbmNlS2V5IEAiV2ViS2l0RE5TUHJlZmV0Y2hpbmdFbmFibGVkIgogCiAvLyBUaGVz ZSBhcmUgcHJpdmF0ZSBib3RoIGJlY2F1c2UgY2FsbGVycyBzaG91bGQgYmUgdXNpbmcgdGhlIGNv dmVyIG1ldGhvZHMgYW5kIGJlY2F1c2UgdGhlCiAvLyBjb3ZlciBtZXRob2RzIHRoZW1zZWx2ZXMg YXJlIHByaXZhdGUuCmRpZmYgLS1naXQgYS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5j ZXMubW0gYi9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZXMubW0KaW5kZXggYjViNzMy NS4uMDMyZDdhYSAxMDA2NDQKLS0tIGEvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2Vz Lm1tCisrKyBiL1dlYktpdC9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlcy5tbQpAQCAtMzYyLDYg KzM2Miw3IEBAICsgKHZvaWQpaW5pdGlhbGl6ZQogICAgICAgICBbTlNOdW1iZXIgbnVtYmVyV2l0 aEJvb2w6Tk9dLCAgIFdlYktpdEZyYW1lRmxhdHRlbmluZ0VuYWJsZWRQcmVmZXJlbmNlS2V5LAog ICAgICAgICBbTlNOdW1iZXIgbnVtYmVyV2l0aEJvb2w6WUVTXSwgICBXZWJLaXRIVE1MNVBhcnNl ckVuYWJsZWRQcmVmZXJlbmNlS2V5LAogICAgICAgICBbTlNOdW1iZXIgbnVtYmVyV2l0aEJvb2w6 Tk9dLCAgIFdlYktpdEhUTUw1VHJlZUJ1aWxkZXJFbmFibGVkUHJlZmVyZW5jZUtleSwKKyAgICAg ICAgW05TTnVtYmVyIG51bWJlcldpdGhCb29sOllFU10sICAgV2ViS2l0RE5TUHJlZmV0Y2hpbmdF bmFibGVkUHJlZmVyZW5jZUtleSwKICAgICAgICAgbmlsXTsKIAogICAgIC8vIFRoaXMgdmFsdWUg c2hvdWxkbid0IGV2ZXIgY2hhbmdlLCB3aGljaCBpcyBhc3N1bWVkIGluIHRoZSBpbml0aWFsaXph dGlvbiBvZiBXZWJLaXRQREZEaXNwbGF5TW9kZVByZWZlcmVuY2VLZXkgYWJvdmUKQEAgLTc1Niw2 ICs3NTcsMTYgQEAgQGVuZAogCiBAaW1wbGVtZW50YXRpb24gV2ViUHJlZmVyZW5jZXMgKFdlYlBy aXZhdGUpCiAKKy0gKEJPT0wpaXNETlNQcmVmZXRjaGluZ0VuYWJsZWQKK3sKKyAgICByZXR1cm4g W3NlbGYgX2Jvb2xWYWx1ZUZvcktleTpXZWJLaXRETlNQcmVmZXRjaGluZ0VuYWJsZWRQcmVmZXJl bmNlS2V5XTsKK30KKworLSAodm9pZClzZXRETlNQcmVmZXRjaGluZ0VuYWJsZWQ6KEJPT0wpZmxh ZworeworICAgIFtzZWxmIF9zZXRCb29sVmFsdWU6ZmxhZyBmb3JLZXk6V2ViS2l0RE5TUHJlZmV0 Y2hpbmdFbmFibGVkUHJlZmVyZW5jZUtleV07Cit9CisKIC0gKEJPT0wpZGV2ZWxvcGVyRXh0cmFz RW5hYmxlZAogewogICAgIE5TVXNlckRlZmF1bHRzICpkZWZhdWx0cyA9IFtOU1VzZXJEZWZhdWx0 cyBzdGFuZGFyZFVzZXJEZWZhdWx0c107CmRpZmYgLS1naXQgYS9XZWJLaXQvbWFjL1dlYlZpZXcv V2ViUHJlZmVyZW5jZXNQcml2YXRlLmggYi9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5j ZXNQcml2YXRlLmgKaW5kZXggYmIxZTI3MC4uZTk0OTQzZiAxMDA2NDQKLS0tIGEvV2ViS2l0L21h Yy9XZWJWaWV3L1dlYlByZWZlcmVuY2VzUHJpdmF0ZS5oCisrKyBiL1dlYktpdC9tYWMvV2ViVmll dy9XZWJQcmVmZXJlbmNlc1ByaXZhdGUuaApAQCAtNTUsNiArNTUsOSBAQCBleHRlcm4gTlNTdHJp bmcgKldlYlByZWZlcmVuY2VzUmVtb3ZlZE5vdGlmaWNhdGlvbjsKIAogLy8gUHJlZmVyZW5jZXMg dGhhdCBtaWdodCBiZSBwdWJsaWMgaW4gYSBmdXR1cmUgcmVsZWFzZQogCistIChCT09MKWlzRE5T UHJlZmV0Y2hpbmdFbmFibGVkOworLSAodm9pZClzZXRETlNQcmVmZXRjaGluZ0VuYWJsZWQ6KEJP T0wpZmxhZzsKKwogLSAoQk9PTClkZXZlbG9wZXJFeHRyYXNFbmFibGVkOwogLSAodm9pZClzZXRE ZXZlbG9wZXJFeHRyYXNFbmFibGVkOihCT09MKWZsYWc7CiAKZGlmZiAtLWdpdCBhL1dlYktpdC9t YWMvV2ViVmlldy9XZWJWaWV3Lm1tIGIvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KaW5k ZXggNGQzNTlhNy4uZjRkNDM0OCAxMDA2NDQKLS0tIGEvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZp ZXcubW0KKysrIGIvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KQEAgLTE0MDMsNiArMTQw Myw3IEBAIC0gKHZvaWQpX3ByZWZlcmVuY2VzQ2hhbmdlZE5vdGlmaWNhdGlvbjooTlNOb3RpZmlj YXRpb24gKilub3RpZmljYXRpb24KICAgICBzZXR0aW5ncy0+c2V0SmF2YVNjcmlwdENhbkFjY2Vz c0NsaXBib2FyZChbcHJlZmVyZW5jZXMgamF2YVNjcmlwdENhbkFjY2Vzc0NsaXBib2FyZF0pOwog ICAgIHNldHRpbmdzLT5zZXRYU1NBdWRpdG9yRW5hYmxlZChbcHJlZmVyZW5jZXMgaXNYU1NBdWRp dG9yRW5hYmxlZF0pOwogICAgIHNldHRpbmdzLT5zZXRFbmZvcmNlQ1NTTUlNRVR5cGVJblN0cmlj dE1vZGUoIVdLQXBwVmVyc2lvbkNoZWNrTGVzc1RoYW4oQCJjb20uYXBwbGUuaVdlYiIsIC0xLCAy LjEpKTsKKyAgICBzZXR0aW5ncy0+c2V0RE5TUHJlZmV0Y2hpbmdFbmFibGVkKFtwcmVmZXJlbmNl cyBpc0ROU1ByZWZldGNoaW5nRW5hYmxlZF0pOwogICAgIAogICAgIC8vIEZJWE1FOiBFbmFibGlu ZyBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyB3aGVuIFdlYkdMIGlzIGVuYWJsZWQgY2F1c2VzIHRl c3RzIHRvIGZhaWwgb24gTGVvcGFyZCB3aGljaCBleHBlY3QgSFcgY29tcG9zaXRpbmcgdG8gYmUg ZGlzYWJsZWQuCiAgICAgLy8gVW50aWwgd2UgZml4IHRoYXQsIEkgd2lsbCBjb21tZW50IG91dCB0 aGUgdGVzdCAoQ0ZNKQotLSAKMS43LjAuMgoK