28803 2009-08-28 05:58:07 -0700 [v8] Callbacks do not report exceptions that they throw. 2009-08-28 11:40:21 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 benm benm dglazkov eric oldest_to_newest 143339 0 benm 2009-08-28 05:58:07 -0700 In V8CustomVoidCallback if the callback throws an exception, that exception is not reported to WebCore. 143391 1 38741 benm 2009-08-28 09:41:34 -0700 Created attachment 38741 Proposed patch 143416 2 38741 dglazkov 2009-08-28 11:30:48 -0700 Comment on attachment 38741 Proposed patch r-me. 143421 3 38741 eric 2009-08-28 11:40:18 -0700 Comment on attachment 38741 Proposed patch Clearing flags on attachment: 38741 Committed r47871: <http://trac.webkit.org/changeset/47871> 143422 4 eric 2009-08-28 11:40:21 -0700 All reviewed patches have been landed. Closing bug. 38741 2009-08-28 09:41:34 -0700 2009-08-28 11:40:18 -0700 Proposed patch 28803.txt text/plain 1996 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Nzg2NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDgtMjggIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODgw MworICAgICAgICAKKyAgICAgICAgSW1wbGVtZW50cyBWOEN1c3RvbVZvaWRDYWxsYmFjayByZXBv cnRpbmcgYW55IGV4Y2VwdGlvbnMgdGhhdCB3ZXJlIHRocm93biBmcm9tIHRoZSBjYWxsYmFjayBm dW5jdGlvbi4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEN1c3RvbVZvaWRDYWxs YmFjay5jcHA6CisgICAgICAgIChXZWJDb3JlOjppbnZva2VDYWxsYmFjayk6IENoZWNrcyBpZiB0 aGUgY2FsbGJhY2sgcmFpc2VkIGFuIGV4Y2VwdGlvbiBhbmQgcmVwb3J0cyBpdCB0byBXZWJDb3Jl IGlmIHNvLgorCiAyMDA5LTA4LTI4ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5v cm9uaGFAY29sbGFib3JhLmNvLnVrPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEhvbGdlciBGcmV5 dGhlci4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q3VzdG9tVm9pZENhbGxi YWNrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEN1c3Rv bVZvaWRDYWxsYmFjay5jcHAJKHJldmlzaW9uIDQ3ODY2KQorKysgV2ViQ29yZS9iaW5kaW5ncy92 OC9jdXN0b20vVjhDdXN0b21Wb2lkQ2FsbGJhY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOSw2 ICsyOSw3IEBACiAgKi8KIAogI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIlY4QmluZGlu Zy5oIgogI2luY2x1ZGUgIlY4Q3VzdG9tVm9pZENhbGxiYWNrLmgiCiAKICNpbmNsdWRlICJGcmFt ZS5oIgpAQCAtNjUsNyArNjYsNiBAQCB2b2lkIFY4Q3VzdG9tVm9pZENhbGxiYWNrOjpoYW5kbGVF dmVudCgpCiAKIGJvb2wgaW52b2tlQ2FsbGJhY2sodjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4g Y2FsbGJhY2ssIGludCBhcmdjLCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gYXJndltdLCBib29sJiBj YWxsYmFja1JldHVyblZhbHVlKQogewotICAgIC8vIEZJWE1FOiBJZiBhbiBleGNlcHRpb24gd2Fz IHRocm93biBieSB0aGUgY2FsbGJhY2ssIHdlIHNob3VsZCByZXBvcnQgaXQKICAgICB2ODo6VHJ5 Q2F0Y2ggZXhjZXB0aW9uQ2F0Y2hlcjsKIAogICAgIHY4OjpMb2NhbDx2ODo6RnVuY3Rpb24+IGNh bGxiYWNrRnVuY3Rpb247CkBAIC05MSw3ICs5MSwxMyBAQCBib29sIGludm9rZUNhbGxiYWNrKHY4 OjpQZXJzaXN0ZW50PHY4OjpPCiAKICAgICBjYWxsYmFja1JldHVyblZhbHVlID0gIXJlc3VsdC5J c0VtcHR5KCkgJiYgcmVzdWx0LT5Jc0Jvb2xlYW4oKSAmJiByZXN1bHQtPkJvb2xlYW5WYWx1ZSgp OwogCi0gICAgcmV0dXJuIGV4Y2VwdGlvbkNhdGNoZXIuSGFzQ2F1Z2h0KCk7CisgICAgaWYgKGV4 Y2VwdGlvbkNhdGNoZXIuSGFzQ2F1Z2h0KCkpIHsKKyAgICAgICAgdjg6OkxvY2FsPHY4OjpNZXNz YWdlPiBtZXNzYWdlID0gZXhjZXB0aW9uQ2F0Y2hlci5NZXNzYWdlKCk7CisgICAgICAgIHByb3h5 LT5mcmFtZSgpLT5kb2N1bWVudCgpLT5yZXBvcnRFeGNlcHRpb24odG9XZWJDb3JlU3RyaW5nKG1l c3NhZ2UtPkdldCgpKSwgbWVzc2FnZS0+R2V0TGluZU51bWJlcigpLCB0b1dlYkNvcmVTdHJpbmco bWVzc2FnZS0+R2V0U2NyaXB0UmVzb3VyY2VOYW1lKCkpKTsKKyAgICAgICAgcmV0dXJuIHRydWU7 CisgICAgfQorCisgICAgcmV0dXJuIGZhbHNlOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl Cg==