28802 2009-08-28 03:18:43 -0700 Remove ASSERT(frame) in ResourceHandle::start (ResourceHandleCurl.cpp) 2009-08-31 03:45:18 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned beidson eric oldest_to_newest 143334 0 skyul 2009-08-28 03:18:43 -0700 bool ResourceHandle::start(Frame* frame) { ASSERT(frame); ResourceHandleManager::sharedInstance()->add(this); return true; } Remove ASSERT in the first line because the frame could be null if the ResourceHandle is not associated with any frame, e.g. if we are downloading a file. ResourceHandleSoup.cpp handles this case. Follow what ResourceHandleSoup.cpp does. 143336 1 38726 skyul 2009-08-28 03:25:29 -0700 Created attachment 38726 Remove ASSERT(frame) Follow what ResourceHandleSoup does. 143614 2 38726 eric 2009-08-31 03:32:37 -0700 Comment on attachment 38726 Remove ASSERT(frame) Mac has: if (!frame) return false; Win does: // If we are no longer attached to a Page, this must be an attempted load from an // onUnload handler, so let's just block it. if (!frame->page()) return false; Somebody is wrong here. I'll CC bradee. 143615 3 eric 2009-08-31 03:33:51 -0700 Brady, see comment above about discrepancy between Mac/Win. 143623 4 38726 eric 2009-08-31 03:45:15 -0700 Comment on attachment 38726 Remove ASSERT(frame) Clearing flags on attachment: 38726 Committed r47888: <http://trac.webkit.org/changeset/47888> 143624 5 eric 2009-08-31 03:45:18 -0700 All reviewed patches have been landed. Closing bug. 38726 2009-08-28 03:25:29 -0700 2009-08-31 03:45:15 -0700 Remove ASSERT(frame) remove_assert.patch text/plain 1758 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Nzg1OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDgtMjggIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZW1vdmUgQVNTRVJUKGZyYW1lKSBpbiBSZXNvdXJjZUhhbmRsZTo6c3RhcnQgKFJlc291cmNl SGFuZGxlQ3VybC5jcHApCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yODgwMgorCisgICAgICAgIFJlbW92ZSBBU1NFUlQgYmVjYXVzZSB0aGUgZnJhbWUg Y291bGQgYmUgbnVsbCBpZiB0aGUKKyAgICAgICAgUmVzb3VyY2VIYW5kbGUgaXMgbm90IGFzc29j aWF0ZWQgd2l0aCBhbnkgZnJhbWUsIGUuZy4gaWYgd2UgYXJlCisgICAgICAgIGRvd25sb2FkaW5n IGEgZmlsZS4KKyAgICAgICAgSWYgdGhlIGZyYW1lIGlzIG5vdCBudWxsIGJ1dCB0aGUgcGFnZSBp cyBudWxsIHRoaXMgbXVzdCBiZSBhbgorICAgICAgICBhdHRlbXB0ZWQgbG9hZCBmcm9tIGFuIG9u VW5sb2FkIGhhbmRsZXIsIHNvIGxldCdzIGp1c3QgYmxvY2sgaXQuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVDdXJsLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlc291cmNlSGFuZGxlOjpzdGFydCk6CisKIDIwMDktMDgtMjggIFBhdmVsIEZlbGRtYW4g IDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm90IHJldmlld2VkIChwYXRjaGlu ZyBpbiBsMThuIGNoYW5nZSB0aGF0IHdhcyBtaXNzaW5nIGR1ZSB0bwpJbmRleDogV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVDdXJsLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZUN1cmwuY3BwCShy ZXZpc2lvbiA0Nzg1OSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNl SGFuZGxlQ3VybC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMyw3ICsxMDMsMTMgQEAgUmVzb3Vy Y2VIYW5kbGU6On5SZXNvdXJjZUhhbmRsZSgpCiAKIGJvb2wgUmVzb3VyY2VIYW5kbGU6OnN0YXJ0 KEZyYW1lKiBmcmFtZSkKIHsKLSAgICBBU1NFUlQoZnJhbWUpOworICAgIC8vIFRoZSBmcmFtZSBj b3VsZCBiZSBudWxsIGlmIHRoZSBSZXNvdXJjZUhhbmRsZSBpcyBub3QgYXNzb2NpYXRlZCB0byBh bnkKKyAgICAvLyBGcmFtZSwgZS5nLiBpZiB3ZSBhcmUgZG93bmxvYWRpbmcgYSBmaWxlLgorICAg IC8vIElmIHRoZSBmcmFtZSBpcyBub3QgbnVsbCBidXQgdGhlIHBhZ2UgaXMgbnVsbCB0aGlzIG11 c3QgYmUgYW4gYXR0ZW1wdGVkCisgICAgLy8gbG9hZCBmcm9tIGFuIG9uVW5sb2FkIGhhbmRsZXIs IHNvIGxldCdzIGp1c3QgYmxvY2sgaXQuCisgICAgaWYgKGZyYW1lICYmICFmcmFtZS0+cGFnZSgp KQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICBSZXNvdXJjZUhhbmRsZU1hbmFnZXI6OnNo YXJlZEluc3RhbmNlKCktPmFkZCh0aGlzKTsKICAgICByZXR1cm4gdHJ1ZTsKIH0K