28789 2009-08-27 16:37:15 -0700 Release the storage mutex whenever leaving JavaScript execution. 2009-08-27 17:14:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jorlow jorlow oldest_to_newest 143239 0 jorlow 2009-08-27 16:37:15 -0700 http://dev.w3.org/html5/spec/Overview.html#storage-mutex describes the required behavior. After we leave JavaScript, we must be sure the storage mutex has been released. At the end of evaluate(), if localStorage has been instantiated, tell it to release any locks that may be applicable. 143241 1 38698 jorlow 2009-08-27 16:38:49 -0700 Created attachment 38698 Patch v1 143251 2 jorlow 2009-08-27 17:14:55 -0700 Committed r47846: <http://trac.webkit.org/changeset/47846> 38698 2009-08-27 16:38:49 -0700 2009-08-27 16:39:35 -0700 Patch v1 bug-28789-20090827163848.patch text/plain 2911 jorlow SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzgzOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDgtMjcgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVsZWFzZSB0aGUgc3RvcmFnZSBtdXRleCB3aGVuZXZlciBsZWF2aW5nIEphdmFTY3JpcHQgZXhl Y3V0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mjg3ODkKKworICAgICAgICBodHRwOi8vZGV2LnczLm9yZy9odG1sNS9zcGVjL092ZXJ2aWV3Lmh0 bWwjc3RvcmFnZS1tdXRleCBkZXNjcmliZXMgdGhlCisgICAgICAgIHJlcXVpcmVkIGJlaGF2aW9y LiAgQWZ0ZXIgd2UgbGVhdmUgSmF2YVNjcmlwdCwgd2UgbXVzdCBiZSBzdXJlIHRoZSBzdG9yYWdl CisgICAgICAgIG11dGV4IGhhcyBiZWVuIHJlbGVhc2VkLiAgQXQgdGhlIGVuZCBvZiBldmFsdWF0 ZSgpLCBpZiBsb2NhbFN0b3JhZ2UgaGFzIGJlZW4KKyAgICAgICAgaW5zdGFudGlhdGVkLCB0ZWxs IGl0IHRvIHJlbGVhc2UgYW55IGxvY2tzIHRoYXQgbWF5IGJlIGFwcGxpY2FibGUuCisKKyAgICAg ICAgKiBiaW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlNjcmlwdENvbnRyb2xsZXI6OmV2YWx1YXRlKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3Jp cHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6OmV2 YWx1YXRlKToKKwogMjAwOS0wOC0yNyAgUGV0ZXIgS2FzdGluZyAgPHBrYXN0aW5nQGdvb2dsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL2Jp bmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmlu ZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5jcHAJKHJldmlzaW9uIDQ3ODM4KQorKysgV2ViQ29y ZS9iaW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzMs NiArMzMsNyBAQAogI2luY2x1ZGUgIlNjcmlwdFNvdXJjZUNvZGUuaCIKICNpbmNsdWRlICJTY3Jp cHRWYWx1ZS5oIgogI2luY2x1ZGUgIlNldHRpbmdzLmgiCisjaW5jbHVkZSAiU3RvcmFnZU5hbWVz cGFjZS5oIgogI2luY2x1ZGUgIlhTU0F1ZGl0b3IuaCIKICNpbmNsdWRlICJucHJ1bnRpbWVfaW1w bC5oIgogI2luY2x1ZGUgInJ1bnRpbWVfcm9vdC5oIgpAQCAtMTE4LDYgKzExOSwxMiBAQCBTY3Jp cHRWYWx1ZSBTY3JpcHRDb250cm9sbGVyOjpldmFsdWF0ZShjCiAgICAgLy8gc28gd2Ugc3RhcnQg dGhlIGtlZXAgYWxpdmUgdGltZXIgaGVyZS4KICAgICBtX2ZyYW1lLT5rZWVwQWxpdmUoKTsKIAor ICAgIC8vIFJlbGVhc2UgYW55IGxvY2FsU3RvcmFnZSBsb2NrcyB3ZSBtYXkgc3RpbGwgaGF2ZS4K KyAgICBQYWdlKiBwYWdlID0gbV9mcmFtZS0+cGFnZSgpOworICAgIFN0b3JhZ2VOYW1lc3BhY2Uq IGxvY2FsU3RvcmFnZSA9IHBhZ2UgPyBwYWdlLT5ncm91cCgpLmxvY2FsU3RvcmFnZSgpIDogMDsK KyAgICBpZiAobG9jYWxTdG9yYWdlKQorICAgICAgICBsb2NhbFN0b3JhZ2UtPnVubG9jaygpOwor CiAgICAgaWYgKGNvbXAuY29tcGxUeXBlKCkgPT0gTm9ybWFsIHx8IGNvbXAuY29tcGxUeXBlKCkg PT0gUmV0dXJuVmFsdWUpIHsKICAgICAgICAgbV9zb3VyY2VVUkwgPSBzYXZlZFNvdXJjZVVSTDsK ICAgICAgICAgcmV0dXJuIGNvbXAudmFsdWUoKTsKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3Mvdjgv U2NyaXB0Q29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9T Y3JpcHRDb250cm9sbGVyLmNwcAkocmV2aXNpb24gNDc4MzgpCisrKyBXZWJDb3JlL2JpbmRpbmdz L3Y4L1NjcmlwdENvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NSw3ICs0NSwxMCBA QAogI2luY2x1ZGUgIm5wcnVudGltZV9pbXBsLmgiCiAjaW5jbHVkZSAibnBydW50aW1lX3ByaXYu aCIKICNpbmNsdWRlICJOUFY4T2JqZWN0LmgiCisjaW5jbHVkZSAiUGFnZS5oIgorI2luY2x1ZGUg IlBhZ2VHcm91cC5oIgogI2luY2x1ZGUgIlNjcmlwdFNvdXJjZUNvZGUuaCIKKyNpbmNsdWRlICJT dG9yYWdlTmFtZXNwYWNlLmgiCiAjaW5jbHVkZSAiV2lkZ2V0LmgiCiAjaW5jbHVkZSAiWFNTQXVk aXRvci5oIgogCkBAIC0yMTksNiArMjIyLDEyIEBAIFNjcmlwdFZhbHVlIFNjcmlwdENvbnRyb2xs ZXI6OmV2YWx1YXRlKGMKICAgICAvLyBzbyB3ZSBzdGFydCB0aGUga2VlcCBhbGl2ZSB0aW1lciBo ZXJlLgogICAgIG1fZnJhbWUtPmtlZXBBbGl2ZSgpOwogCisgICAgLy8gUmVsZWFzZSBhbnkgbG9j YWxTdG9yYWdlIGxvY2tzIHdlIG1heSBzdGlsbCBoYXZlLgorICAgIFBhZ2UqIHBhZ2UgPSBtX2Zy YW1lLT5wYWdlKCk7CisgICAgU3RvcmFnZU5hbWVzcGFjZSogbG9jYWxTdG9yYWdlID0gcGFnZSA/ IHBhZ2UtPmdyb3VwKCkubG9jYWxTdG9yYWdlKCkgOiAwOworICAgIGlmIChsb2NhbFN0b3JhZ2Up CisgICAgICAgIGxvY2FsU3RvcmFnZS0+dW5sb2NrKCk7CisKICAgICBpZiAob2JqZWN0LklzRW1w dHkoKSB8fCBvYmplY3QtPklzVW5kZWZpbmVkKCkpCiAgICAgICAgIHJldHVybiBTY3JpcHRWYWx1 ZSgpOw==