28782 2009-08-27 12:58:10 -0700 [V8] Expose files from the pasteboard in drop events. 2009-08-27 13:40:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 noel.gordon webkit-unassigned eric oldest_to_newest 143172 0 noel.gordon 2009-08-27 12:58:10 -0700 See https://bugs.webkit.org/show_bug.cgi?id=25916 143173 1 38680 noel.gordon 2009-08-27 13:06:33 -0700 Created attachment 38680 Update chromium port to expose dataTransfer.files() 143174 2 38680 dglazkov 2009-08-27 13:09:01 -0700 Comment on attachment 38680 Update chromium port to expose dataTransfer.files() > + [V8] Expose files from the pasteboard in drop events. > + https://bugs.webkit.org/show_bug.cgi?id=28782 This doesn't look at all V8-related. Is it? 143175 3 38680 eric 2009-08-27 13:13:35 -0700 Comment on attachment 38680 Update chromium port to expose dataTransfer.files() Looks good. We need a eventSender.beginDragWithFiles implementation for Chromium to be able to test this though. 143176 4 noel.gordon 2009-08-27 13:16:12 -0700 (In reply to comment #2) > This doesn't look at all V8-related. Is it? my mistake, should prefixed the bug with [Chromium] or some such. 143177 5 noel.gordon 2009-08-27 13:19:13 -0700 (In reply to comment #3) > (From update of attachment 38680 [details]) > Looks good. We need a eventSender.beginDragWithFiles implementation for > Chromium to be able to test this though. Agree, Nathan filed a chromium issue for that http://code.google.com/p/chromium/issues/detail?id=19884 143183 6 38680 eric 2009-08-27 13:40:12 -0700 Comment on attachment 38680 Update chromium port to expose dataTransfer.files() Clearing flags on attachment: 38680 Committed r47833: <http://trac.webkit.org/changeset/47833> 143184 7 eric 2009-08-27 13:40:15 -0700 All reviewed patches have been landed. Closing bug. 38680 2009-08-27 13:06:33 -0700 2009-08-27 13:40:12 -0700 Update chromium port to expose dataTransfer.files() patch.txt text/plain 1963 noel.gordon SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzgzMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDgtMjcgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21h aWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtWOF0gRXhwb3NlIGZpbGVzIGZyb20gdGhlIHBhc3RlYm9hcmQgaW4gZHJvcCBldmVudHMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODc4MgorCisg ICAgICAgIFVwZGF0ZSBjaHJvbWl1bSBwb3J0IHRvIGV4cG9zZSBkYXRhVHJhbnNmZXIuZmlsZXMo KSBhcyBwZXIKKyAgICAgICAgSFRNTDUgZHJhZyBkcm9wIChBdWcgMjAwOSBlZGl0aW9uKS4KKwor ICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL0NsaXBib2FyZENocm9taXVtLmNwcDoKKwogMjAw OS0wOC0yNyAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEbWl0cnkgR2xhemtvdi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hy b21pdW0vQ2xpcGJvYXJkQ2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vQ2xpcGJvYXJkQ2hyb21pdW0uY3BwCShyZXZpc2lvbiA0NzgzMSkKKysrIFdl YkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2xpcGJvYXJkQ2hyb21pdW0uY3BwCSh3b3JraW5nIGNv cHkpCkBAIC05Miw2ICs5Miw3IEBAIHZvaWQgQ2xpcGJvYXJkQ2hyb21pdW06OmNsZWFyRGF0YShj b25zdCAKICAgICAgICAgbV9kYXRhT2JqZWN0LT51cmwgPSBLVVJMKCk7CiAgICAgICAgIG1fZGF0 YU9iamVjdC0+dXJsVGl0bGUgPSAiIjsKICAgICB9CisKICAgICBpZiAoZGF0YVR5cGUgPT0gQ2xp cGJvYXJkRGF0YVR5cGVUZXh0KQogICAgICAgICBtX2RhdGFPYmplY3QtPnBsYWluVGV4dCA9ICIi OwogfQpAQCAtMTUwLDYgKzE1MSw3IEBAIGJvb2wgQ2xpcGJvYXJkQ2hyb21pdW06OnNldERhdGEo Y29uc3QgU3QKICAgICAgICAgbV9kYXRhT2JqZWN0LT5wbGFpblRleHQgPSBkYXRhOwogICAgICAg ICByZXR1cm4gdHJ1ZTsKICAgICB9CisgICAgCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCkBAIC0x NzgsOCArMTgwLDE3IEBAIEhhc2hTZXQ8U3RyaW5nPiBDbGlwYm9hcmRDaHJvbWl1bTo6dHlwZXMK IAogUGFzc1JlZlB0cjxGaWxlTGlzdD4gQ2xpcGJvYXJkQ2hyb21pdW06OmZpbGVzKCkgY29uc3QK IHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiAwOworICAgIGlmIChwb2xpY3ko KSAhPSBDbGlwYm9hcmRSZWFkYWJsZSkKKyAgICAgICAgcmV0dXJuIEZpbGVMaXN0OjpjcmVhdGUo KTsKKworICAgIGlmICghbV9kYXRhT2JqZWN0IHx8IG1fZGF0YU9iamVjdC0+ZmlsZW5hbWVzLmlz RW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIEZpbGVMaXN0OjpjcmVhdGUoKTsKKworICAgIFJlZlB0 cjxGaWxlTGlzdD4gZmlsZUxpc3QgPSBGaWxlTGlzdDo6Y3JlYXRlKCk7CisgICAgZm9yIChzaXpl X3QgaSA9IDA7IGkgPCBtX2RhdGFPYmplY3QtPmZpbGVuYW1lcy5zaXplKCk7ICsraSkKKyAgICAg ICAgZmlsZUxpc3QtPmFwcGVuZChGaWxlOjpjcmVhdGUobV9kYXRhT2JqZWN0LT5maWxlbmFtZXMu YXQoaSkpKTsKKworICAgIHJldHVybiBmaWxlTGlzdC5yZWxlYXNlKCk7CiB9CiAKIHZvaWQgQ2xp cGJvYXJkQ2hyb21pdW06OnNldERyYWdJbWFnZShDYWNoZWRJbWFnZSogaW1hZ2UsIE5vZGUqIG5v ZGUsIGNvbnN0IEludFBvaW50JiBsb2MpCg==