28776 2009-08-27 10:53:36 -0700 [v8] Add support for newly added lowMemoryNotification() API in V8 2009-09-01 16:35:43 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All Other RESOLVED FIXED P2 Normal --- 1 andreip benm abarth benm eric levin mrowe oldest_to_newest 143150 0 andreip 2009-08-27 10:53:36 -0700 V8 added a new API for Android's benefit. http://code.google.com/p/v8/source/detail?spec=svn2777&r=2725 We access V8 via the ScriptController class so the new V8 methods need to be proxied through this class, as well. 143151 1 38674 andreip 2009-08-27 10:56:57 -0700 Created attachment 38674 Add "LowMemoryNotification()" method on the ScriptController class. 143562 2 mrowe 2009-08-30 18:10:10 -0700 What is the point of adding ScriptController::lowMemoryNotification given that nothing calls it? 143618 3 eric 2009-08-31 03:38:24 -0700 I assume this is called by some other Andriod code? Why wouldn't that code just call the v8 API directly? 143658 4 38674 levin 2009-08-31 09:19:35 -0700 Comment on attachment 38674 Add "LowMemoryNotification()" method on the ScriptController class. Marking r- based on previous comments in bug that need an answer. Also, note that chromium has moved past that revision, so there is no need for that if PLATFORM. http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?view=markup 143846 5 andreip 2009-09-01 04:18:10 -0700 (In reply to comment #2) > What is the point of adding ScriptController::lowMemoryNotification given that > nothing calls it? Android code calls it. We haven't yet sent the patches that call that code, but we plan to do so very soon. 143847 6 andreip 2009-09-01 04:20:46 -0700 (In reply to comment #3) > I assume this is called by some other Andriod code? Why wouldn't that code > just call the v8 API directly? Android doesn't really know anything about V8, we just call methods on the script controller. I am not sure I understand why would we make an exception in this case? 143858 7 38859 andreip 2009-09-01 04:58:27 -0700 Created attachment 38859 Add "LowMemoryNotification()" method on the ScriptController class (take 2) 143914 8 38859 eric 2009-09-01 09:18:22 -0700 Comment on attachment 38859 Add "LowMemoryNotification()" method on the ScriptController class (take 2) Rejecting patch 38859 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 143926 9 benm 2009-09-01 10:05:40 -0700 I will land. 143927 10 andreip 2009-09-01 10:14:35 -0700 (In reply to comment #8) > (From update of attachment 38859 [details]) > Rejecting patch 38859 from commit-queue. This patch will require manual > commit. > > ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', > '--exit-after-n-failures=1'] failed with exit code 1 Does this mean my patch causes a layout test failure on OSX? That surely can't be since it only touches two files in bindings/v8... Anyway, Ben's looking at it. 143929 11 abarth 2009-09-01 10:19:21 -0700 > Does this mean my patch causes a layout test failure on OSX? That surely can't > be since it only touches two files in bindings/v8... The commit queue might be horked, or it could be flakiness. I doubt it's a problem with your patch. 143946 12 benm 2009-09-01 11:05:07 -0700 Landed as r47942. Sending WebCore/ChangeLog Sending WebCore/bindings/v8/ScriptController.cpp Sending WebCore/bindings/v8/ScriptController.h Transmitting file data ... Committed revision 47942. 144041 13 eric 2009-09-01 16:35:43 -0700 media/video-source-add-src.html -> timed out Your patch was yet another victim of bug 28845. :( 38674 2009-08-27 10:56:57 -0700 2009-08-31 09:19:35 -0700 Add "LowMemoryNotification()" method on the ScriptController class. 28776.patch text/plain 2243 andreip SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzgyMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDgtMjcgIEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBhICJsb3dNZW1vcnlOb3RpZmljYXRpb24iIG1ldGhvZCB0byB0aGUgVjggU2NyaXB0Q29u dHJvbGxlciBjbGFzcy4KKyAgICAgICAgVGhpcyBpcyBuZWVkZWQgaW4gb3JkZXIgdG8gYWxsb3cg dGhlIGhvc3QgYXBwbGljYXRpb24gKEFuZHJvaWQgV2ViIGJyb3dzZXIgaW4gdGhpcyBjYXNlKQor ICAgICAgICB0byBjYWxsIHRoZSB2ODo6Vjg6Okxvd01lbW9yeU5vdGlmaWNhdGlvbigpIG1ldGhv ZCBhZGRlZCB0byBWOCBpbgorICAgICAgICBodHRwOi8vY29kZS5nb29nbGUuY29tL3Avdjgvc291 cmNlL2RldGFpbD9zcGVjPXN2bjI3Nzcmcj0yNzI1CisgICAgICAgIAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg3NzYKKworCisgICAgICAgICogYmlu ZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRD b250cm9sbGVyOjpsb3dNZW1vcnlOb3RpZmljYXRpb24pOgorICAgICAgICAqIGJpbmRpbmdzL3Y4 L1NjcmlwdENvbnRyb2xsZXIuaDoKKwogMjAwOS0wOC0yNyAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxk bWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKGJ1aWxkIGZp eCkuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAJKHJldmlz aW9uIDQ3ODIzKQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjY3LDYgKzI2NywxNSBAQCB2b2lkIFNjcmlwdENvbnRyb2xsZXI6 OmNvbGxlY3RHYXJiYWdlKCkKICAgICBtX3Byb3h5LT5ldmFsdWF0ZShTY3JpcHRTb3VyY2VDb2Rl KCJpZiAod2luZG93LmdjKSB2b2lkKGdjKCkpOyIpLCAwKTsKIH0KIAordm9pZCBTY3JpcHRDb250 cm9sbGVyOjpsb3dNZW1vcnlOb3RpZmljYXRpb24oKQoreworI2lmIFBMQVRGT1JNKEFORFJPSUQp CisgICAgLy8gVGhpcyBBUEkgd2FzIGFkZGVkIGluIGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC92 OC9zb3VyY2UvZGV0YWlsP3NwZWM9c3ZuMjc3NyZyPTI3MjUKKyAgICAvLyBUT0RPOiByZW1vdmUg dGhlICNpZiBQTEFURk9STShBTkRST0lEKSBvbmNlIENocm9tZSBwaWNrcyB1cCB0aGUgYWJvdmUg Y2hhbmdlLgorICAgIHY4OjpWODo6TG93TWVtb3J5Tm90aWZpY2F0aW9uKCk7CisjZW5kaWYKK30K KwogYm9vbCBTY3JpcHRDb250cm9sbGVyOjpoYXZlSW50ZXJwcmV0ZXIoKSBjb25zdAogewogICAg IHJldHVybiBtX3Byb3h5LT5pc0NvbnRleHRJbml0aWFsaXplZCgpOwpJbmRleDogV2ViQ29yZS9i aW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5k aW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmgJKHJldmlzaW9uIDQ3ODIzKQorKysgV2ViQ29yZS9i aW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTkyLDYgKzky LDkgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgICAgIHZvaWQgY29sbGVjdEdhcmJhZ2Uo KTsKIAorICAgICAgICAvLyBOb3RpZnkgVjggdGhhdCB0aGUgc3lzdGVtIGlzIHJ1bm5pbmcgbG93 IG9uIG1lbW9yeS4KKyAgICAgICAgdm9pZCBsb3dNZW1vcnlOb3RpZmljYXRpb24oKTsKKwogICAg ICAgICAvLyBDcmVhdGVzIGEgcHJvcGVydHkgb2YgdGhlIGdsb2JhbCBvYmplY3Qgb2YgYSBmcmFt ZS4KICAgICAgICAgdm9pZCBiaW5kVG9XaW5kb3dPYmplY3QoRnJhbWUqLCBjb25zdCBTdHJpbmcm IGtleSwgTlBPYmplY3QqKTsKIAo= 38859 2009-09-01 04:58:27 -0700 2009-09-01 09:18:22 -0700 Add "LowMemoryNotification()" method on the ScriptController class (take 2) 28776.patch text/plain 2034 andreip SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzgyMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDgtMjcgIEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBhICJsb3dNZW1vcnlOb3RpZmljYXRpb24iIG1ldGhvZCB0byB0aGUgVjggU2NyaXB0Q29u dHJvbGxlciBjbGFzcy4KKyAgICAgICAgVGhpcyBpcyBuZWVkZWQgaW4gb3JkZXIgdG8gYWxsb3cg dGhlIGhvc3QgYXBwbGljYXRpb24gKEFuZHJvaWQgV2ViIGJyb3dzZXIgaW4gdGhpcyBjYXNlKQor ICAgICAgICB0byBjYWxsIHRoZSB2ODo6Vjg6Okxvd01lbW9yeU5vdGlmaWNhdGlvbigpIG1ldGhv ZCBhZGRlZCB0byBWOCBpbgorICAgICAgICBodHRwOi8vY29kZS5nb29nbGUuY29tL3Avdjgvc291 cmNlL2RldGFpbD9zcGVjPXN2bjI3Nzcmcj0yNzI1CisgICAgICAgIAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg3NzYKKworCisgICAgICAgICogYmlu ZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRD b250cm9sbGVyOjpsb3dNZW1vcnlOb3RpZmljYXRpb24pOgorICAgICAgICAqIGJpbmRpbmdzL3Y4 L1NjcmlwdENvbnRyb2xsZXIuaDoKKwogMjAwOS0wOC0yNyAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxk bWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKGJ1aWxkIGZp eCkuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAJKHJldmlz aW9uIDQ3ODIzKQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjY3LDYgKzI2NywxMSBAQCB2b2lkIFNjcmlwdENvbnRyb2xsZXI6 OmNvbGxlY3RHYXJiYWdlKCkKICAgICBtX3Byb3h5LT5ldmFsdWF0ZShTY3JpcHRTb3VyY2VDb2Rl KCJpZiAod2luZG93LmdjKSB2b2lkKGdjKCkpOyIpLCAwKTsKIH0KIAordm9pZCBTY3JpcHRDb250 cm9sbGVyOjpsb3dNZW1vcnlOb3RpZmljYXRpb24oKQoreworICAgIHY4OjpWODo6TG93TWVtb3J5 Tm90aWZpY2F0aW9uKCk7Cit9CisKIGJvb2wgU2NyaXB0Q29udHJvbGxlcjo6aGF2ZUludGVycHJl dGVyKCkgY29uc3QKIHsKICAgICByZXR1cm4gbV9wcm94eS0+aXNDb250ZXh0SW5pdGlhbGl6ZWQo KTsKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5oCShyZXZpc2lvbiA0 NzgyMykKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5oCSh3b3JraW5n IGNvcHkpCkBAIC05Miw2ICs5Miw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICB2 b2lkIGNvbGxlY3RHYXJiYWdlKCk7CiAKKyAgICAgICAgLy8gTm90aWZ5IFY4IHRoYXQgdGhlIHN5 c3RlbSBpcyBydW5uaW5nIGxvdyBvbiBtZW1vcnkuCisgICAgICAgIHZvaWQgbG93TWVtb3J5Tm90 aWZpY2F0aW9uKCk7CisKICAgICAgICAgLy8gQ3JlYXRlcyBhIHByb3BlcnR5IG9mIHRoZSBnbG9i YWwgb2JqZWN0IG9mIGEgZnJhbWUuCiAgICAgICAgIHZvaWQgYmluZFRvV2luZG93T2JqZWN0KEZy YW1lKiwgY29uc3QgU3RyaW5nJiBrZXksIE5QT2JqZWN0Kik7CiAK