28769 2009-08-27 02:38:31 -0700 The type of HTMLInputElement::list should follow the standard 2009-08-31 03:56:01 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P3 Minor --- 0 tkent webkit-unassigned eric sam oldest_to_newest 143091 0 tkent 2009-08-27 02:38:31 -0700 In bug#27756, Sam wrote: | > +#if defined(ENABLE_DATALIST) && ENABLE_DATALIST | > + // The type of the list is HTMLElement according to the standard. | > + // We intentionally use HTMLDataListElement for it because our implementation | > + // always returns an HTMLDataListElement instance. | > + readonly attribute HTMLDataListElement list; | > +#endif | | It is not clear to me why the spec has this returning an Element, but I would | rather we match it. Except for extended attributes, I would really like to | keep these IDLs as close to the specs word as possible. 143092 1 38664 tkent 2009-08-27 03:19:45 -0700 Created attachment 38664 Proposed patch 143138 2 38664 darin 2009-08-27 10:09:14 -0700 Comment on attachment 38664 Proposed patch It seems OK to change the .idl file, but do we really have to change the .h and .cpp files? Having a more-specific type can allow simpler and slightly more efficient code internally, and should do no harm. Let me put it differently. What visible change does this make. If it has no visible effect on web pages or WebKit clients, then I think we should minimize the change. 143146 3 38664 eric 2009-08-27 10:40:08 -0700 Comment on attachment 38664 Proposed patch I agree with Darin. This "bug" occurred because I asked Kent in original review comments to change the type from HTMLElement* to HTMLDataListElement* to make internal clients easier. I don't really care one way or the other re: the idl, but if we'd like to be sure to match the spec exactly, that's fine too. Basically, keep the idl change, revert the rest would be my recommendation. 143253 4 tkent 2009-08-27 17:15:33 -0700 Ok. But how to resolve the following build errors in that case? DOMHTMLInputElement.mm: In function ‘DOMHTMLElement* -[DOMHTMLInputElement list](DOMHTMLInputElement*, objc_selector*)’: DOMHTMLInputElement.mm:175: error: no matching function for call to ‘kit(WebCore::HTMLDataListElement*)’ JSHTMLInputElement.cpp: In function ‘JSC::JSValue WebCore::jsHTMLInputElementList(JSC::ExecState*, const JSC::Identifier&, const JSC::PropertySlot&)’: JSHTMLInputElement.cpp:297: error: no matching function for call to ‘toJS(JSC::ExecState*&, WebCore::JSDOMGlobalObject*, WebCore::HTMLDataListElement*)’ 143564 5 38797 tkent 2009-08-30 19:03:16 -0700 Created attachment 38797 Proposed patch (rev.2) - add HTMLInputElement::dataList() - make datalist-related methods const 143565 6 38798 tkent 2009-08-30 19:10:41 -0700 Created attachment 38798 Proposed patch (rev.3) - Update ChangeLog 143620 7 38798 eric 2009-08-31 03:40:39 -0700 Comment on attachment 38798 Proposed patch (rev.3) LGTM. 143628 8 38798 eric 2009-08-31 03:55:57 -0700 Comment on attachment 38798 Proposed patch (rev.3) Clearing flags on attachment: 38798 Committed r47889: <http://trac.webkit.org/changeset/47889> 143629 9 eric 2009-08-31 03:56:01 -0700 All reviewed patches have been landed. Closing bug. 38664 2009-08-27 03:19:45 -0700 2009-08-30 19:03:16 -0700 Proposed patch input-list-type-1.diff text/plain 3420 tkent ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjZhNzBlNi4uMGU5ZDM3NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wOC0yNyAgS2VudCBUYW11cmEg IDx0a2VudEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ2hhbmdlIHRoZSByZXV0cm4gdHlwZSBvZiBIVE1MSW5wdXRFbGVtZW50 OjpsaXN0IHNvIHRoYXQgaXQKKyAgICAgICAgY29uZm9ybXMgdG8gdGhlIHN0YW5kYXJkLgorCisg ICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhU TUxJbnB1dEVsZW1lbnQ6Omxpc3QpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVu dDo6c2VsZWN0ZWRPcHRpb24pOgorICAgICAgICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5oOgor ICAgICAgICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5pZGw6CisKIDIwMDktMDgtMjYgIER1bWl0 cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBB ZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3Bw IGIvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IDVmZmU0YmYuLmRmMzZi ZmIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAorKysgYi9X ZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKQEAgLTE3NzMsNyArMTc3Myw3IEBAIGJv b2wgSFRNTElucHV0RWxlbWVudDo6cGxhY2Vob2xkZXJTaG91bGRCZVZpc2libGUoKSBjb25zdAog fQogCiAjaWYgRU5BQkxFKERBVEFMSVNUKQotSFRNTERhdGFMaXN0RWxlbWVudCogSFRNTElucHV0 RWxlbWVudDo6bGlzdCgpCitIVE1MRWxlbWVudCogSFRNTElucHV0RWxlbWVudDo6bGlzdCgpCiB7 CiAgICAgaWYgKCFtX2hhc05vbkVtcHR5TGlzdCkKICAgICAgICAgcmV0dXJuIDA7CkBAIC0xNzg4 LDcgKzE3ODgsNyBAQCBIVE1MRGF0YUxpc3RFbGVtZW50KiBIVE1MSW5wdXRFbGVtZW50OjpsaXN0 KCkKICAgICBjYXNlIFJBTkdFOiB7CiAgICAgICAgIEVsZW1lbnQqIGVsZW1lbnQgPSBkb2N1bWVu dCgpLT5nZXRFbGVtZW50QnlJZChnZXRBdHRyaWJ1dGUobGlzdEF0dHIpKTsKICAgICAgICAgaWYg KGVsZW1lbnQgJiYgZWxlbWVudC0+aGFzVGFnTmFtZShkYXRhbGlzdFRhZykpCi0gICAgICAgICAg ICByZXR1cm4gc3RhdGljX2Nhc3Q8SFRNTERhdGFMaXN0RWxlbWVudCo+KGVsZW1lbnQpOworICAg ICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PEhUTUxFbGVtZW50Kj4oZWxlbWVudCk7CiAgICAg ICAgIGJyZWFrOwogICAgIH0KICAgICBjYXNlIEhJRERFTjoKQEAgLTE4MTQsMTAgKzE4MTQsMTAg QEAgSFRNTE9wdGlvbkVsZW1lbnQqIEhUTUxJbnB1dEVsZW1lbnQ6OnNlbGVjdGVkT3B0aW9uKCkK ICAgICBpZiAoY3VycmVudFZhbHVlLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIDA7CiAKLSAg ICBIVE1MRGF0YUxpc3RFbGVtZW50KiBzb3VyY2VFbGVtZW50ID0gbGlzdCgpOwotICAgIGlmICgh c291cmNlRWxlbWVudCkKKyAgICBIVE1MRWxlbWVudCogc291cmNlRWxlbWVudCA9IGxpc3QoKTsK KyAgICBpZiAoIXNvdXJjZUVsZW1lbnQgfHwgIXNvdXJjZUVsZW1lbnQtPmhhc1RhZ05hbWUoZGF0 YWxpc3RUYWcpKQogICAgICAgICByZXR1cm4gMDsKLSAgICBSZWZQdHI8SFRNTENvbGxlY3Rpb24+ IG9wdGlvbnMgPSBzb3VyY2VFbGVtZW50LT5vcHRpb25zKCk7CisgICAgUmVmUHRyPEhUTUxDb2xs ZWN0aW9uPiBvcHRpb25zID0gc3RhdGljX2Nhc3Q8SFRNTERhdGFMaXN0RWxlbWVudCo+KHNvdXJj ZUVsZW1lbnQpLT5vcHRpb25zKCk7CiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgb3B0aW9ucyAm JiBpIDwgb3B0aW9ucy0+bGVuZ3RoKCk7ICsraSkgewogICAgICAgICBIVE1MT3B0aW9uRWxlbWVu dCogb3B0aW9uID0gc3RhdGljX2Nhc3Q8SFRNTE9wdGlvbkVsZW1lbnQqPihvcHRpb25zLT5pdGVt KGkpKTsKICAgICAgICAgaWYgKCFvcHRpb24tPmRpc2FibGVkKCkgJiYgY3VycmVudFZhbHVlID09 IG9wdGlvbi0+dmFsdWUoKSkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVt ZW50LmggYi9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCmluZGV4IDYxNTRjZmMuLjIy MDJmZWYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKKysrIGIv V2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaApAQCAtMTk3LDcgKzE5Nyw3IEBAIHB1Ymxp YzoKICAgICB2b2lkIHNldFNyYyhjb25zdCBTdHJpbmcmKTsKIAogI2lmIEVOQUJMRShEQVRBTElT VCkKLSAgICBIVE1MRGF0YUxpc3RFbGVtZW50KiBsaXN0KCk7CisgICAgSFRNTEVsZW1lbnQqIGxp c3QoKTsKICAgICBIVE1MT3B0aW9uRWxlbWVudCogc2VsZWN0ZWRPcHRpb24oKTsKICNlbmRpZgog CmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5pZGwgYi9XZWJDb3Jl L2h0bWwvSFRNTElucHV0RWxlbWVudC5pZGwKaW5kZXggN2Y1YzAwMS4uMDdiYWI5MCAxMDA2NDQK LS0tIGEvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaWRsCisrKyBiL1dlYkNvcmUvaHRt bC9IVE1MSW5wdXRFbGVtZW50LmlkbApAQCAtNDAsMTAgKzQwLDcgQEAgbW9kdWxlIGh0bWwgewog ICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgYm9vbGVhbiAgICAgICAgIGRpc2FibGVkOwogICAg ICAgICAgICAgICAgICBhdHRyaWJ1dGUgYm9vbGVhbiAgICAgICAgIGF1dG9mb2N1czsKICNpZiBk ZWZpbmVkKEVOQUJMRV9EQVRBTElTVCkgJiYgRU5BQkxFX0RBVEFMSVNUCi0gICAgICAgICAgICAg ICAgIC8vIFRoZSB0eXBlIG9mIHRoZSBsaXN0IGlzIEhUTUxFbGVtZW50IGFjY29yZGluZyB0byB0 aGUgc3RhbmRhcmQuCi0gICAgICAgICAgICAgICAgIC8vIFdlIGludGVudGlvbmFsbHkgdXNlIEhU TUxEYXRhTGlzdEVsZW1lbnQgZm9yIGl0IGJlY2F1c2Ugb3VyIGltcGxlbWVudGF0aW9uCi0gICAg ICAgICAgICAgICAgIC8vIGFsd2F5cyByZXR1cm5zIGFuIEhUTUxEYXRhTGlzdEVsZW1lbnQgaW5z dGFuY2UuCi0gICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBIVE1MRGF0YUxpc3RFbGVtZW50IGxp c3Q7CisgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBIVE1MRWxlbWVudCAgICAgbGlzdDsKICNl bmRpZgogICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgbG9uZyAgICAgICAgICAgIG1heExlbmd0 aDsKICAgICAgICAgICAgICAgICAgYXR0cmlidXRlIGJvb2xlYW4gICAgICAgICBtdWx0aXBsZTsK 38797 2009-08-30 19:03:16 -0700 2009-08-30 19:10:41 -0700 Proposed patch (rev.2) input-list-type-2.diff text/plain 3548 tkent ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjZhNzBlNi4uMTIxNDJkNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0wOC0zMCAgS2VudCBUYW11cmEg IDx0a2VudEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgLSBDaGFuZ2UgdGhlIHJldXRybiB0eXBlIG9mIEhUTUxJbnB1dEVsZW1l bnQ6Omxpc3Qgc28gdGhhdCBpdAorICAgICAgICAgIGNvbmZvcm1zIHRvIHRoZSBzdGFuZGFyZC4K KyAgICAgICAgLSBBZGQgSFRNTElucHV0RWxlbWVudDo6ZGF0YUxpc3QoKQorCisKKyAgICAgICAg KiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0 RWxlbWVudDo6bGlzdCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50OjpkYXRh TGlzdCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50OjpzZWxlY3RlZE9wdGlv bik6CisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50Lmg6CisgICAgICAgICogaHRtbC9I VE1MSW5wdXRFbGVtZW50LmlkbDoKKwogMjAwOS0wOC0yNiAgRHVtaXRydSBEYW5pbGl1YyAgPGR1 bWlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYg LS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAgYi9XZWJDb3JlL2h0bWwv SFRNTElucHV0RWxlbWVudC5jcHAKaW5kZXggNWZmZTRiZi4uYjRkZjA5ZCAxMDA2NDQKLS0tIGEv V2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1M SW5wdXRFbGVtZW50LmNwcApAQCAtMTc3Myw3ICsxNzczLDEyIEBAIGJvb2wgSFRNTElucHV0RWxl bWVudDo6cGxhY2Vob2xkZXJTaG91bGRCZVZpc2libGUoKSBjb25zdAogfQogCiAjaWYgRU5BQkxF KERBVEFMSVNUKQotSFRNTERhdGFMaXN0RWxlbWVudCogSFRNTElucHV0RWxlbWVudDo6bGlzdCgp CitIVE1MRWxlbWVudCogSFRNTElucHV0RWxlbWVudDo6bGlzdCgpIGNvbnN0Cit7CisgICAgcmV0 dXJuIGRhdGFMaXN0KCk7Cit9CisKK0hUTUxEYXRhTGlzdEVsZW1lbnQqIEhUTUxJbnB1dEVsZW1l bnQ6OmRhdGFMaXN0KCkgY29uc3QKIHsKICAgICBpZiAoIW1faGFzTm9uRW1wdHlMaXN0KQogICAg ICAgICByZXR1cm4gMDsKQEAgLTE4MDYsNyArMTgxMSw3IEBAIEhUTUxEYXRhTGlzdEVsZW1lbnQq IEhUTUxJbnB1dEVsZW1lbnQ6Omxpc3QoKQogICAgIHJldHVybiAwOwogfQogCi1IVE1MT3B0aW9u RWxlbWVudCogSFRNTElucHV0RWxlbWVudDo6c2VsZWN0ZWRPcHRpb24oKQorSFRNTE9wdGlvbkVs ZW1lbnQqIEhUTUxJbnB1dEVsZW1lbnQ6OnNlbGVjdGVkT3B0aW9uKCkgY29uc3QKIHsKICAgICBT dHJpbmcgY3VycmVudFZhbHVlID0gdmFsdWUoKTsKICAgICAvLyBUaGUgZW1wdHkgdmFsdWUgbmV2 ZXIgbWF0Y2hlcyB0byBhIGRhdGFsaXN0IG9wdGlvbiBiZWNhdXNlIGl0CkBAIC0xODE0LDcgKzE4 MTksNyBAQCBIVE1MT3B0aW9uRWxlbWVudCogSFRNTElucHV0RWxlbWVudDo6c2VsZWN0ZWRPcHRp b24oKQogICAgIGlmIChjdXJyZW50VmFsdWUuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gMDsK IAotICAgIEhUTUxEYXRhTGlzdEVsZW1lbnQqIHNvdXJjZUVsZW1lbnQgPSBsaXN0KCk7CisgICAg SFRNTERhdGFMaXN0RWxlbWVudCogc291cmNlRWxlbWVudCA9IGRhdGFMaXN0KCk7CiAgICAgaWYg KCFzb3VyY2VFbGVtZW50KQogICAgICAgICByZXR1cm4gMDsKICAgICBSZWZQdHI8SFRNTENvbGxl Y3Rpb24+IG9wdGlvbnMgPSBzb3VyY2VFbGVtZW50LT5vcHRpb25zKCk7CmRpZmYgLS1naXQgYS9X ZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oIGIvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVs ZW1lbnQuaAppbmRleCA2MTU0Y2ZjLi41MDU0YzdmIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwv SFRNTElucHV0RWxlbWVudC5oCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgK QEAgLTE5Nyw4ICsxOTcsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRTcmMoY29uc3QgU3RyaW5n Jik7CiAKICNpZiBFTkFCTEUoREFUQUxJU1QpCi0gICAgSFRNTERhdGFMaXN0RWxlbWVudCogbGlz dCgpOwotICAgIEhUTUxPcHRpb25FbGVtZW50KiBzZWxlY3RlZE9wdGlvbigpOworICAgIEhUTUxF bGVtZW50KiBsaXN0KCkgY29uc3Q7CisgICAgSFRNTE9wdGlvbkVsZW1lbnQqIHNlbGVjdGVkT3B0 aW9uKCkgY29uc3Q7CiAjZW5kaWYKIAogICAgIGludCBtYXhMZW5ndGgoKSBjb25zdDsKQEAgLTI1 MCw2ICsyNTAsMTAgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wgaXNPcHRpb25hbEZvcm1D b250cm9sKCkgY29uc3QgeyByZXR1cm4gIWlzUmVxdWlyZWRGb3JtQ29udHJvbCgpOyB9CiAgICAg dmlydHVhbCBib29sIGlzUmVxdWlyZWRGb3JtQ29udHJvbCgpIGNvbnN0OwogCisjaWYgRU5BQkxF KERBVEFMSVNUKQorICAgIEhUTUxEYXRhTGlzdEVsZW1lbnQqIGRhdGFMaXN0KCkgY29uc3Q7Cisj ZW5kaWYKKwogICAgIElucHV0RWxlbWVudERhdGEgbV9kYXRhOwogICAgIGludCBtX3hQb3M7CiAg ICAgaW50IG1feVBvczsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50 LmlkbCBiL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmlkbAppbmRleCA3ZjVjMDAxLi4w N2JhYjkwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5pZGwKKysr IGIvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaWRsCkBAIC00MCwxMCArNDAsNyBAQCBt b2R1bGUgaHRtbCB7CiAgICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSBib29sZWFuICAgICAgICAg ZGlzYWJsZWQ7CiAgICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSBib29sZWFuICAgICAgICAgYXV0 b2ZvY3VzOwogI2lmIGRlZmluZWQoRU5BQkxFX0RBVEFMSVNUKSAmJiBFTkFCTEVfREFUQUxJU1QK LSAgICAgICAgICAgICAgICAgLy8gVGhlIHR5cGUgb2YgdGhlIGxpc3QgaXMgSFRNTEVsZW1lbnQg YWNjb3JkaW5nIHRvIHRoZSBzdGFuZGFyZC4KLSAgICAgICAgICAgICAgICAgLy8gV2UgaW50ZW50 aW9uYWxseSB1c2UgSFRNTERhdGFMaXN0RWxlbWVudCBmb3IgaXQgYmVjYXVzZSBvdXIgaW1wbGVt ZW50YXRpb24KLSAgICAgICAgICAgICAgICAgLy8gYWx3YXlzIHJldHVybnMgYW4gSFRNTERhdGFM aXN0RWxlbWVudCBpbnN0YW5jZS4KLSAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIEhUTUxEYXRh TGlzdEVsZW1lbnQgbGlzdDsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIEhUTUxFbGVtZW50 ICAgICBsaXN0OwogI2VuZGlmCiAgICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSBsb25nICAgICAg ICAgICAgbWF4TGVuZ3RoOwogICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgYm9vbGVhbiAgICAg ICAgIG11bHRpcGxlOwo= 38798 2009-08-30 19:10:41 -0700 2009-08-31 03:55:57 -0700 Proposed patch (rev.3) input-list-type-3.diff text/plain 3603 tkent ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjZhNzBlNi4uNTJmZTVjMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAwOS0wOC0zMCAgS2VudCBUYW11cmEg IDx0a2VudEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgLSBDaGFuZ2UgdGhlIHJldXRybiB0eXBlIG9mIEhUTUxJbnB1dEVsZW1l bnQ6Omxpc3Qgc28gdGhhdCBpdAorICAgICAgICAgIGNvbmZvcm1zIHRvIHRoZSBzdGFuZGFyZC4K KyAgICAgICAgLSBBZGQgSFRNTElucHV0RWxlbWVudDo6ZGF0YUxpc3QoKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg3NjkKKworCisgICAgICAgICog aHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVs ZW1lbnQ6Omxpc3QpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6ZGF0YUxp c3QpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6c2VsZWN0ZWRPcHRpb24p OgorICAgICAgICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5oOgorICAgICAgICAqIGh0bWwvSFRN TElucHV0RWxlbWVudC5pZGw6CisKIDIwMDktMDgtMjYgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1p QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwIGIvV2ViQ29yZS9odG1sL0hU TUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IDVmZmU0YmYuLmI0ZGYwOWQgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTElu cHV0RWxlbWVudC5jcHAKQEAgLTE3NzMsNyArMTc3MywxMiBAQCBib29sIEhUTUxJbnB1dEVsZW1l bnQ6OnBsYWNlaG9sZGVyU2hvdWxkQmVWaXNpYmxlKCkgY29uc3QKIH0KIAogI2lmIEVOQUJMRShE QVRBTElTVCkKLUhUTUxEYXRhTGlzdEVsZW1lbnQqIEhUTUxJbnB1dEVsZW1lbnQ6Omxpc3QoKQor SFRNTEVsZW1lbnQqIEhUTUxJbnB1dEVsZW1lbnQ6Omxpc3QoKSBjb25zdAoreworICAgIHJldHVy biBkYXRhTGlzdCgpOworfQorCitIVE1MRGF0YUxpc3RFbGVtZW50KiBIVE1MSW5wdXRFbGVtZW50 OjpkYXRhTGlzdCgpIGNvbnN0CiB7CiAgICAgaWYgKCFtX2hhc05vbkVtcHR5TGlzdCkKICAgICAg ICAgcmV0dXJuIDA7CkBAIC0xODA2LDcgKzE4MTEsNyBAQCBIVE1MRGF0YUxpc3RFbGVtZW50KiBI VE1MSW5wdXRFbGVtZW50OjpsaXN0KCkKICAgICByZXR1cm4gMDsKIH0KIAotSFRNTE9wdGlvbkVs ZW1lbnQqIEhUTUxJbnB1dEVsZW1lbnQ6OnNlbGVjdGVkT3B0aW9uKCkKK0hUTUxPcHRpb25FbGVt ZW50KiBIVE1MSW5wdXRFbGVtZW50OjpzZWxlY3RlZE9wdGlvbigpIGNvbnN0CiB7CiAgICAgU3Ry aW5nIGN1cnJlbnRWYWx1ZSA9IHZhbHVlKCk7CiAgICAgLy8gVGhlIGVtcHR5IHZhbHVlIG5ldmVy IG1hdGNoZXMgdG8gYSBkYXRhbGlzdCBvcHRpb24gYmVjYXVzZSBpdApAQCAtMTgxNCw3ICsxODE5 LDcgQEAgSFRNTE9wdGlvbkVsZW1lbnQqIEhUTUxJbnB1dEVsZW1lbnQ6OnNlbGVjdGVkT3B0aW9u KCkKICAgICBpZiAoY3VycmVudFZhbHVlLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIDA7CiAK LSAgICBIVE1MRGF0YUxpc3RFbGVtZW50KiBzb3VyY2VFbGVtZW50ID0gbGlzdCgpOworICAgIEhU TUxEYXRhTGlzdEVsZW1lbnQqIHNvdXJjZUVsZW1lbnQgPSBkYXRhTGlzdCgpOwogICAgIGlmICgh c291cmNlRWxlbWVudCkKICAgICAgICAgcmV0dXJuIDA7CiAgICAgUmVmUHRyPEhUTUxDb2xsZWN0 aW9uPiBvcHRpb25zID0gc291cmNlRWxlbWVudC0+b3B0aW9ucygpOwpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaCBiL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVt ZW50LmgKaW5kZXggNjE1NGNmYy4uNTA1NGM3ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hU TUxJbnB1dEVsZW1lbnQuaAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCkBA IC0xOTcsOCArMTk3LDggQEAgcHVibGljOgogICAgIHZvaWQgc2V0U3JjKGNvbnN0IFN0cmluZyYp OwogCiAjaWYgRU5BQkxFKERBVEFMSVNUKQotICAgIEhUTUxEYXRhTGlzdEVsZW1lbnQqIGxpc3Qo KTsKLSAgICBIVE1MT3B0aW9uRWxlbWVudCogc2VsZWN0ZWRPcHRpb24oKTsKKyAgICBIVE1MRWxl bWVudCogbGlzdCgpIGNvbnN0OworICAgIEhUTUxPcHRpb25FbGVtZW50KiBzZWxlY3RlZE9wdGlv bigpIGNvbnN0OwogI2VuZGlmCiAKICAgICBpbnQgbWF4TGVuZ3RoKCkgY29uc3Q7CkBAIC0yNTAs NiArMjUwLDEwIEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCBib29sIGlzT3B0aW9uYWxGb3JtQ29u dHJvbCgpIGNvbnN0IHsgcmV0dXJuICFpc1JlcXVpcmVkRm9ybUNvbnRyb2woKTsgfQogICAgIHZp cnR1YWwgYm9vbCBpc1JlcXVpcmVkRm9ybUNvbnRyb2woKSBjb25zdDsKIAorI2lmIEVOQUJMRShE QVRBTElTVCkKKyAgICBIVE1MRGF0YUxpc3RFbGVtZW50KiBkYXRhTGlzdCgpIGNvbnN0OworI2Vu ZGlmCisKICAgICBJbnB1dEVsZW1lbnREYXRhIG1fZGF0YTsKICAgICBpbnQgbV94UG9zOwogICAg IGludCBtX3lQb3M7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5p ZGwgYi9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5pZGwKaW5kZXggN2Y1YzAwMS4uMDdi YWI5MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaWRsCisrKyBi L1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmlkbApAQCAtNDAsMTAgKzQwLDcgQEAgbW9k dWxlIGh0bWwgewogICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgYm9vbGVhbiAgICAgICAgIGRp c2FibGVkOwogICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgYm9vbGVhbiAgICAgICAgIGF1dG9m b2N1czsKICNpZiBkZWZpbmVkKEVOQUJMRV9EQVRBTElTVCkgJiYgRU5BQkxFX0RBVEFMSVNUCi0g ICAgICAgICAgICAgICAgIC8vIFRoZSB0eXBlIG9mIHRoZSBsaXN0IGlzIEhUTUxFbGVtZW50IGFj Y29yZGluZyB0byB0aGUgc3RhbmRhcmQuCi0gICAgICAgICAgICAgICAgIC8vIFdlIGludGVudGlv bmFsbHkgdXNlIEhUTUxEYXRhTGlzdEVsZW1lbnQgZm9yIGl0IGJlY2F1c2Ugb3VyIGltcGxlbWVu dGF0aW9uCi0gICAgICAgICAgICAgICAgIC8vIGFsd2F5cyByZXR1cm5zIGFuIEhUTUxEYXRhTGlz dEVsZW1lbnQgaW5zdGFuY2UuCi0gICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBIVE1MRGF0YUxp c3RFbGVtZW50IGxpc3Q7CisgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBIVE1MRWxlbWVudCAg ICAgbGlzdDsKICNlbmRpZgogICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgbG9uZyAgICAgICAg ICAgIG1heExlbmd0aDsKICAgICAgICAgICAgICAgICAgYXR0cmlidXRlIGJvb2xlYW4gICAgICAg ICBtdWx0aXBsZTsK