28768 2009-08-27 02:01:56 -0700 No need to blacklist the QuickTime plugin 2009-08-28 06:58:43 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Mac (Intel) OS X 10.5 RESOLVED FIXED P2 Enhancement --- 0 cedric.luthi vestbo vestbo oldest_to_newest 143087 0 38663 cedric.luthi 2009-08-27 02:01:56 -0700 Created attachment 38663 Unblacklist the QuickTime plugin Now that the drawing model is properly negotiated, there is no need the blacklist the QuickTime plugin anymore. This revealed a bug in PluginView::performRequest: it should not initiate a request if the plugin has been stopped, which is what happens when a plugin only supports the QuickDraw drawing model. 143348 1 38663 vestbo 2009-08-28 06:43:03 -0700 Comment on attachment 38663 Unblacklist the QuickTime plugin > diff --git a/src/3rdparty/webkit/WebCore/plugins/PluginView.cpp b/src/3rdparty/webkit/WebCore/plugins/PluginView.cpp I'll land this one, but in the future you should make you changes on top of WebKit from SVN, not the version in Qt. Tor Arne 143357 2 vestbo 2009-08-28 06:58:43 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/plugins/PluginView.cpp M WebCore/plugins/mac/PluginPackageMac.cpp Committed r47863 M WebCore/plugins/mac/PluginPackageMac.cpp M WebCore/plugins/PluginView.cpp M WebCore/ChangeLog r47863 = 37020cd0ecb8a7a8cfd591732fecb403f8a8e69b (svn/trunk) 38663 2009-08-27 02:01:56 -0700 2009-08-28 06:43:03 -0700 Unblacklist the QuickTime plugin QuickTime-unblacklist.patch text/plain 1280 cedric.luthi ZGlmZiAtLWdpdCBhL3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZp ZXcuY3BwIGIvc3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5j cHAKaW5kZXggMmNlY2RjNC4uZmVhY2I2NiAxMDA2NDQKLS0tIGEvc3JjLzNyZHBhcnR5L3dlYmtp dC9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAKKysrIGIvc3JjLzNyZHBhcnR5L3dlYmtp dC9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAKQEAgLTIyMSw2ICsyMjEsOSBAQCBzdGF0 aWMgYm9vbCBnZXRTdHJpbmcoU2NyaXB0Q29udHJvbGxlciogcHJveHksIEpTVmFsdWUgcmVzdWx0 LCBTdHJpbmcmIHN0cmluZykKIAogdm9pZCBQbHVnaW5WaWV3OjpwZXJmb3JtUmVxdWVzdChQbHVn aW5SZXF1ZXN0KiByZXF1ZXN0KQogeworICAgIGlmICghbV9pc1N0YXJ0ZWQpCisgICAgICAgIHJl dHVybjsKKwogICAgIC8vIGRvbid0IGxldCBhIHBsdWdpbiBzdGFydCBhbnkgbG9hZHMgaWYgaXQg aXMgbm8gbG9uZ2VyIHBhcnQgb2YgYSBkb2N1bWVudCB0aGF0IGlzIGJlaW5nIAogICAgIC8vIGRp c3BsYXllZCB1bmxlc3MgdGhlIGxvYWRzIGFyZSBpbiB0aGUgc2FtZSBmcmFtZSBhcyB0aGUgcGx1 Z2luLgogICAgIGNvbnN0IFN0cmluZyYgdGFyZ2V0RnJhbWVOYW1lID0gcmVxdWVzdC0+ZnJhbWVM b2FkUmVxdWVzdCgpLmZyYW1lTmFtZSgpOwpkaWZmIC0tZ2l0IGEvc3JjLzNyZHBhcnR5L3dlYmtp dC9XZWJDb3JlL3BsdWdpbnMvbWFjL1BsdWdpblBhY2thZ2VNYWMuY3BwIGIvc3JjLzNyZHBhcnR5 L3dlYmtpdC9XZWJDb3JlL3BsdWdpbnMvbWFjL1BsdWdpblBhY2thZ2VNYWMuY3BwCmluZGV4IGJm NmE4MWIuLmZmOTA4NTMgMTAwNjQ0Ci0tLSBhL3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZS9w bHVnaW5zL21hYy9QbHVnaW5QYWNrYWdlTWFjLmNwcAorKysgYi9zcmMvM3JkcGFydHkvd2Via2l0 L1dlYkNvcmUvcGx1Z2lucy9tYWMvUGx1Z2luUGFja2FnZU1hYy5jcHAKQEAgLTI0Niw3ICsyNDYs NyBAQCBib29sIFBsdWdpblBhY2thZ2U6OmZldGNoSW5mbygpCiAKIGJvb2wgUGx1Z2luUGFja2Fn ZTo6aXNQbHVnaW5CbGFja2xpc3RlZCgpCiB7Ci0gICAgaWYgKG5hbWUoKSA9PSAiU2lsdmVybGln aHQgUGx1Zy1JbiIgfHwgbmFtZSgpLnN0YXJ0c1dpdGgoIlF1aWNrVGltZSBQbHVnLWluIikpCisg ICAgaWYgKG5hbWUoKSA9PSAiU2lsdmVybGlnaHQgUGx1Zy1JbiIpCiAgICAgICAgIHJldHVybiB0 cnVlOwogCiAgICAgcmV0dXJuIGZhbHNlOwo=