287632 2025-02-13 08:30:42 -0800 [WPE] Default to run layout tests with WEBKIT_SKIA_ENABLE_CPU_RENDERING=1 2025-02-14 04:59:11 -0800 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=287572 P2 Normal --- 1 clopez clopez bugs-noreply oldest_to_newest 2094460 0 clopez 2025-02-13 08:30:42 -0800 We were observing some crashes in WPE when running with skia-cpu that were unfortunately not being catched by WebKit's CI, as bots were running with skia-gpu only We changed that recently by setting WEBKIT_SKIA_ENABLE_CPU_RENDERING=1 on the bots environment but that lead to a situation where the bots run with a different configuration than the developers, which is far from ideal as it makes reproducing results from the bots harder. So the idea is to set WEBKIT_SKIA_ENABLE_CPU_RENDERING=1 for the layout tests directly from the python tooling to run those tests, so both developers and bots have the same environment. This would be only done for WPE and not for GTK and that is consistent with what we recommend these days (i.e. CPU for embedded and GPU for desktop). So this way the WPE layout tests will run with skia-cpu and would allow us to catch issues and crashes with that configuration (which is recommended on embedded) faster. See bug 287572 for a list of tests that only crash/fail with skia-cpu 2094464 1 clopez 2025-02-13 08:40:38 -0800 Pull request: https://github.com/WebKit/WebKit/pull/40557 2094751 2 ews-feeder 2025-02-14 04:59:08 -0800 Committed 290397@main (69bc9c556085): <https://commits.webkit.org/290397@main> Reviewed commits have been landed. Closing PR #40557 and removing active labels.