287629 2025-02-13 05:38:48 -0800 [GTK][WPE] <lang-attribute-affects-rendering.html> fails 2025-03-06 05:01:17 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=270564 https://bugs.webkit.org/show_bug.cgi?id=79756 https://github.com/web-platform-tests/wpt/pull/51158 InRadar P2 Normal --- 1 deleted_user webkit-unassigned webkit-bug-importer oldest_to_newest 2094443 0 deleted_user 2025-02-13 05:38:48 -0800 https://github.com/web-platform-tests/wpt/blob/1a5b13545a/css/css-fonts/lang-attribute-affects-rendering.html It only fails for GTK: https://wpt.fyi/results/css?label=master&product=chrome%5Bexperimental%5D&product=edge%5Bexperimental%5D&product=firefox%5Bexperimental%5D&product=safari%5Bexperimental%5D&product=webkitgtk&aligned&q=%2Fcss%2Fcss-fonts%2Flang-attribute-affects-rendering.html. 2094447 1 deleted_user 2025-02-13 06:01:03 -0800 Some analysis, read the test-case for context: - https://searchfox.org/wubkat/rev/eb60a003e2487c2a8f34aaf8ce8f5d5af280ed55/Source/WebCore/platform/graphics/ComplexTextController.cpp#358 is called for "fi". - `m_font.fontDescription().computedLocale()` is "en" ("tr" for the -ref.html file). That's expected. - `FontCascade::fontForCombiningCharacterSequence` (https://searchfox.org/wubkat/rev/eb60a003e2487c2a8f34aaf8ce8f5d5af280ed55/Source/WebCore/platform/graphics/FontCascade.h#208) corresponds to different implementations: https://searchfox.org/wubkat/search?q=fontForCombiningCharacterSequence&redirect=false - Since the test passes for Safari, perhaps the implementation for Skia, which is used by GTK, is buggy: https://searchfox.org/wubkat/rev/eb60a003e2487c2a8f34aaf8ce8f5d5af280ed55/Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp#132 2095120 2 deleted_user 2025-02-17 01:46:48 -0800 Continued analysis: https://searchfox.org/wubkat/rev/dd523ddb28deecac34400360788b2ba9cee771af/Source/WebCore/platform/graphics/ComplexTextController.cpp#462 is called. Safari and GTK use different implementations of that method. The test passes with Safari. Presumably, because of <https://searchfox.org/wubkat/rev/dd523ddb28deecac34400360788b2ba9cee771af/Source/WebCore/platform/graphics/coretext/ComplexTextControllerCoreText.mm#200>. The bug/missing functionality for GTK is presumably in the GTK-specific implementation: <https://searchfox.org/wubkat/rev/dd523ddb28deecac34400360788b2ba9cee771af/Source/WebCore/platform/graphics/skia/ComplexTextControllerSkia.cpp#153>. 2095127 3 deleted_user 2025-02-17 02:41:18 -0800 `hb_language_t` (https://harfbuzz.github.io/harfbuzz-hb-common.html#hb-language-t) might need to be set. 2095454 4 deleted_user 2025-02-18 07:39:28 -0800 Pull request: https://github.com/WebKit/WebKit/pull/40761 2100933 5 ews-feeder 2025-03-06 05:00:32 -0800 Committed 291691@main (c30953f1f00c): <https://commits.webkit.org/291691@main> Reviewed commits have been landed. Closing PR #40761 and removing active labels. 2100934 6 webkit-bug-importer 2025-03-06 05:01:17 -0800 <rdar://problem/146381919>