287554 2025-02-12 02:33:55 -0800 Make `Vector::operator==` work correctly with padded structs 2025-03-06 12:53:20 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts cdumez simon.fraser webkit-bug-importer oldest_to_newest 2094108 0 graouts 2025-02-12 02:33:55 -0800 In 289948@main a workaround was implemented to let two `Vector<StyleRuleKeyframe::Key>` be compared with the `==` operator: ``` // FIXME: using Vector::operator==() here fails on Intel, so we provide our own logic. auto keysAreEqual = [](const Vector<StyleRuleKeyframe::Key>& a, const Vector<StyleRuleKeyframe::Key>& b) { if (a.size() != b.size()) return false; for (auto i = a.size(); i--;) { if (!(a[i] == b[i])) return false; } return true; }; ``` Indeed, on Intel, simply using the existing `Vector::operator==` would yield failures in `LayoutTests/animations/keyframes-rule.html`. Apparently this is due to the fact that `memcmp()` is used in this case and that it doesn't work correctly with padded structs like `StyleRuleKeyframe::Key`. 2094148 1 webkit-bug-importer 2025-02-12 08:30:37 -0800 <rdar://problem/144700872> 2099532 2 cdumez 2025-02-28 19:14:11 -0800 Pull request: https://github.com/WebKit/WebKit/pull/41696 2101107 3 ews-feeder 2025-03-06 12:53:17 -0800 Committed 291724@main (30eb04f14b59): <https://commits.webkit.org/291724@main> Reviewed commits have been landed. Closing PR #41696 and removing active labels.