28739 2009-08-26 07:45:13 -0700 [V8] setTimeout does not convert non-string argument to string 2009-08-26 12:55:26 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 ager webkit-unassigned dglazkov eric oldest_to_newest 142852 0 ager 2009-08-26 07:45:13 -0700 LayoutTests/fast/dom/Window/setTimeout-string-argument.html fails with V8 because we do not convert a non-string argument to a string. Patch on its way. 142853 1 38613 ager 2009-08-26 07:53:05 -0700 Created attachment 38613 Convert setTimeout argument to string if non-string 142854 2 38613 dglazkov 2009-08-26 08:03:10 -0700 Comment on attachment 38613 Convert setTimeout argument to string if non-string r=me. 142897 3 38613 eric 2009-08-26 11:11:20 -0700 Comment on attachment 38613 Convert setTimeout argument to string if non-string Rejecting patch 38613 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 142918 4 38613 eric 2009-08-26 12:32:03 -0700 Comment on attachment 38613 Convert setTimeout argument to string if non-string accessibility/nochildren-elements.html -> crashed Seems unrelated. 142926 5 38613 eric 2009-08-26 12:55:22 -0700 Comment on attachment 38613 Convert setTimeout argument to string if non-string Clearing flags on attachment: 38613 Committed r47786: <http://trac.webkit.org/changeset/47786> 142927 6 eric 2009-08-26 12:55:26 -0700 All reviewed patches have been landed. Closing bug. 38613 2009-08-26 07:53:05 -0700 2009-08-26 12:55:22 -0700 Convert setTimeout argument to string if non-string setTimeout.txt text/plain 2710 ager SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Nzc3OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDgtMjYgIE1hZHMgQWdlciAgPGFnZXJAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtWOF0g c2V0VGltZW91dCBkb2VzIG5vdCBjb252ZXJ0IG5vbi1zdHJpbmcgYXJndW1lbnQgdG8gc3RyaW5n CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODczOQor CisgICAgICAgIENvbnZlcnQgbm9uLXN0cmluZyBhcmd1bWVudCB0byBzZXRUaW1lb3V0IHRvIHN0 cmluZyBpbiB0aGUgVjgKKyAgICAgICAgYmluZGluZ3MuCisKKyAgICAgICAgKiBiaW5kaW5ncy92 OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhDdXN0 b206OldpbmRvd1NldFRpbWVvdXRJbXBsKToKKwogMjAwOS0wOC0yNiAgVmluY2VudCBVbnR6IDx2 dW50ekBnbm9tZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpJbmRleDog V2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNwcAko cmV2aXNpb24gNDc3NDIpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOERPTVdpbmRv d0N1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc3LDE5ICs3NywxMSBAQCB2ODo6SGFuZGxl PHY4OjpWYWx1ZT4gVjhDdXN0b206OldpbmRvd1NlCiAgICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+ IGZ1bmN0aW9uID0gYXJnc1swXTsKIAogICAgIGludDMyX3QgdGltZW91dCA9IDA7Ci0gICAgaWYg KGFyZ3VtZW50Q291bnQgPj0gMikgCisgICAgaWYgKGFyZ3VtZW50Q291bnQgPj0gMikKICAgICAg ICAgdGltZW91dCA9IGFyZ3NbMV0tPkludDMyVmFsdWUoKTsKIAogICAgIGludCBpZDsKLSAgICBp ZiAoZnVuY3Rpb24tPklzU3RyaW5nKCkpIHsKLSAgICAgICAgLy8gRG9uJ3QgYWxsb3cgc2V0dGlu ZyB0aW1lb3V0cyB0byBydW4gZW1wdHkgZnVuY3Rpb25zIQotICAgICAgICAvLyAoQnVnIDEwMDk1 OTcpCi0gICAgICAgIFdlYkNvcmU6OlN0cmluZyBmdW5jdGlvblN0cmluZyA9IHRvV2ViQ29yZVN0 cmluZyhmdW5jdGlvbik7Ci0gICAgICAgIGlmIChmdW5jdGlvblN0cmluZy5sZW5ndGgoKSA9PSAw KQotICAgICAgICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKLQotICAgICAgICBpZCA9IERP TVRpbWVyOjppbnN0YWxsKHNjcmlwdENvbnRleHQsIG5ldyBTY2hlZHVsZWRBY3Rpb24oZnVuY3Rp b25TdHJpbmcpLCB0aW1lb3V0LCBzaW5nbGVTaG90KTsKLSAgICB9IGVsc2UgaWYgKGZ1bmN0aW9u LT5Jc0Z1bmN0aW9uKCkpIHsKKyAgICBpZiAoZnVuY3Rpb24tPklzRnVuY3Rpb24oKSkgewogICAg ICAgICBpbnQgcGFyYW1Db3VudCA9IGFyZ3VtZW50Q291bnQgPj0gMiA/IGFyZ3VtZW50Q291bnQg LSAyIDogMDsKICAgICAgICAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4qIHBhcmFtcyA9IDA7CiAgICAg ICAgIGlmIChwYXJhbUNvdW50ID4gMCkgewpAQCAtMTA1LDkgKzk3LDIzIEBAIHY4OjpIYW5kbGU8 djg6OlZhbHVlPiBWOEN1c3RvbTo6V2luZG93U2UKICAgICAgICAgZGVsZXRlW10gcGFyYW1zOwog CiAgICAgICAgIGlkID0gRE9NVGltZXI6Omluc3RhbGwoc2NyaXB0Q29udGV4dCwgYWN0aW9uLCB0 aW1lb3V0LCBzaW5nbGVTaG90KTsKLSAgICB9IGVsc2UKLSAgICAgICAgLy8gRklYTUUoZnFpYW4p OiB3aGF0J3MgdGhlIHJpZ2h0IHJldHVybiB2YWx1ZSBpZiBmYWlsZWQuCi0gICAgICAgIHJldHVy biB2ODo6VW5kZWZpbmVkKCk7CisgICAgfSBlbHNlIHsKKyAgICAgICAgaWYgKCFmdW5jdGlvbi0+ SXNTdHJpbmcoKSkgeworICAgICAgICAgICAgZnVuY3Rpb24gPSBmdW5jdGlvbi0+VG9TdHJpbmco KTsKKyAgICAgICAgICAgIC8vIEJhaWwgb3V0IGlmIHN0cmluZyBjb252ZXJzaW9uIGZhaWxlZC4K KyAgICAgICAgICAgIGlmIChmdW5jdGlvbi5Jc0VtcHR5KCkpCisgICAgICAgICAgICAgICAgcmV0 dXJuIHY4OjpVbmRlZmluZWQoKTsKKyAgICAgICAgfQorCisgICAgICAgIFdlYkNvcmU6OlN0cmlu ZyBmdW5jdGlvblN0cmluZyA9IHRvV2ViQ29yZVN0cmluZyhmdW5jdGlvbik7CisKKyAgICAgICAg Ly8gRG9uJ3QgYWxsb3cgc2V0dGluZyB0aW1lb3V0cyB0byBydW4gZW1wdHkgZnVuY3Rpb25zIQor ICAgICAgICAvLyAoQnVnIDEwMDk1OTcpCisgICAgICAgIGlmIChmdW5jdGlvblN0cmluZy5sZW5n dGgoKSA9PSAwKQorICAgICAgICAgICAgcmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKKworICAgICAg ICBpZCA9IERPTVRpbWVyOjppbnN0YWxsKHNjcmlwdENvbnRleHQsIG5ldyBTY2hlZHVsZWRBY3Rp b24oZnVuY3Rpb25TdHJpbmcpLCB0aW1lb3V0LCBzaW5nbGVTaG90KTsKKyAgICB9CiAKICAgICBy ZXR1cm4gdjg6OkludGVnZXI6Ok5ldyhpZCk7CiB9Cg==