28731 2009-08-25 21:34:05 -0700 Setting the volume of a media element has no effect if called too early 2009-08-25 22:14:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson simon.fraser oldest_to_newest 142777 0 eric.carlson 2009-08-25 21:34:05 -0700 On OSX, setting the volume of an audio element before it has loaded metadata has no effect because MediaPlayerPrivate::setVolume() bails if metaDataAvailable() is false. This is unnecessary, it is safe to set the movie volume as soon as the movie exists. 142778 1 eric.carlson 2009-08-25 21:34:48 -0700 rdar://7170177 142782 2 38596 eric.carlson 2009-08-25 21:56:33 -0700 Created attachment 38596 proposed patch 142784 3 eric.carlson 2009-08-25 22:14:09 -0700 http://trac.webkit.org/changeset/47771 38596 2009-08-25 21:56:33 -0700 2009-08-25 21:57:39 -0700 proposed patch patch.txt text/plain 2868 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0Nzc3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDgtMjUgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgU2V0dGluZyB0aGUgdm9sdW1lIG9mIGEgbWVkaWEgZWxlbWVudCBoYXMgbm8gZWZmZWN0IGlm IGNhbGxlZCB0b28gZWFybHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI4NzMxCisKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvYXVkaW8tdm9sdW1lLmh0 bWw6IAorICAgICAgICAgICAgQWRkZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9t YWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQubW06CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBs YXllclByaXZhdGU6OnNldFZvbHVtZSk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclBy aXZhdGU6OnNldFJhdGUpOgorICAgICAgICAgICAgRG9uJ3QgYmFpbCBpZiBtZXRhZGF0YSBoYXNu J3QgYmVlbiBsb2FkZWQsIGl0IGlzIGZpbmUgdG8gc2V0IHJhdGUgYW5kL29yCisgICAgICAgICAg ICB2b2x1bWUgYXMgc29vbiBhcyB0aGUgbW92aWUgaGFzIGJlZW4gY3JlYXRlZC4KKwogMjAwOS0w OC0yNSAgRGF2aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCkluZGV4OiBXZWJDb3JlL21hbnVhbC10ZXN0cy9hdWRp by12b2x1bWUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL21hbnVhbC10ZXN0cy9hdWRpby12 b2x1bWUuaHRtbAkocmV2aXNpb24gMCkKKysrIFdlYkNvcmUvbWFudWFsLXRlc3RzL2F1ZGlvLXZv bHVtZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI4IEBACis8aHRtbD4KKyAgICA8c2Ny aXB0PgorICAgICAgICBmdW5jdGlvbiBsb2FkKCkKKyAgICAgICAgeworICAgICAgICAgICAgdmFy IHVybD0iaHR0cDovL21vdmllcy5hcHBsZS5jb20vbW92aWVzL3VzL2FwcGxlL2lwb2RpdHVuZXMv MjAwNy90b3VjaC9hZHMvYXBwbGVfaXBvZHRvdWNoX3RvdWNoX3I2NDAtOWNpZS5tb3YiOworICAg ICAgICAgICAgdmFyIHZpZCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd2aWQnKQorICAgICAg ICAgICAgdmlkLnNyYyA9IHVybDsKKyAgICAgICAgICAgIHZpZC52b2x1bWUgPSAwLjA1OworICAg ICAgICAgICAgdmlkLmxvYWQoKTsKKyAgICAgICAgfQorICAgICAgICBmdW5jdGlvbiBzZXRWb2x1 bWUodm9sKQorICAgICAgICB7CisgICAgICAgICAgICB2YXIgdmlkID0gZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ3ZpZCcpCisgICAgICAgICAgICB2aWQudm9sdW1lID0gdm9sOworICAgICAgICB9 CisgICAgPC9zY3JpcHQ+CisgICAgICAgICAgICAKKyAgICA8Ym9keT4KKworICAgICAgICA8dmlk ZW8gaWQ9dmlkIGNvbnRyb2xzIGF1dG9wbGF5PgorICAgICAgICA8L3ZpZGVvPgorICAgICAgICA8 cD5URVNUOiBBdWRpbyB2b2x1bWUgc2hvdWxkIGJlIDAuMDUgd2hlbiB0aGUgbW92aWUgYmVnaW5z IHBsYXlpbmcuPC9wPgorICAgICAgICA8aW5wdXQgdHlwZT0iYnV0dG9uIiB2YWx1ZT0iTG9hZCBt b3ZpZSIgb25jbGljaz0ibG9hZCgpIj4KKyAgICAgICAgPGJyPgorICAgICAgICA8aW5wdXQgdHlw ZT0iYnV0dG9uIiB2YWx1ZT0idm9sdW1lPTEuMCIgb25jbGljaz0ic2V0Vm9sdW1lKDEuMCkiPgor ICAgICAgICA8aW5wdXQgdHlwZT0iYnV0dG9uIiB2YWx1ZT0idm9sdW1lPTAuMDUiIG9uY2xpY2s9 InNldFZvbHVtZSgwLjA1KSI+CisgICAgPC9ib2R5PgorPC9odG1sPwpJbmRleDogV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQubW0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRL aXQubW0JKHJldmlzaW9uIDQ3NzU3KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMv TWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQubW0JKHdvcmtpbmcgY29weSkKQEAgLTczMCwxNiArNzMw LDE0IEBAIGJvb2wgTWVkaWFQbGF5ZXJQcml2YXRlOjpoYXNBdWRpbygpIGNvbnMKIAogdm9pZCBN ZWRpYVBsYXllclByaXZhdGU6OnNldFZvbHVtZShmbG9hdCB2b2x1bWUpCiB7Ci0gICAgaWYgKCFt ZXRhRGF0YUF2YWlsYWJsZSgpKQotICAgICAgICByZXR1cm47Ci0gICAgW21fcXRNb3ZpZS5nZXQo KSBzZXRWb2x1bWU6dm9sdW1lXTsgIAorICAgIGlmIChtX3F0TW92aWUpCisgICAgICAgIFttX3F0 TW92aWUuZ2V0KCkgc2V0Vm9sdW1lOnZvbHVtZV07ICAKIH0KIAogdm9pZCBNZWRpYVBsYXllclBy aXZhdGU6OnNldFJhdGUoZmxvYXQgcmF0ZSkKIHsKLSAgICBpZiAoIW1ldGFEYXRhQXZhaWxhYmxl KCkpCi0gICAgICAgIHJldHVybjsKLSAgICBbbV9xdE1vdmllLmdldCgpIHNldFJhdGU6cmF0ZV07 CisgICAgaWYgKG1fcXRNb3ZpZSkKKyAgICAgICAgW21fcXRNb3ZpZS5nZXQoKSBzZXRSYXRlOnJh dGVdOwogfQogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6c2V0UHJlc2VydmVzUGl0Y2goYm9v bCBwcmVzZXJ2ZXNQaXRjaCkK