28730 2009-08-25 20:49:18 -0700 RenderThemeMac.mm has incorrect casting for media control element 2009-08-26 07:06:25 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 0 hclam webkit-unassigned eric oldest_to_newest 142772 0 hclam 2009-08-25 20:49:18 -0700 There is an incorrect casting of MediaControlMuteButtonElement to MediaControlPlayButtonElement in RenderThemeMac::paintMediaMuteButton(). 142775 1 38593 hclam 2009-08-25 20:54:38 -0700 Created attachment 38593 patch + change log This bug does not cause any problem but is apparently incorrect. 142848 2 38593 eric 2009-08-26 07:06:21 -0700 Comment on attachment 38593 patch + change log Clearing flags on attachment: 38593 Committed r47778: <http://trac.webkit.org/changeset/47778> 142849 3 eric 2009-08-26 07:06:25 -0700 All reviewed patches have been landed. Closing bug. 38593 2009-08-25 20:54:38 -0700 2009-08-26 07:06:21 -0700 patch + change log webkit-casting-fix.patch text/plain 1650 hclam ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTA3YzlkMy4uYjhiODgxNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0wOC0yNSAgQWxwaGEgTGFtICA8 aGNsYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJlbmRlclRoZW1lTWFjLm1tIGhhcyBpbmNvcnJlY3QgY2FzdGluZyBmb3Ig bWVkaWEgY29udHJvbCBlbGVtZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Mjg3MzAKKworICAgICAgICBNZWRpYUNvbnRyb2xNdXRlQnV0dG9uRWxl bWVudCB3YXMgaW5jb3JyZWN0bHkgY2FzdGVkIHRvCisgICAgICAgIE1lZGlhQ29udHJvbFBsYXlC dXR0b25FbGVtZW50LiBUaGlzIGlzIGNvcnJlY3RlZCBpbiB0aGlzIHBhdGNoLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoaXMgaXMgY29kZSBjbGVhbnVwIGFuZCBpcyBhbHJlYWR5 IGNvdmVyZWQgYnkgZXhpc3RpbmcKKyAgICAgICAgbWVkaWEgbGF5b3V0IHRlc3RzLgorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyVGhlbWVNYWM6OnBhaW50TWVkaWFNdXRlQnV0dG9uKToKKwogMjAwOS0wOC0yNCAgQWxleGV5 IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRl cnMgQ2FybHNzb24uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1h Yy5tbSBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCmluZGV4IDZkOTI1NTYu LjM2NTI5MmUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1t CisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tCkBAIC0xNTQ1LDcgKzE1 NDUsNyBAQCBib29sIFJlbmRlclRoZW1lTWFjOjpwYWludE1lZGlhTXV0ZUJ1dHRvbihSZW5kZXJP YmplY3QqIG8sIGNvbnN0IFJlbmRlck9iamVjdDo6UAogICAgIGlmICghbWVkaWFOb2RlIHx8ICgh bWVkaWFOb2RlLT5oYXNUYWdOYW1lKHZpZGVvVGFnKSAmJiAhbWVkaWFOb2RlLT5oYXNUYWdOYW1l KGF1ZGlvVGFnKSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIGlmIChNZWRpYUNvbnRy b2xQbGF5QnV0dG9uRWxlbWVudCogYnRuID0gc3RhdGljX2Nhc3Q8TWVkaWFDb250cm9sUGxheUJ1 dHRvbkVsZW1lbnQqPihub2RlKSkgeworICAgIGlmIChNZWRpYUNvbnRyb2xNdXRlQnV0dG9uRWxl bWVudCogYnRuID0gc3RhdGljX2Nhc3Q8TWVkaWFDb250cm9sTXV0ZUJ1dHRvbkVsZW1lbnQqPihu b2RlKSkgewogICAgICAgICBMb2NhbEN1cnJlbnRHcmFwaGljc0NvbnRleHQgbG9jYWxDb250ZXh0 KHBhaW50SW5mby5jb250ZXh0KTsKICAgICAgICAgd2tEcmF3TWVkaWFVSVBhcnQoYnRuLT5kaXNw bGF5VHlwZSgpLCBtZWRpYUNvbnRyb2xsZXJUaGVtZSgpLCBwYWludEluZm8uY29udGV4dC0+cGxh dGZvcm1Db250ZXh0KCksIHIsIGdldE1lZGlhVUlQYXJ0U3RhdGVGbGFncyhub2RlKSk7CiAK