28728 2009-08-25 19:21:24 -0700 DocumentThreadableLoader::getShouldUseCredentialStorage should allow for synchronous callbacks from SubresourceLoader::create. 2009-08-25 20:03:09 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 levin levin ap oldest_to_newest 142759 0 levin 2009-08-25 19:21:24 -0700 On Chromium, it is useful to make this callback synchronously. These are some small changes to stop asserts from happening in this case. 142761 1 38587 levin 2009-08-25 19:27:49 -0700 Created attachment 38587 Proposed fix. 142764 2 38587 mjs 2009-08-25 19:51:07 -0700 Comment on attachment 38587 Proposed fix. r=me 142765 3 levin 2009-08-25 20:03:09 -0700 Committed as http://trac.webkit.org/changeset/47770 38587 2009-08-25 19:27:49 -0700 2009-08-25 19:51:07 -0700 Proposed fix. bug28728.txt text/plain 2305 levin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzQ3YThiOC4uZDM2Y2IzMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wOC0yNSAgRGF2aWQgTGV2aW4g IDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyOjpnZXRTaG91bGRVc2VDcmVk ZW50aWFsU3RvcmFnZSBzaG91bGQgYWxsb3cgZm9yIHN5bmNocm9ub3VzIGNhbGxiYWNrcyBmcm9t IFN1YnJlc291cmNlTG9hZGVyOjpjcmVhdGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yODcyOAorCisgICAgICAgICogbG9hZGVyL0RvY3VtZW50VGhy ZWFkYWJsZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudFRocmVhZGFibGVM b2FkZXI6OmdldFNob3VsZFVzZUNyZWRlbnRpYWxTdG9yYWdlKTogV2hlbiBjYWxsZWQKKyAgICAg ICAgYmFjayBzeW5jaHJvbm91c2x5LCB0aGUgbG9hZGVyIGlzIDAsIHNvIHRoZSBhc3NlcnQgaXMg Y2hhbmdlZCB0byBhbGxvdyBmb3IgdGhhdC4KKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50VGhy ZWFkYWJsZUxvYWRlcjo6bG9hZFJlcXVlc3QpOiBTeW5jaHJvbm91cyBjYWxsYmFja3MgbWF5IGJl CisgICAgICAgIGRvbmUgYmVmb3JlIFN1YnJlc291cmNlTG9hZGVyOjpjcmVhdGUgZmluaXNoZXMs IHNvIGVuc3VyZSB0aGF0IGFueSBwcmV2aW91cyBsb2FkZXIKKyAgICAgICAgLS0gZnJvbSBhIHBy ZWZsaWdodCByZXF1ZXN0IC0tIGlzIGNsZWFyZWQgYmVmb3JlIGNhbGxpbmcgU3VicmVzb3VyY2VM b2FkZXI6OmNyZWF0ZS4KKwogMjAwOS0wOC0yNSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50VGhyZWFkYWJsZUxvYWRlci5jcHAgYi9XZWJDb3JlL2xv YWRlci9Eb2N1bWVudFRocmVhZGFibGVMb2FkZXIuY3BwCmluZGV4IDU3ZGFhMDcuLjkwZjg5NDEg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50VGhyZWFkYWJsZUxvYWRlci5jcHAK KysrIGIvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyLmNwcApAQCAtMjUx LDcgKzI1MSw3IEBAIHZvaWQgRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyOjpkaWRGYWlsKFN1YnJl c291cmNlTG9hZGVyKiBsb2FkZXIsIGNvbnN0IFJlc291cmNlCiAKIGJvb2wgRG9jdW1lbnRUaHJl YWRhYmxlTG9hZGVyOjpnZXRTaG91bGRVc2VDcmVkZW50aWFsU3RvcmFnZShTdWJyZXNvdXJjZUxv YWRlciogbG9hZGVyLCBib29sJiBzaG91bGRVc2VDcmVkZW50aWFsU3RvcmFnZSkKIHsKLSAgICBB U1NFUlRfVU5VU0VEKGxvYWRlciwgbG9hZGVyID09IG1fbG9hZGVyKTsKKyAgICBBU1NFUlRfVU5V U0VEKGxvYWRlciwgbG9hZGVyID09IG1fbG9hZGVyIHx8ICFtX2xvYWRlcik7CiAKICAgICBpZiAo IW1fb3B0aW9ucy5hbGxvd0NyZWRlbnRpYWxzKSB7CiAgICAgICAgIHNob3VsZFVzZUNyZWRlbnRp YWxTdG9yYWdlID0gZmFsc2U7CkBAIC0yOTksNiArMjk5LDkgQEAgdm9pZCBEb2N1bWVudFRocmVh ZGFibGVMb2FkZXI6OmxvYWRSZXF1ZXN0KGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwg Ym9vbAogICAgICAgICAvLyBEb24ndCBzbmlmZiBjb250ZW50IG9yIHNlbmQgbG9hZCBjYWxsYmFj a3MgZm9yIHRoZSBwcmVmbGlnaHQgcmVxdWVzdC4KICAgICAgICAgYm9vbCBzZW5kTG9hZENhbGxi YWNrcyA9IG1fb3B0aW9ucy5zZW5kTG9hZENhbGxiYWNrcyAmJiAhbV9hY3R1YWxSZXF1ZXN0Owog ICAgICAgICBib29sIHNuaWZmQ29udGVudCA9IG1fb3B0aW9ucy5zbmlmZkNvbnRlbnQgJiYgIW1f YWN0dWFsUmVxdWVzdDsKKworICAgICAgICAvLyBDbGVhciB0aGUgbG9hZGVyIHNvIHRoYXQgYW55 IGNhbGxiYWNrcyBmcm9tIFN1YnJlc291cmNlTG9hZGVyOjpjcmVhdGUgd2lsbCBub3QgaGF2ZSB0 aGUgb2xkIGxvYWRlci4KKyAgICAgICAgbV9sb2FkZXIgPSAwOwogICAgICAgICBtX2xvYWRlciA9 IFN1YnJlc291cmNlTG9hZGVyOjpjcmVhdGUobV9kb2N1bWVudC0+ZnJhbWUoKSwgdGhpcywgcmVx dWVzdCwgc2tpcENhbkxvYWRDaGVjaywgc2VuZExvYWRDYWxsYmFja3MsIHNuaWZmQ29udGVudCk7 CiAgICAgICAgIHJldHVybjsKICAgICB9Cg==