287265 2025-02-07 10:31:48 -0800 [HDR] Separate "is showing HDR" from screenContentsFormat() 2025-02-19 17:51:01 -0800 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 282299 1 sabouhallawa sabouhallawa sabouhallawa webkit-bug-importer oldest_to_newest 2092874 0 sabouhallawa 2025-02-07 10:31:48 -0800 This function is a little confusing. It returns the best screen ContentsFormat for a given optional layer. I think the right design for this is 1. screenContentsFormat() should renamed screenContentsFormats() and it should return OptionSet<ContentsFormat>. The screen is capable of supporting multiple ContentsFormat. The layer should picks whatever suits it. 2. A new static function is added called PlatformCALayer::contentsFormatForLayer(). It will return the best screen ContentsFormat for a given optional layer. This function will call screenContentsFormats() and it will checks whether the PlatformCALayerClient wants to show HDR or not. If it does and the screen support RGBA16F, it will return RGBA16F. 2092875 1 webkit-bug-importer 2025-02-07 10:32:06 -0800 <rdar://problem/144396500> 2092881 2 sabouhallawa 2025-02-07 10:38:26 -0800 Pull request: https://github.com/WebKit/WebKit/pull/40225 2093082 3 ews-feeder 2025-02-07 19:04:53 -0800 Committed 290069@main (01e5e2df42c3): <https://commits.webkit.org/290069@main> Reviewed commits have been landed. Closing PR #40225 and removing active labels.