28720 2009-08-25 15:22:55 -0700 [V8] Fix Canvas layout test failures in Chromium build. 2009-08-25 15:39:41 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jianli jianli dglazkov levin oldest_to_newest 142708 0 jianli 2009-08-25 15:22:55 -0700 Fix Canvas layout test failures in Chromium build. The previous fix r47757 does not handle the V8 object conversion correctly. 142710 1 38571 jianli 2009-08-25 15:26:49 -0700 Created attachment 38571 Proposed Patch 142711 2 38571 levin 2009-08-25 15:32:06 -0700 Comment on attachment 38571 Proposed Patch > diff --git a/WebCore/bindings/v8/custom/V8DocumentCustom.cpp b/WebCore/bindings/v8/custom/V8DocumentCustom.cpp > + ASSERT(false); Use ASSERT_NOT_REACHED(); > } // namespace WebCore > diff --git a/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp b/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp > + ASSERT(false); Use ASSERT_NOT_REACHED(); 142713 3 jianli 2009-08-25 15:39:41 -0700 Committed as http://trac.webkit.org/changeset/47758 38571 2009-08-25 15:26:49 -0700 2009-08-25 15:32:06 -0700 Proposed Patch 28720 text/plain 3048 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjQ1ZGQxZi4uYzZlNzJiZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAwOS0wOC0yNSAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW1Y4XSBGaXggQ2FudmFzIGxheW91dCB0ZXN0IGZhaWx1cmVzIGluIENocm9t aXVtIGJ1aWxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Mjg3MjAKKworICAgICAgICBUaGUgcHJldmlvdXMgZml4IHI0Nzc1NyBkb2VzIG5vdCBoYW5k bGUgdGhlIFY4IG9iamVjdCBjb252ZXJzaW9uIGNvcnJlY3RseS4KKworICAgICAgICAqIGJpbmRp bmdzL3Y4L2N1c3RvbS9WOERvY3VtZW50Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNB TExCQUNLX0ZVTkNfREVDTCk6CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTENh bnZhc0VsZW1lbnRDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q0FMTEJBQ0tfRlVOQ19E RUNMKToKKworMjAwOS0wOC0yNSAgSmlhbiBMaSAgPGppYW5saUBjaHJvbWl1bS5vcmc+CisKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCiAKICAgICAgICAgW1Y4XSBGaXggY29tcGls aW5nIGVycm9ycyBpbiBDaHJvbWl1bSBidWlsZCBjYXVzZWQgYnkgQ2FudmFzM0QgY2hhbmdlcyBm cm9tIHI0Nzc1Mi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RG9j dW1lbnRDdXN0b20uY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhEb2N1bWVudEN1 c3RvbS5jcHAKaW5kZXggYzY3ZDg3ZS4uYmE3ZjkyZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhEb2N1bWVudEN1c3RvbS5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5n cy92OC9jdXN0b20vVjhEb2N1bWVudEN1c3RvbS5jcHAKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNs dWRlICJjb25maWcuaCIKICNpbmNsdWRlICJEb2N1bWVudC5oIgogCisjaW5jbHVkZSAiQ2FudmFz UmVuZGVyaW5nQ29udGV4dC5oIgogI2luY2x1ZGUgIkV4Y2VwdGlvbkNvZGUuaCIKICNpbmNsdWRl ICJOb2RlLmgiCiAjaW5jbHVkZSAiWFBhdGhOU1Jlc29sdmVyLmgiCkBAIC05Myw3ICs5NCwxMyBA QCBDQUxMQkFDS19GVU5DX0RFQ0woRG9jdW1lbnRHZXRDU1NDYW52YXNDb250ZXh0KQogICAgIGlu dCB3aWR0aCA9IHRvSW50MzIoYXJnc1syXSk7CiAgICAgaW50IGhlaWdodCA9IHRvSW50MzIoYXJn c1szXSk7CiAgICAgQ2FudmFzUmVuZGVyaW5nQ29udGV4dCogcmVzdWx0ID0gaW1wLT5nZXRDU1ND YW52YXNDb250ZXh0KGNvbnRleHRJZCwgbmFtZSwgd2lkdGgsIGhlaWdodCk7Ci0gICAgcmV0dXJu IFY4RE9NV3JhcHBlcjo6Y29udmVydFRvVjhPYmplY3QoVjhDbGFzc0luZGV4OjpDQU5WQVNSRU5E RVJJTkdDT05URVhULCByZXN1bHQpOworICAgIGlmIChyZXN1bHQtPmlzMmQoKSkKKyAgICAgICAg cmV0dXJuIFY4RE9NV3JhcHBlcjo6Y29udmVydFRvVjhPYmplY3QoVjhDbGFzc0luZGV4OjpDQU5W QVNSRU5ERVJJTkdDT05URVhUMkQsIHJlc3VsdCk7CisgICAgZWxzZSB7CisgICAgICAgIC8vIEZJ WE1FOiBBZGQgdGhlIGNvbnZlcnNpb24gdG8gQ2FudmFzUmVuZGVyaW5nQ29udGV4dDNEIHdoZW4g aXQgaXMgaG9va2VkIHVwLgorICAgICAgICBBU1NFUlQoZmFsc2UpOworICAgICAgICByZXR1cm4g djg6OkhhbmRsZTx2ODo6VmFsdWU+KCk7CisgICAgfQogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxDYW52YXNF bGVtZW50Q3VzdG9tLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTENhbnZh c0VsZW1lbnRDdXN0b20uY3BwCmluZGV4IGJhMzgxYTUuLmIyYTFhZjggMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTENhbnZhc0VsZW1lbnRDdXN0b20uY3BwCisr KyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTENhbnZhc0VsZW1lbnRDdXN0b20u Y3BwCkBAIC0zMSw2ICszMSw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiSFRN TENhbnZhc0VsZW1lbnQuaCIKIAorI2luY2x1ZGUgIkNhbnZhc1JlbmRlcmluZ0NvbnRleHQuaCIK ICNpbmNsdWRlICJWOEJpbmRpbmcuaCIKICNpbmNsdWRlICJWOEN1c3RvbUJpbmRpbmcuaCIKICNp bmNsdWRlICJWOE5vZGUuaCIKQEAgLTQ1LDcgKzQ2LDEzIEBAIENBTExCQUNLX0ZVTkNfREVDTChI VE1MQ2FudmFzRWxlbWVudEdldENvbnRleHQpCiAgICAgSFRNTENhbnZhc0VsZW1lbnQqIGltcCA9 IFY4RE9NV3JhcHBlcjo6Y29udmVydERPTVdyYXBwZXJUb05vZGU8SFRNTENhbnZhc0VsZW1lbnQ+ KGhvbGRlcik7CiAgICAgU3RyaW5nIGNvbnRleHRJZCA9IHRvV2ViQ29yZVN0cmluZyhhcmdzWzBd KTsKICAgICBDYW52YXNSZW5kZXJpbmdDb250ZXh0KiByZXN1bHQgPSBpbXAtPmdldENvbnRleHQo Y29udGV4dElkKTsKLSAgICByZXR1cm4gVjhET01XcmFwcGVyOjpjb252ZXJ0VG9WOE9iamVjdChW OENsYXNzSW5kZXg6OkNBTlZBU1JFTkRFUklOR0NPTlRFWFQsIHJlc3VsdCk7CisgICAgaWYgKHJl c3VsdC0+aXMyZCgpKQorICAgICAgICByZXR1cm4gVjhET01XcmFwcGVyOjpjb252ZXJ0VG9WOE9i amVjdChWOENsYXNzSW5kZXg6OkNBTlZBU1JFTkRFUklOR0NPTlRFWFQyRCwgcmVzdWx0KTsKKyAg ICBlbHNlIHsKKyAgICAgICAgLy8gRklYTUU6IEFkZCB0aGUgY29udmVyc2lvbiB0byBDYW52YXNS ZW5kZXJpbmdDb250ZXh0M0Qgd2hlbiBpdCBpcyBob29rZWQgdXAuCisgICAgICAgIEFTU0VSVChm YWxzZSk7CisgICAgICAgIHJldHVybiB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4oKTsKKyAgICB9CiB9 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK