28713 2009-08-25 09:49:37 -0700 PLATFORM(CFNETWORK) should be USE(CFNETWORK). 2009-08-25 11:30:28 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 levin levin aroben eric oldest_to_newest 142595 0 levin 2009-08-25 09:49:37 -0700 http://trac.webkit.org/changeset/44267 did this in WebKit/win/WebError.cpp http://trac.webkit.org/changeset/45505 did this in WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp 142597 1 38552 levin 2009-08-25 09:53:56 -0700 Created attachment 38552 Proposed fix. 142616 2 eric 2009-08-25 10:23:28 -0700 Looks fine to me. CCing adam so he sees this go by. 142617 3 38552 eric 2009-08-25 10:23:53 -0700 Comment on attachment 38552 Proposed fix. LGTM. You can cq+ this yourself if you like. 142621 4 38552 aroben 2009-08-25 10:28:42 -0700 Comment on attachment 38552 Proposed fix. This looks good. Let's define WTF_PLATFORM_CFNETWORK to something that will cause a compiler error that explains the problem. Something like: #define WTF_PLATFORM_CFNETWORK USE_macro_should_be_used_with_CFNETWORK 142642 5 38556 levin 2009-08-25 10:58:03 -0700 Created attachment 38556 Proposed fix. 142653 6 38556 aroben 2009-08-25 11:24:04 -0700 Comment on attachment 38556 Proposed fix. r=me 142655 7 levin 2009-08-25 11:30:28 -0700 Committed as https://bugs.webkit.org/show_bug.cgi?id=28713 38552 2009-08-25 09:53:56 -0700 2009-08-25 10:58:03 -0700 Proposed fix. bug28713.txt text/plain 2904 levin ZGlmZiAtLWdpdCBhL1dlYktpdC93aW4vQ2hhbmdlTG9nIGIvV2ViS2l0L3dpbi9DaGFuZ2VMb2cK aW5kZXggNmM1MmY5Zi4uMzlhOWNlOSAxMDA2NDQKLS0tIGEvV2ViS2l0L3dpbi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOC0yNSAg RGF2aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUExBVEZPUk0oQ0ZORVRXT1JLKSBzaG91bGQgYmUg VVNFKENGTkVUV09SSykuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yODcxMworCisgICAgICAgIEFsc28sIG1vdmVkIHRoZSAjaWYgaGVhZGVyIHNlY3Rp b24gYWZ0ZXIgdGhlIG90aGVyICNpbmNsdWRlcy4KKworICAgICAgICAqIFdlYkVycm9yLmNwcDoK KyAgICAgICAgKFdlYkVycm9yOjpsb2NhbGl6ZWREZXNjcmlwdGlvbik6CisKIDIwMDktMDgtMjIg IEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZlcnQgNDc2ODQu ICBXZSdyZSBnb2luZyB0byBkbyB0aGlzIGxhdGVyIG9uY2UgY2xpZW50cyBoYXZlIGhhZCBhCmRp ZmYgLS1naXQgYS9XZWJLaXQvd2luL1dlYkVycm9yLmNwcCBiL1dlYktpdC93aW4vV2ViRXJyb3Iu Y3BwCmluZGV4IDg1MTRmZDYuLmM5ZjFkZmYgMTAwNjQ0Ci0tLSBhL1dlYktpdC93aW4vV2ViRXJy b3IuY3BwCisrKyBiL1dlYktpdC93aW4vV2ViRXJyb3IuY3BwCkBAIC0xMzcsNyArMTM3LDcgQEAg SFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBXZWJFcnJvcjo6bG9jYWxpemVkRGVzY3JpcHRpb24o CiAKICAgICAqcmVzdWx0ID0gQlN0cmluZyhtX2Vycm9yLmxvY2FsaXplZERlc2NyaXB0aW9uKCkp LnJlbGVhc2UoKTsKIAotI2lmIFBMQVRGT1JNKENGTkVUV09SSykKKyNpZiBVU0UoQ0ZORVRXT1JL KQogICAgIGlmICghKnJlc3VsdCkgewogICAgICAgICBpZiAoaW50IGNvZGUgPSBtX2Vycm9yLmVy cm9yQ29kZSgpKQogICAgICAgICAgICAgKnJlc3VsdCA9IEJTdHJpbmcod2tDRk5ldHdvcmtFcnJv ckdldExvY2FsaXplZERlc2NyaXB0aW9uKGNvZGUpKS5yZWxlYXNlKCk7CmRpZmYgLS1naXQgYS9X ZWJLaXRUb29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggNWM1YjJj YS4uYmQ4MmM0NiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktp dFRvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDA5LTA4LTI1ICBEYXZpZCBMZXZp biAgPGxldmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBQTEFURk9STShDRk5FVFdPUkspIHNob3VsZCBiZSBVU0UoQ0ZORVRX T1JLKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4 NzEzCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwOgor ICAgICAgICAobWFpbik6CisKIDIwMDktMDgtMjUgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJu ZS52ZXN0Ym9Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFyaXlhIEhpZGF5YXQu CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRy ZWUuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNw cAppbmRleCAwMjI4OTA1Li5lMzMxYjU0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTUwLDE0ICs1MCwxNSBAQAogI2luY2x1 ZGUgPHd0Zi9SZXRhaW5QdHIuaD4KICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAjaW5jbHVkZSA8 d2luZG93cy5oPgotI2lmIFBMQVRGT1JNKENGTkVUV09SSykKLSNpbmNsdWRlIDxDRk5ldHdvcmsv Q0ZVUkxDYWNoZVByaXYuaD4KLSNlbmRpZgogI2luY2x1ZGUgPENvcmVGb3VuZGF0aW9uL0NvcmVG b3VuZGF0aW9uLmg+CiAjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuaD4K ICNpbmNsdWRlIDxXZWJLaXQvV2ViS2l0Lmg+CiAjaW5jbHVkZSA8V2ViS2l0L1dlYktpdENPTUFQ SS5oPgogCisjaWYgVVNFKENGTkVUV09SSykKKyNpbmNsdWRlIDxDRk5ldHdvcmsvQ0ZVUkxDYWNo ZVByaXYuaD4KKyNlbmRpZgorCiB1c2luZyBuYW1lc3BhY2Ugc3RkOwogCiAjaWZuZGVmIE5ERUJV RwpAQCAtMTA2MSw3ICsxMDYyLDcgQEAgSVdlYlZpZXcqIGNyZWF0ZVdlYlZpZXdBbmRPZmZzY3Jl ZW5XaW5kb3coSFdORCogd2ViVmlld1dpbmRvdykKICAgICByZXR1cm4gd2ViVmlldzsKIH0KIAot I2lmIFBMQVRGT1JNKENGTkVUV09SSykKKyNpZiBVU0UoQ0ZORVRXT1JLKQogUmV0YWluUHRyPENG VVJMQ2FjaGVSZWY+IHNoYXJlZENGVVJMQ2FjaGUoKQogewogICAgIEhNT0RVTEUgbW9kdWxlID0g R2V0TW9kdWxlSGFuZGxlKFRFWFQoIkNGTmV0d29ya19kZWJ1Zy5kbGwiKSk7CkBAIC0xMTUxLDcg KzExNTIsNyBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciogYXJndltdKQogICAgIGlmIChGQUlM RUQod2ViVmlldy0+bWFpbkZyYW1lKCZmcmFtZSkpKQogICAgICAgICByZXR1cm4gLTE7CiAKLSNp ZiBQTEFURk9STShDRk5FVFdPUkspCisjaWYgVVNFKENGTkVUV09SSykKICAgICBSZXRhaW5QdHI8 Q0ZVUkxDYWNoZVJlZj4gdXJsQ2FjaGUgPSBzaGFyZWRDRlVSTENhY2hlKCk7CiAgICAgQ0ZVUkxD YWNoZVJlbW92ZUFsbENhY2hlZFJlc3BvbnNlcyh1cmxDYWNoZS5nZXQoKSk7CiAjZW5kaWYK 38556 2009-08-25 10:58:03 -0700 2009-08-25 11:24:04 -0700 Proposed fix. bug28713.txt text/plain 4092 levin ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBmNmUxODcwLi5hOTQ2ZjBiIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMDktMDgtMjUgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBMQVRGT1JNKENGTkVU V09SSykgc2hvdWxkIGJlIFVTRShDRk5FVFdPUkspLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg3MTMKKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5o OiBBZGRlZCBhICNkZWZpbmUgdG8gY2F0Y2ggdGhpcyBpc3N1ZSBpbiB0aGUKKyAgICAgICAgZnV0 dXJlLiBUaGUgZGVmaW5lIHdvdWxkIGdlbmVyYXRlIGFuIGVycm9yIG9uIGdjYyB3aXRob3V0IHRo ZQorICAgICAgICBzcGFjZSBpbiB0aGUgZXhwYW5zaW9uLCBidXQgVmlzdWFsIEMrKyBuZWVkcyB0 aGUgc3BhY2UgdG8gY2F1c2UgYW4gZXJyb3IuCisKIDIwMDktMDgtMjQgIEdlb2ZmcmV5IEdhcmVu ICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXg6IHN0YXJ0IG91dCB3aXRo IGEgMzItYml0IHZhbHVlIHRvIGF2b2lkIGEgc2hvcnRlbmluZyB3YXJuaW5nLgpkaWZmIC0tZ2l0 IGEvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmggYi9KYXZhU2NyaXB0Q29yZS93dGYvUGxh dGZvcm0uaAppbmRleCA5OGQ2MjZjLi5iMjA4NDZkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS93dGYvUGxhdGZvcm0uaAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaApAQCAt NzU5LDQgKzc1OSw3IEBACiAjZGVmaW5lIFdBUk5fVU5VU0VEX1JFVFVSTgogI2VuZGlmCiAKKy8q IFNldCB1cCBhIGRlZmluZSBmb3IgYSBjb21tb24gZXJyb3IgdGhhdCBpcyBpbnRlbmRlZCB0byBj YXVzZSBhIGJ1aWxkIGVycm9yIC0tIHRodXMgdGhlIHNwYWNlIGFmdGVyIEVycm9yLiAqLworI2Rl ZmluZSBXVEZfUExBVEZPUk1fQ0ZORVRXT1JLIEVycm9yIFVTRV9tYWNyb19zaG91bGRfYmVfdXNl ZF93aXRoX0NGTkVUV09SSworCiAjZW5kaWYgLyogV1RGX1BsYXRmb3JtX2ggKi8KZGlmZiAtLWdp dCBhL1dlYktpdC93aW4vQ2hhbmdlTG9nIGIvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKaW5kZXggNmM1 MmY5Zi4uMzlhOWNlOSAxMDA2NDQKLS0tIGEvV2ViS2l0L3dpbi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0L3dpbi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOC0yNSAgRGF2aWQgTGV2 aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUExBVEZPUk0oQ0ZORVRXT1JLKSBzaG91bGQgYmUgVVNFKENGTkVU V09SSykuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y ODcxMworCisgICAgICAgIEFsc28sIG1vdmVkIHRoZSAjaWYgaGVhZGVyIHNlY3Rpb24gYWZ0ZXIg dGhlIG90aGVyICNpbmNsdWRlcy4KKworICAgICAgICAqIFdlYkVycm9yLmNwcDoKKyAgICAgICAg KFdlYkVycm9yOjpsb2NhbGl6ZWREZXNjcmlwdGlvbik6CisKIDIwMDktMDgtMjIgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZlcnQgNDc2ODQuICBXZSdyZSBn b2luZyB0byBkbyB0aGlzIGxhdGVyIG9uY2UgY2xpZW50cyBoYXZlIGhhZCBhCmRpZmYgLS1naXQg YS9XZWJLaXQvd2luL1dlYkVycm9yLmNwcCBiL1dlYktpdC93aW4vV2ViRXJyb3IuY3BwCmluZGV4 IDg1MTRmZDYuLmM5ZjFkZmYgMTAwNjQ0Ci0tLSBhL1dlYktpdC93aW4vV2ViRXJyb3IuY3BwCisr KyBiL1dlYktpdC93aW4vV2ViRXJyb3IuY3BwCkBAIC0xMzcsNyArMTM3LDcgQEAgSFJFU1VMVCBT VERNRVRIT0RDQUxMVFlQRSBXZWJFcnJvcjo6bG9jYWxpemVkRGVzY3JpcHRpb24oCiAKICAgICAq cmVzdWx0ID0gQlN0cmluZyhtX2Vycm9yLmxvY2FsaXplZERlc2NyaXB0aW9uKCkpLnJlbGVhc2Uo KTsKIAotI2lmIFBMQVRGT1JNKENGTkVUV09SSykKKyNpZiBVU0UoQ0ZORVRXT1JLKQogICAgIGlm ICghKnJlc3VsdCkgewogICAgICAgICBpZiAoaW50IGNvZGUgPSBtX2Vycm9yLmVycm9yQ29kZSgp KQogICAgICAgICAgICAgKnJlc3VsdCA9IEJTdHJpbmcod2tDRk5ldHdvcmtFcnJvckdldExvY2Fs aXplZERlc2NyaXB0aW9uKGNvZGUpKS5yZWxlYXNlKCk7CmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggNWM1YjJjYS4uYmQ4MmM0 NiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0No YW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDA5LTA4LTI1ICBEYXZpZCBMZXZpbiAgPGxldmlu QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBQTEFURk9STShDRk5FVFdPUkspIHNob3VsZCBiZSBVU0UoQ0ZORVRXT1JLKS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4NzEzCisKKyAg ICAgICAgKiBEdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAo bWFpbik6CisKIDIwMDktMDgtMjUgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9A bm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFyaXlhIEhpZGF5YXQuCmRpZmYgLS1n aXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwIGIv V2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCAw MjI4OTA1Li5lMzMxYjU0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS93 aW4vRHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dp bi9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTUwLDE0ICs1MCwxNSBAQAogI2luY2x1ZGUgPHd0Zi9S ZXRhaW5QdHIuaD4KICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAjaW5jbHVkZSA8d2luZG93cy5o PgotI2lmIFBMQVRGT1JNKENGTkVUV09SSykKLSNpbmNsdWRlIDxDRk5ldHdvcmsvQ0ZVUkxDYWNo ZVByaXYuaD4KLSNlbmRpZgogI2luY2x1ZGUgPENvcmVGb3VuZGF0aW9uL0NvcmVGb3VuZGF0aW9u Lmg+CiAjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuaD4KICNpbmNsdWRl IDxXZWJLaXQvV2ViS2l0Lmg+CiAjaW5jbHVkZSA8V2ViS2l0L1dlYktpdENPTUFQSS5oPgogCisj aWYgVVNFKENGTkVUV09SSykKKyNpbmNsdWRlIDxDRk5ldHdvcmsvQ0ZVUkxDYWNoZVByaXYuaD4K KyNlbmRpZgorCiB1c2luZyBuYW1lc3BhY2Ugc3RkOwogCiAjaWZuZGVmIE5ERUJVRwpAQCAtMTA2 MSw3ICsxMDYyLDcgQEAgSVdlYlZpZXcqIGNyZWF0ZVdlYlZpZXdBbmRPZmZzY3JlZW5XaW5kb3co SFdORCogd2ViVmlld1dpbmRvdykKICAgICByZXR1cm4gd2ViVmlldzsKIH0KIAotI2lmIFBMQVRG T1JNKENGTkVUV09SSykKKyNpZiBVU0UoQ0ZORVRXT1JLKQogUmV0YWluUHRyPENGVVJMQ2FjaGVS ZWY+IHNoYXJlZENGVVJMQ2FjaGUoKQogewogICAgIEhNT0RVTEUgbW9kdWxlID0gR2V0TW9kdWxl SGFuZGxlKFRFWFQoIkNGTmV0d29ya19kZWJ1Zy5kbGwiKSk7CkBAIC0xMTUxLDcgKzExNTIsNyBA QCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciogYXJndltdKQogICAgIGlmIChGQUlMRUQod2ViVmll dy0+bWFpbkZyYW1lKCZmcmFtZSkpKQogICAgICAgICByZXR1cm4gLTE7CiAKLSNpZiBQTEFURk9S TShDRk5FVFdPUkspCisjaWYgVVNFKENGTkVUV09SSykKICAgICBSZXRhaW5QdHI8Q0ZVUkxDYWNo ZVJlZj4gdXJsQ2FjaGUgPSBzaGFyZWRDRlVSTENhY2hlKCk7CiAgICAgQ0ZVUkxDYWNoZVJlbW92 ZUFsbENhY2hlZFJlc3BvbnNlcyh1cmxDYWNoZS5nZXQoKSk7CiAjZW5kaWYK