28712 2009-08-25 08:35:30 -0700 qwebhistory_p.h need code cleanup 2009-08-27 04:47:07 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED P4 Trivial --- 0 jedrzej.nowacki webkit-unassigned ariya.hidayat kenneth oldest_to_newest 142579 0 jedrzej.nowacki 2009-08-25 08:35:30 -0700 Source code is badly formated, there is big commented block of unused code. 142583 1 38549 jedrzej.nowacki 2009-08-25 08:41:10 -0700 Created attachment 38549 Formating fix of qwebhistory_p.h Trivial formating fix 142695 2 kenneth 2009-08-25 13:59:14 -0700 Looks good to me, though I believe it is called "formatting". 142806 3 jedrzej.nowacki 2009-08-26 00:24:59 -0700 (In reply to comment #2) > Looks good to me, though I believe it is called "formatting". Yes "formaTTing" is beTTer :-) 143096 4 ariya.hidayat 2009-08-27 04:47:07 -0700 Landed in r47817: http://trac.webkit.org/changeset/47817 38549 2009-08-25 08:41:10 -0700 2009-08-27 04:36:12 -0700 Formating fix of qwebhistory_p.h cleanup.diff text/plain 2249 jedrzej.nowacki ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmhpc3RvcnlfcC5oIGIvV2ViS2l0L3F0L0Fw aS9xd2ViaGlzdG9yeV9wLmgKaW5kZXggZTc3YWRlZi4uODA5ZDQwNSAxMDA2NDQKLS0tIGEvV2Vi S2l0L3F0L0FwaS9xd2ViaGlzdG9yeV9wLmgKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2ViaGlzdG9y eV9wLmgKQEAgLTI3LDExICsyNywxMSBAQAogCiBjbGFzcyBRX0FVVE9URVNUX0VYUE9SVCBRV2Vi SGlzdG9yeUl0ZW1Qcml2YXRlIDogcHVibGljIFFTaGFyZWREYXRhIHsKIHB1YmxpYzoKLSAgICBz dGF0aWMgUUV4cGxpY2l0bHlTaGFyZWREYXRhUG9pbnRlcjxRV2ViSGlzdG9yeUl0ZW1Qcml2YXRl PiBnZXQoUVdlYkhpc3RvcnlJdGVtICpxKQorICAgIHN0YXRpYyBRRXhwbGljaXRseVNoYXJlZERh dGFQb2ludGVyPFFXZWJIaXN0b3J5SXRlbVByaXZhdGU+IGdldChRV2ViSGlzdG9yeUl0ZW0qIHEp CiAgICAgewogICAgICAgICByZXR1cm4gcS0+ZDsKICAgICB9Ci0gICAgUVdlYkhpc3RvcnlJdGVt UHJpdmF0ZShXZWJDb3JlOjpIaXN0b3J5SXRlbSAqaSkKKyAgICBRV2ViSGlzdG9yeUl0ZW1Qcml2 YXRlKFdlYkNvcmU6Okhpc3RvcnlJdGVtKiBpKQogICAgIHsKICAgICAgICAgaWYgKGkpCiAgICAg ICAgICAgICBpLT5yZWYoKTsKQEAgLTQzLDMwICs0MywxMiBAQCBwdWJsaWM6CiAgICAgICAgICAg ICBpdGVtLT5kZXJlZigpOwogICAgIH0KIAotIC8qICAgUUJ5dGVBcnJheSBzYXZlU3RhdGVXaXRo b3V0VmVyc2lvbkNvbnRyb2woUVdlYkhpc3Rvcnk6Okhpc3RvcnlTdGF0ZVZlcnNpb24gdmVyc2lv bikKLSAgICB7Ci0gICAgICAgIFFCeXRlQXJyYXkgYnVmZmVyOwotICAgICAgICBzd2l0Y2godmVy c2lvbil7Ci0gICAgICAgICAgICBjYXNlIFFXZWJIaXN0b3J5OjpIaXN0b3J5VmVyc2lvbjE6Ci0g ICAgICAgICAgICAgICAgYnVmZmVyPWl0ZW0tPnNhdmVTdGF0ZSh2ZXJzaW9uKTsKLSAgICAgICAg ICAgICAgICBicmVhazsKLSAgICAgICAgICAgIGRlZmF1bHQ6e30KLSAgICAgICAgfQotICAgICAg ICByZXR1cm4gYnVmZmVyOwotICAgIH0KLQotICAgIGJvb2wgcmVzdG9yZVN0YXRlV2l0aG91dFZl cnNpb25Db250cm9sKFFXZWJIaXN0b3J5OjpIaXN0b3J5U3RhdGVWZXJzaW9uIHZlcnNpb24sUURh dGFTdHJlYW0mIHN0cmVhbSkKLSAgICB7Ci0KLSAgICB9Ci0qLwotCi0gICAgV2ViQ29yZTo6SGlz dG9yeUl0ZW0gKml0ZW07CisgICAgV2ViQ29yZTo6SGlzdG9yeUl0ZW0qIGl0ZW07CiB9OwogCiBj bGFzcyBRV2ViSGlzdG9yeVByaXZhdGUgOiBwdWJsaWMgUVNoYXJlZERhdGEgewogcHVibGljOgot ICAgIFFXZWJIaXN0b3J5UHJpdmF0ZShXZWJDb3JlOjpCYWNrRm9yd2FyZExpc3QgKmwpCisgICAg UVdlYkhpc3RvcnlQcml2YXRlKFdlYkNvcmU6OkJhY2tGb3J3YXJkTGlzdCogbCkKICAgICB7CiAg ICAgICAgIGwtPnJlZigpOwogICAgICAgICBsc3QgPSBsOwpAQCAtNzUsNyArNTcsNyBAQCBwdWJs aWM6CiAgICAgewogICAgICAgICBsc3QtPmRlcmVmKCk7CiAgICAgfQotICAgIFdlYkNvcmU6OkJh Y2tGb3J3YXJkTGlzdCAqbHN0OworICAgIFdlYkNvcmU6OkJhY2tGb3J3YXJkTGlzdCogbHN0Owog fTsKIAogCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2ViS2l0L3F0L0NoYW5n ZUxvZwppbmRleCA4NjM2Y2I0Li43YmUyZDhlIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdl TG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wOC0y NSAgSmVkcnplaiBOb3dhY2tpICA8amVkcnplai5ub3dhY2tpQG5va2lhLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhbnVwCisgICAgICAg IAorICAgICAgICBPbGQgYW5kIGNvbW1lbnRlZCBwYXJ0IG9mIHNvdXJjZSBjb2RlIHdhcyByZW1v dmVkLgorICAgICAgICBGaXggc29tZSBmb3JtYXRpbmcgcHJvYmxlbXMuCisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4NzEyCisKKyAgICAgICAgKiBB cGkvcXdlYmhpc3RvcnlfcC5oOgorICAgICAgICAoUVdlYkhpc3RvcnlQcml2YXRlOjpRV2ViSGlz dG9yeVByaXZhdGUpOgorCiAyMDA5LTA4LTIyICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2ZXJ0IDQ3Njg0LiAgV2UncmUgZ29pbmcgdG8gZG8gdGhpcyBsYXRl ciBvbmNlIGNsaWVudHMgaGF2ZSBoYWQgYQo=