286982 2025-02-03 19:25:30 -0800 Suppress lambda capture warning in StreamConnectionWorkQueue.cpp 2025-02-07 02:53:49 -0800 1 1 1 Unclassified WebKit New Bugs Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa dpino dpino webkit-bug-importer oldest_to_newest 2091689 0 rniwa 2025-02-03 19:25:30 -0800 Suppress the lambda capture static analyzer warning in StreamConnectionWorkQueue.cpp. 2091690 1 rniwa 2025-02-03 19:27:40 -0800 Pull request: https://github.com/WebKit/WebKit/pull/39957 2091751 2 ews-feeder 2025-02-04 00:13:09 -0800 Committed 289774@main (a4b28dc46934): <https://commits.webkit.org/289774@main> Reviewed commits have been landed. Closing PR #39957 and removing active labels. 2091752 3 webkit-bug-importer 2025-02-04 00:14:45 -0800 <rdar://problem/144143542> 2092712 4 dpino 2025-02-07 00:09:49 -0800 Compilation with Clang-18 and lower is failing after this commit: https://build.webkit.org/#/builders/628/builds/19509 ``` FAILED: Source/WTF/wtf/CMakeFiles/WTF.dir/MainThread.cpp.o /usr/bin/ccache /usr/lib/sdk/llvm18/bin/clang++ -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WPE__=1 -DBUILDING_WTF -DBWRAP_EXECUTABLE=\"/usr/bin/bwrap\" -DDBUS_PROXY_EXECUTABLE=\"/usr/bin/xdg-dbus-proxy\" -DGETTEXT_PACKAGE=\"WPE\" -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DPAS_BMALLOC=1 -DSTATICALLY_LINKED_WITH_bmalloc -I/app/webkit/WebKitBuild/WPE/Release -I/app/webkit/WebKitBuild/WPE/Release/WTF/DerivedSources -I/app/webkit/Source/WTF -I/app/webkit/Source/WTF/wtf -I/app/webkit/Source/WTF/wtf/dtoa -I/app/webkit/Source/WTF/wtf/fast_float -I/app/webkit/Source/WTF/wtf/persistence -I/app/webkit/Source/WTF/wtf/simdutf -I/app/webkit/Source/WTF/wtf/text -I/app/webkit/Source/WTF/wtf/text/icu -I/app/webkit/Source/WTF/wtf/threads -I/app/webkit/Source/WTF/wtf/unicode -I/app/webkit/WebKitBuild/WPE/Release/bmalloc/Headers -isystem /usr/include/gio-unix-2.0 -isystem /usr/include/glib-2.0 -isystem /usr/lib/x86_64-linux-gnu/glib-2.0/include -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/sysprof-6 -fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -Werror=undefined-internal -Werror=undefined-inline -pipe -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-parentheses-equality -Qunused-arguments -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare -fasynchronous-unwind-tables -fdebug-types-section -fno-strict-aliasing -fno-exceptions -fno-rtti -fcoroutines -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++23 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Wunsafe-buffer-usage -fsafe-buffer-usage-suggestions -pthread -MD -MT Source/WTF/wtf/CMakeFiles/WTF.dir/MainThread.cpp.o -MF Source/WTF/wtf/CMakeFiles/WTF.dir/MainThread.cpp.o.d -o Source/WTF/wtf/CMakeFiles/WTF.dir/MainThread.cpp.o -c /app/webkit/Source/WTF/wtf/MainThread.cpp In file included from /app/webkit/Source/WTF/wtf/MainThread.cpp:37: /app/webkit/Source/WTF/wtf/RunLoop.h:188:58: error: 'suppress' attribute only applies to variables and statements 188 | : Timer(WTFMove(runLoop), [object, function] SUPPRESS_UNCOUNTED_LAMBDA_CAPTURE { // The Timer's owner is expected to cancel the Timer in its destructor. | ^ ``` It's a compiler error. Clang-18 doesn't support 'suppress' attribute on lambdas. https://godbolt.org/z/M8oE6hh5s 2092715 5 rniwa 2025-02-07 00:35:56 -0800 You probably need to disable these macros in your version of clang. 2092732 6 dpino 2025-02-07 01:15:33 -0800 Re-opening for pull request https://github.com/WebKit/WebKit/pull/40199 2092746 7 ews-feeder 2025-02-07 02:53:47 -0800 Committed 289996@main (d01b88858f3b): <https://commits.webkit.org/289996@main> Reviewed commits have been landed. Closing PR #40199 and removing active labels.