28690 2009-08-24 15:38:39 -0700 Build failure in webkitgtk+-1.1.3 2009-08-25 00:20:09 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 David.Ronis webkit-unassigned xan.lopez oldest_to_newest 142433 0 David.Ronis 2009-08-24 15:38:39 -0700 Compilation fails in work/main.d/webkit-1.1.13/WebCore/platform/gtk/CursorGtk.cpp: gdk_pixbuf_unref(pixbuf); Turns out that gdk_pixbuf_unref is deprecated in gtk+ in version 2.17.8. I added the declaration manually, but all that did was to give me link errors. 142533 1 38534 xan.lopez 2009-08-25 00:10:00 -0700 Created attachment 38534 pixbufunref.patch You are right, patch attached. 142535 2 38534 xan.lopez 2009-08-25 00:19:51 -0700 Comment on attachment 38534 pixbufunref.patch This was r+ by Jan or IRC. 142536 3 xan.lopez 2009-08-25 00:20:09 -0700 Landed as r47742, closing. 38534 2009-08-25 00:10:00 -0700 2009-08-25 00:19:51 -0700 pixbufunref.patch pixbufunref.patch text/plain 1701 xan.lopez RnJvbSBjMWU0MDY3NTllNDMxMTg5OTM5Yjg5MjJmNjlkZTQ5M2M2ZjFjYjUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBU dWUsIDI1IEF1ZyAyMDA5IDEwOjA4OjQzICswMzAwClN1YmplY3Q6IFtQQVRDSF0gMjAwOS0wOC0y NSAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Mjg2OTAKICAgICAgICBCdWlsZCBmYWlsdXJlIGluIHdlYmtpdGd0aystMS4xLjMKCiAg ICAgICAgRG8gbm90IHVzZSBkZXByZWNhdGVkIGZ1bmN0aW9uIHRvIHVucmVmIGEgcGl4YnVmLgoK ICAgICAgICAqIHBsYXRmb3JtL2d0ay9DdXJzb3JHdGsuY3BwOgogICAgICAgIChXZWJDb3JlOjpD dXJzb3I6OkN1cnNvcik6Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICB8 ICAgMTIgKysrKysrKysrKysrCiBXZWJDb3JlL3BsYXRmb3JtL2d0ay9DdXJzb3JHdGsuY3BwIHwg ICAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggZWJiMTU2MS4uYzU4MWI0NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOC0yNSAgWGFuIExvcGV6 ICA8eGxvcGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI4 NjkwCisgICAgICAgIEJ1aWxkIGZhaWx1cmUgaW4gd2Via2l0Z3RrKy0xLjEuMworCisgICAgICAg IERvIG5vdCB1c2UgZGVwcmVjYXRlZCBmdW5jdGlvbiB0byB1bnJlZiBhIHBpeGJ1Zi4KKworICAg ICAgICAqIHBsYXRmb3JtL2d0ay9DdXJzb3JHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q3Vy c29yOjpDdXJzb3IpOgorCiAyMDA5LTA4LTI0ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCmRpZmYgLS1naXQgYS9X ZWJDb3JlL3BsYXRmb3JtL2d0ay9DdXJzb3JHdGsuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv Q3Vyc29yR3RrLmNwcAppbmRleCAwNWQ3NzJhLi4xYzY2OWYzIDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9DdXJzb3JHdGsuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0N1 cnNvckd0ay5jcHAKQEAgLTY3LDcgKzY3LDcgQEAgQ3Vyc29yOjpDdXJzb3IoSW1hZ2UqIGltYWdl LCBjb25zdCBJbnRQb2ludCYgaG90U3BvdCkKIHsKICAgICBHZGtQaXhidWYqIHBpeGJ1ZiA9IGlt YWdlLT5nZXRHZGtQaXhidWYoKTsKICAgICBtX2ltcGwgPSBnZGtfY3Vyc29yX25ld19mcm9tX3Bp eGJ1ZihnZGtfZGlzcGxheV9nZXRfZGVmYXVsdCgpLCBwaXhidWYsIGhvdFNwb3QueCgpLCBob3RT cG90LnkoKSk7Ci0gICAgZ2RrX3BpeGJ1Zl91bnJlZihwaXhidWYpOworICAgIGdfb2JqZWN0X3Vu cmVmKHBpeGJ1Zik7CiB9CiAKIEN1cnNvcjo6fkN1cnNvcigpCi0tIAoxLjYuNAoK