28684 2009-08-24 13:21:07 -0700 Crash after typing "clear" and pressing return in inspector console 2009-09-03 09:51:54 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED HasReduction P2 Normal --- 1 mrowe pfeldman pfeldman timothy yurys oldest_to_newest 142386 0 mrowe 2009-08-24 13:21:07 -0700 With a debug build of r47723, typing "clear" and then pressing return in the inspector console results in a crash: Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: KERN_PROTECTION_FAILURE at address: 0x00000010 0x015ba6f2 in WebCore::JSQuarantinedObjectWrapper::getCallData (this=0x16e20340, callData=@0xbfffd888) at WebCore/bindings/js/JSQuarantinedObjectWrapper.cpp:263 263 if (m_unwrappedObject->getCallData(unwrappedCallData) == CallTypeNone) (gdb) 144443 1 38972 pfeldman 2009-09-03 01:53:01 -0700 Created attachment 38972 patch As I was suggesting earlier, it seems like objects wrapped with wrapCallback do not survive gc. Here is an easy workaround for this bug while it is getting fixed. 144444 2 38973 pfeldman 2009-09-03 01:53:48 -0700 Created attachment 38973 patch (now with patch checkbox checked) 144537 3 pfeldman 2009-09-03 09:51:54 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/InjectedScript.js Committed r48022 38972 2009-09-03 01:53:01 -0700 2009-09-03 01:53:48 -0700 patch wrapper application/octet-stream 3169 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2I5YWNlNi4uYTVmNDE5ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wOS0wMyAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCisKKyAgICAgICAgQ3Jhc2ggYWZ0ZXIgdHlwaW5nICJjbGVhciIgYW5kIHByZXNz aW5nIHJldHVybiBpbiBpbnNwZWN0b3IgY29uc29sZS4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg2ODQKKworICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanM6CisgICAgICAgIChJbmplY3RlZFNjcmlwdC5fY2xl YXJDb25zb2xlTWVzc2FnZXMpOgorICAgICAgICAoSW5qZWN0ZWRTY3JpcHQuX2luc3BlY3RPYmpl Y3QpOgorICAgICAgICAoSW5qZWN0ZWRTY3JpcHQuX2Vuc3VyZUNvbW1hbmRMaW5lQVBJSW5zdGFs bGVkKToKKwogMjAwOS0wOS0wMiAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKaW5kZXggYzgxNWRmZC4uYTRmYTI4NCAxMDA2NDQK LS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzCisrKyBi L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcwpAQCAtODEwLDYg KzgxMCwzMiBAQCBJbmplY3RlZFNjcmlwdC5fY2FsbEZyYW1lRm9ySWQgPSBmdW5jdGlvbihpZCkK ICAgICByZXR1cm4gY2FsbEZyYW1lOwogfQogCitJbmplY3RlZFNjcmlwdC5fY2xlYXJDb25zb2xl TWVzc2FnZXMgPSBmdW5jdGlvbigpCit7CisgICAgSW5zcGVjdG9yQ29udHJvbGxlci5jbGVhck1l c3NhZ2VzKHRydWUpOworfQorCitJbmplY3RlZFNjcmlwdC5faW5zcGVjdE9iamVjdCA9IGZ1bmN0 aW9uKG8pCit7CisgICAgaWYgKGFyZ3VtZW50cy5sZW5ndGggPT09IDApCisgICAgICAgIHJldHVy bjsKKworICAgIHZhciBpbnNwZWN0ZWRXaW5kb3cgPSBJbmplY3RlZFNjcmlwdC5fd2luZG93KCk7 CisgICAgaW5zcGVjdGVkV2luZG93LmNvbnNvbGUubG9nKG8pOworICAgIGlmIChPYmplY3QudHlw ZShvKSA9PT0gIm5vZGUiKSB7CisgICAgICAgIEluc3BlY3RvckNvbnRyb2xsZXIucHVzaE5vZGVQ YXRoVG9Gcm9udGVuZChvLCB0cnVlKTsKKyAgICB9IGVsc2UgeworICAgICAgICBzd2l0Y2ggKE9i amVjdC5kZXNjcmliZShvKSkgeworICAgICAgICAgICAgY2FzZSAiRGF0YWJhc2UiOgorICAgICAg ICAgICAgICAgIEluc3BlY3RvckNvbnRyb2xsZXIuc2VsZWN0RGF0YWJhc2Uobyk7CisgICAgICAg ICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICBjYXNlICJTdG9yYWdlIjoKKyAgICAgICAgICAg ICAgICBJbnNwZWN0b3JDb250cm9sbGVyLnNlbGVjdERPTVN0b3JhZ2Uobyk7CisgICAgICAgICAg ICAgICAgYnJlYWs7CisgICAgICAgIH0KKyAgICB9Cit9CisKIEluamVjdGVkU2NyaXB0Ll9lbnN1 cmVDb21tYW5kTGluZUFQSUluc3RhbGxlZCA9IGZ1bmN0aW9uKGluc3BlY3RlZFdpbmRvdykKIHsK ICAgICB2YXIgaW5zcGVjdGVkV2luZG93ID0gSW5qZWN0ZWRTY3JpcHQuX3dpbmRvdygpOwpAQCAt ODQzLDI4ICs4NjksOCBAQCBJbmplY3RlZFNjcmlwdC5fZW5zdXJlQ29tbWFuZExpbmVBUElJbnN0 YWxsZWQgPSBmdW5jdGlvbihpbnNwZWN0ZWRXaW5kb3cpCiAgICAgICAgIGdldCAkNCgpIHsgcmV0 dXJuIF9pbnNwZWN0b3JDb21tYW5kTGluZUFQSS5faW5zcGVjdGVkTm9kZXNbNF0gfSBcCiAgICAg fTsiKTsKIAotICAgIGluc3BlY3RlZFdpbmRvdy5faW5zcGVjdG9yQ29tbWFuZExpbmVBUEkuY2xl YXIgPSBJbnNwZWN0b3JDb250cm9sbGVyLndyYXBDYWxsYmFjayhJbnNwZWN0b3JDb250cm9sbGVy LmNsZWFyTWVzc2FnZXMuYmluZChJbnNwZWN0b3JDb250cm9sbGVyLCB0cnVlKSk7Ci0gICAgaW5z cGVjdGVkV2luZG93Ll9pbnNwZWN0b3JDb21tYW5kTGluZUFQSS5pbnNwZWN0ID0gSW5zcGVjdG9y Q29udHJvbGxlci53cmFwQ2FsbGJhY2soaW5zcGVjdE9iamVjdC5iaW5kKHRoaXMpKTsKLQotICAg IGZ1bmN0aW9uIGluc3BlY3RPYmplY3QobykKLSAgICB7Ci0gICAgICAgIGlmIChhcmd1bWVudHMu bGVuZ3RoID09PSAwKQotICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAgIGluc3BlY3RlZFdp bmRvdy5jb25zb2xlLmxvZyhvKTsKLSAgICAgICAgaWYgKE9iamVjdC50eXBlKG8pID09PSAibm9k ZSIpIHsKLSAgICAgICAgICAgIEluc3BlY3RvckNvbnRyb2xsZXIucHVzaE5vZGVQYXRoVG9Gcm9u dGVuZChvLCB0cnVlKTsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIHN3aXRjaCAoT2Jq ZWN0LmRlc2NyaWJlKG8pKSB7Ci0gICAgICAgICAgICAgICAgY2FzZSAiRGF0YWJhc2UiOgotICAg ICAgICAgICAgICAgICAgICBJbnNwZWN0b3JDb250cm9sbGVyLnNlbGVjdERhdGFiYXNlKG8pOwot ICAgICAgICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgICAgICAgICBjYXNlICJTdG9yYWdl IjoKLSAgICAgICAgICAgICAgICAgICAgSW5zcGVjdG9yQ29udHJvbGxlci5zZWxlY3RET01TdG9y YWdlKG8pOwotICAgICAgICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgICAgIH0KLSAgICAg ICAgfQotICAgIH0KKyAgICBpbnNwZWN0ZWRXaW5kb3cuX2luc3BlY3RvckNvbW1hbmRMaW5lQVBJ LmNsZWFyID0gSW5zcGVjdG9yQ29udHJvbGxlci53cmFwQ2FsbGJhY2soSW5qZWN0ZWRTY3JpcHQu X2NsZWFyQ29uc29sZU1lc3NhZ2VzKTsKKyAgICBpbnNwZWN0ZWRXaW5kb3cuX2luc3BlY3RvckNv bW1hbmRMaW5lQVBJLmluc3BlY3QgPSBJbnNwZWN0b3JDb250cm9sbGVyLndyYXBDYWxsYmFjayhJ bmplY3RlZFNjcmlwdC5faW5zcGVjdE9iamVjdCk7CiB9CiAKIEluamVjdGVkU2NyaXB0Ll9yZXNv bHZlT2JqZWN0ID0gZnVuY3Rpb24ob2JqZWN0UHJveHkpCg== 38973 2009-09-03 01:53:48 -0700 2009-09-03 09:22:17 -0700 patch (now with patch checkbox checked) wrapper text/plain 3169 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2I5YWNlNi4uYTVmNDE5ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wOS0wMyAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCisKKyAgICAgICAgQ3Jhc2ggYWZ0ZXIgdHlwaW5nICJjbGVhciIgYW5kIHByZXNz aW5nIHJldHVybiBpbiBpbnNwZWN0b3IgY29uc29sZS4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg2ODQKKworICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanM6CisgICAgICAgIChJbmplY3RlZFNjcmlwdC5fY2xl YXJDb25zb2xlTWVzc2FnZXMpOgorICAgICAgICAoSW5qZWN0ZWRTY3JpcHQuX2luc3BlY3RPYmpl Y3QpOgorICAgICAgICAoSW5qZWN0ZWRTY3JpcHQuX2Vuc3VyZUNvbW1hbmRMaW5lQVBJSW5zdGFs bGVkKToKKwogMjAwOS0wOS0wMiAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKaW5kZXggYzgxNWRmZC4uYTRmYTI4NCAxMDA2NDQK LS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzCisrKyBi L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcwpAQCAtODEwLDYg KzgxMCwzMiBAQCBJbmplY3RlZFNjcmlwdC5fY2FsbEZyYW1lRm9ySWQgPSBmdW5jdGlvbihpZCkK ICAgICByZXR1cm4gY2FsbEZyYW1lOwogfQogCitJbmplY3RlZFNjcmlwdC5fY2xlYXJDb25zb2xl TWVzc2FnZXMgPSBmdW5jdGlvbigpCit7CisgICAgSW5zcGVjdG9yQ29udHJvbGxlci5jbGVhck1l c3NhZ2VzKHRydWUpOworfQorCitJbmplY3RlZFNjcmlwdC5faW5zcGVjdE9iamVjdCA9IGZ1bmN0 aW9uKG8pCit7CisgICAgaWYgKGFyZ3VtZW50cy5sZW5ndGggPT09IDApCisgICAgICAgIHJldHVy bjsKKworICAgIHZhciBpbnNwZWN0ZWRXaW5kb3cgPSBJbmplY3RlZFNjcmlwdC5fd2luZG93KCk7 CisgICAgaW5zcGVjdGVkV2luZG93LmNvbnNvbGUubG9nKG8pOworICAgIGlmIChPYmplY3QudHlw ZShvKSA9PT0gIm5vZGUiKSB7CisgICAgICAgIEluc3BlY3RvckNvbnRyb2xsZXIucHVzaE5vZGVQ YXRoVG9Gcm9udGVuZChvLCB0cnVlKTsKKyAgICB9IGVsc2UgeworICAgICAgICBzd2l0Y2ggKE9i amVjdC5kZXNjcmliZShvKSkgeworICAgICAgICAgICAgY2FzZSAiRGF0YWJhc2UiOgorICAgICAg ICAgICAgICAgIEluc3BlY3RvckNvbnRyb2xsZXIuc2VsZWN0RGF0YWJhc2Uobyk7CisgICAgICAg ICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICBjYXNlICJTdG9yYWdlIjoKKyAgICAgICAgICAg ICAgICBJbnNwZWN0b3JDb250cm9sbGVyLnNlbGVjdERPTVN0b3JhZ2Uobyk7CisgICAgICAgICAg ICAgICAgYnJlYWs7CisgICAgICAgIH0KKyAgICB9Cit9CisKIEluamVjdGVkU2NyaXB0Ll9lbnN1 cmVDb21tYW5kTGluZUFQSUluc3RhbGxlZCA9IGZ1bmN0aW9uKGluc3BlY3RlZFdpbmRvdykKIHsK ICAgICB2YXIgaW5zcGVjdGVkV2luZG93ID0gSW5qZWN0ZWRTY3JpcHQuX3dpbmRvdygpOwpAQCAt ODQzLDI4ICs4NjksOCBAQCBJbmplY3RlZFNjcmlwdC5fZW5zdXJlQ29tbWFuZExpbmVBUElJbnN0 YWxsZWQgPSBmdW5jdGlvbihpbnNwZWN0ZWRXaW5kb3cpCiAgICAgICAgIGdldCAkNCgpIHsgcmV0 dXJuIF9pbnNwZWN0b3JDb21tYW5kTGluZUFQSS5faW5zcGVjdGVkTm9kZXNbNF0gfSBcCiAgICAg fTsiKTsKIAotICAgIGluc3BlY3RlZFdpbmRvdy5faW5zcGVjdG9yQ29tbWFuZExpbmVBUEkuY2xl YXIgPSBJbnNwZWN0b3JDb250cm9sbGVyLndyYXBDYWxsYmFjayhJbnNwZWN0b3JDb250cm9sbGVy LmNsZWFyTWVzc2FnZXMuYmluZChJbnNwZWN0b3JDb250cm9sbGVyLCB0cnVlKSk7Ci0gICAgaW5z cGVjdGVkV2luZG93Ll9pbnNwZWN0b3JDb21tYW5kTGluZUFQSS5pbnNwZWN0ID0gSW5zcGVjdG9y Q29udHJvbGxlci53cmFwQ2FsbGJhY2soaW5zcGVjdE9iamVjdC5iaW5kKHRoaXMpKTsKLQotICAg IGZ1bmN0aW9uIGluc3BlY3RPYmplY3QobykKLSAgICB7Ci0gICAgICAgIGlmIChhcmd1bWVudHMu bGVuZ3RoID09PSAwKQotICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAgIGluc3BlY3RlZFdp bmRvdy5jb25zb2xlLmxvZyhvKTsKLSAgICAgICAgaWYgKE9iamVjdC50eXBlKG8pID09PSAibm9k ZSIpIHsKLSAgICAgICAgICAgIEluc3BlY3RvckNvbnRyb2xsZXIucHVzaE5vZGVQYXRoVG9Gcm9u dGVuZChvLCB0cnVlKTsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIHN3aXRjaCAoT2Jq ZWN0LmRlc2NyaWJlKG8pKSB7Ci0gICAgICAgICAgICAgICAgY2FzZSAiRGF0YWJhc2UiOgotICAg ICAgICAgICAgICAgICAgICBJbnNwZWN0b3JDb250cm9sbGVyLnNlbGVjdERhdGFiYXNlKG8pOwot ICAgICAgICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgICAgICAgICBjYXNlICJTdG9yYWdl IjoKLSAgICAgICAgICAgICAgICAgICAgSW5zcGVjdG9yQ29udHJvbGxlci5zZWxlY3RET01TdG9y YWdlKG8pOwotICAgICAgICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgICAgIH0KLSAgICAg ICAgfQotICAgIH0KKyAgICBpbnNwZWN0ZWRXaW5kb3cuX2luc3BlY3RvckNvbW1hbmRMaW5lQVBJ LmNsZWFyID0gSW5zcGVjdG9yQ29udHJvbGxlci53cmFwQ2FsbGJhY2soSW5qZWN0ZWRTY3JpcHQu X2NsZWFyQ29uc29sZU1lc3NhZ2VzKTsKKyAgICBpbnNwZWN0ZWRXaW5kb3cuX2luc3BlY3RvckNv bW1hbmRMaW5lQVBJLmluc3BlY3QgPSBJbnNwZWN0b3JDb250cm9sbGVyLndyYXBDYWxsYmFjayhJ bmplY3RlZFNjcmlwdC5faW5zcGVjdE9iamVjdCk7CiB9CiAKIEluamVjdGVkU2NyaXB0Ll9yZXNv bHZlT2JqZWN0ID0gZnVuY3Rpb24ob2JqZWN0UHJveHkpCg==