<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>286816</bug_id>
          
          <creation_ts>2025-01-31 10:18:36 -0800</creation_ts>
          <short_desc>[LibWebRTC] Fix Linux, GStreamer and unified build</short_desc>
          <delta_ts>2025-02-04 01:00:14 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebRTC</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Olivier Blin">olivier.blin</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2091023</commentid>
    <comment_count>0</comment_count>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2025-01-31 10:18:36 -0800</bug_when>
    <thetext>- libwebrtc: Remove test support files requiring gtest headers, this is not exposed in the CMake build
  (introduced in libwebrtc M132 update, 287962@main)
- LibWebRTCMediaEndpoint.cpp: Do not move rtcReport to avoid const qualified error (introduced in 287147@main)
- GStreamerVideoEncoderFactory.cpp: Use ASCIILiteral to avoid error from missing span(const gchar*) (from 279038@main)
- WebRTCMonitor.cpp: Include missing LibWebRTCNetwork.h for ref/deref methods

LibWebRTCMediaEndpoint.cpp errors:

/app/webkit/WebKitBuild/WPE/Debug/WTF/Headers/wtf/StdLibExtras.h: In instantiation of ‘constexpr typename std::remove_reference&lt;_Arg&gt;::type&amp;&amp; std::move(T&amp;&amp;) [with WTF::CheckMoveParameterTag &lt;anonymous&gt; = WTF::CheckMoveParameter; T = const webrtc::scoped_refptr&lt;const webrtc::RTCStatsReport&gt;&amp;; typename remove_reference&lt;_Arg&gt;::type = const webrtc::scoped_refptr&lt;const webrtc::RTCStatsReport&gt;]’:
/app/webkit/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:282:140:   required from here
/app/webkit/WebKitBuild/WPE/Debug/WTF/Headers/wtf/StdLibExtras.h:817:51: error: static assertion failed: T is const qualified.
  817 |     static_assert(!is_const&lt;NonRefQualifiedType&gt;::value, &quot;T is const qualified.&quot;);
      |                                                   ^~~~~
/app/webkit/WebKitBuild/WPE/Debug/WTF/Headers/wtf/StdLibExtras.h:817:51: note: ‘!(bool)std::integral_constant&lt;bool, true&gt;::value’ evaluates to false</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2091025</commentid>
    <comment_count>1</comment_count>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2025-01-31 10:23:07 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/39825</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2091759</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2025-02-04 00:59:43 -0800</bug_when>
    <thetext>Committed 289776@main (80245993fa5a): &lt;https://commits.webkit.org/289776@main&gt;

Reviewed commits have been landed. Closing PR #39825 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2091760</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2025-02-04 01:00:14 -0800</bug_when>
    <thetext>&lt;rdar://problem/144145258&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>