28678 2009-08-24 08:39:52 -0700 WebInspector: Only expand local scope when hitting the break 2009-08-24 13:21:20 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman timothy oldest_to_newest 142311 0 pfeldman 2009-08-24 08:39:52 -0700 Currently all the scopes are being expanded (CallFrame change regression). 142312 1 38480 pfeldman 2009-08-24 08:41:02 -0700 Created attachment 38480 patch 142315 2 38481 pfeldman 2009-08-24 09:05:18 -0700 Created attachment 38481 same with unused parameter cleanup 142316 3 38482 pfeldman 2009-08-24 09:06:08 -0700 Created attachment 38482 same with unused parameter cleanup 142318 4 pfeldman 2009-08-24 09:41:22 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/InjectedScript.js M WebCore/inspector/front-end/ScopeChainSidebarPane.js Committed r47717 142364 5 38492 pfeldman 2009-08-24 12:22:57 -0700 Created attachment 38492 second part of the fix First patch prevents _all_ scopes from being expanded, which is not enough. I missed the part where local one is expanded. 142387 6 pfeldman 2009-08-24 13:21:20 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ScopeChainSidebarPane.js Committed r47724 38480 2009-08-24 08:41:02 -0700 2009-08-24 09:05:18 -0700 patch scope_expand text/plain 1308 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDRiZDZmNS4uMzNlMDBjZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wOC0yNCAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCisKKyAgICAgICAgV2ViSW5zcGVjdG9yOiBPbmx5IGV4cGFuZCBsb2NhbCBzY29w ZSB3aGVuIGhpdHRpbmcgdGhlIGJyZWFrCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI4Njc4CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L1Njb3BlQ2hhaW5TaWRlYmFyUGFuZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TY29wZUNo YWluU2lkZWJhclBhbmUucHJvdG90eXBlLnVwZGF0ZSk6CisKIDIwMDktMDgtMTcgIE1hcnRpbiBS b2JpbnNvbiAgPG1hcnRpbi5qYW1lcy5yb2JpbnNvbkBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1Njb3BlQ2hhaW5TaWRlYmFyUGFuZS5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9TY29wZUNoYWluU2lkZWJhclBhbmUuanMKaW5kZXggYzM3MWU0Mi4uODM1NTdlOCAx MDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Njb3BlQ2hhaW5TaWRlYmFy UGFuZS5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NvcGVDaGFpblNpZGVi YXJQYW5lLmpzCkBAIC02Myw2ICs2Myw3IEBAIFdlYkluc3BlY3Rvci5TY29wZUNoYWluU2lkZWJh clBhbmUucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgICAgICB0aXRsZSA9IFdlYkluc3Bl Y3Rvci5VSVN0cmluZygiQ2xvc3VyZSIpOwogICAgICAgICAgICAgICAgIGVtcHR5UGxhY2Vob2xk ZXIgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIk5vIFZhcmlhYmxlcyIpOwogICAgICAgICAgICAg ICAgIHN1YnRpdGxlID0gbnVsbDsKKyAgICAgICAgICAgICAgICBmb3VuZExvY2FsU2NvcGUgPSB0 cnVlOwogICAgICAgICAgICAgfSBlbHNlIGlmIChpID09PSAoc2NvcGVDaGFpbi5sZW5ndGggLSAx KSkKICAgICAgICAgICAgICAgICB0aXRsZSA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiR2xvYmFs Iik7CiAgICAgICAgICAgICBlbHNlIGlmIChzY29wZU9iamVjdFByb3h5LmlzRWxlbWVudCkK 38481 2009-08-24 09:05:18 -0700 2009-08-24 09:06:08 -0700 same with unused parameter cleanup scope_expand application/octet-stream 1901 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDRiZDZmNS4uMzNlMDBjZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wOC0yNCAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCisKKyAgICAgICAgV2ViSW5zcGVjdG9yOiBPbmx5IGV4cGFuZCBsb2NhbCBzY29w ZSB3aGVuIGhpdHRpbmcgdGhlIGJyZWFrCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI4Njc4CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L1Njb3BlQ2hhaW5TaWRlYmFyUGFuZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TY29wZUNo YWluU2lkZWJhclBhbmUucHJvdG90eXBlLnVwZGF0ZSk6CisKIDIwMDktMDgtMTcgIE1hcnRpbiBS b2JpbnNvbiAgPG1hcnRpbi5qYW1lcy5yb2JpbnNvbkBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0luamVjdGVkU2NyaXB0LmpzCmluZGV4IDBhMGNiMDguLjFjMDI5YzMgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcworKysgYi9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKQEAgLTUzNCw3ICs1MzQsNyBA QCBJbmplY3RlZFNjcmlwdC5hZGRJbnNwZWN0ZWROb2RlID0gZnVuY3Rpb24obm9kZUlkKQogICAg IHJldHVybiB0cnVlOwogfQogCi1JbmplY3RlZFNjcmlwdC5wZXJmb3JtU2VhcmNoID0gZnVuY3Rp b24od2hpdGVzcGFjZVRyaW1tZWRRdWVyeSwgc2VhcmNoUmVzdWx0c1Byb3BlcnR5KQorSW5qZWN0 ZWRTY3JpcHQucGVyZm9ybVNlYXJjaCA9IGZ1bmN0aW9uKHdoaXRlc3BhY2VUcmltbWVkUXVlcnkp CiB7CiAgICAgdmFyIHRhZ05hbWVRdWVyeSA9IHdoaXRlc3BhY2VUcmltbWVkUXVlcnk7CiAgICAg dmFyIGF0dHJpYnV0ZU5hbWVRdWVyeSA9IHdoaXRlc3BhY2VUcmltbWVkUXVlcnk7CmRpZmYgLS1n aXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NvcGVDaGFpblNpZGViYXJQYW5lLmpz IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Njb3BlQ2hhaW5TaWRlYmFyUGFuZS5qcwpp bmRleCBjMzcxZTQyLi44MzU1N2U4IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvU2NvcGVDaGFpblNpZGViYXJQYW5lLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9TY29wZUNoYWluU2lkZWJhclBhbmUuanMKQEAgLTYzLDYgKzYzLDcgQEAgV2ViSW5z cGVjdG9yLlNjb3BlQ2hhaW5TaWRlYmFyUGFuZS5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAg ICAgICAgIHRpdGxlID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJDbG9zdXJlIik7CiAgICAgICAg ICAgICAgICAgZW1wdHlQbGFjZWhvbGRlciA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiTm8gVmFy aWFibGVzIik7CiAgICAgICAgICAgICAgICAgc3VidGl0bGUgPSBudWxsOworICAgICAgICAgICAg ICAgIGZvdW5kTG9jYWxTY29wZSA9IHRydWU7CiAgICAgICAgICAgICB9IGVsc2UgaWYgKGkgPT09 IChzY29wZUNoYWluLmxlbmd0aCAtIDEpKQogICAgICAgICAgICAgICAgIHRpdGxlID0gV2ViSW5z cGVjdG9yLlVJU3RyaW5nKCJHbG9iYWwiKTsKICAgICAgICAgICAgIGVsc2UgaWYgKHNjb3BlT2Jq ZWN0UHJveHkuaXNFbGVtZW50KQo= 38482 2009-08-24 09:06:08 -0700 2009-08-24 09:36:58 -0700 same with unused parameter cleanup scope_expand text/plain 1901 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDRiZDZmNS4uMzNlMDBjZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wOC0yNCAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCisKKyAgICAgICAgV2ViSW5zcGVjdG9yOiBPbmx5IGV4cGFuZCBsb2NhbCBzY29w ZSB3aGVuIGhpdHRpbmcgdGhlIGJyZWFrCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI4Njc4CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L1Njb3BlQ2hhaW5TaWRlYmFyUGFuZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TY29wZUNo YWluU2lkZWJhclBhbmUucHJvdG90eXBlLnVwZGF0ZSk6CisKIDIwMDktMDgtMTcgIE1hcnRpbiBS b2JpbnNvbiAgPG1hcnRpbi5qYW1lcy5yb2JpbnNvbkBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0luamVjdGVkU2NyaXB0LmpzCmluZGV4IDBhMGNiMDguLjFjMDI5YzMgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcworKysgYi9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKQEAgLTUzNCw3ICs1MzQsNyBA QCBJbmplY3RlZFNjcmlwdC5hZGRJbnNwZWN0ZWROb2RlID0gZnVuY3Rpb24obm9kZUlkKQogICAg IHJldHVybiB0cnVlOwogfQogCi1JbmplY3RlZFNjcmlwdC5wZXJmb3JtU2VhcmNoID0gZnVuY3Rp b24od2hpdGVzcGFjZVRyaW1tZWRRdWVyeSwgc2VhcmNoUmVzdWx0c1Byb3BlcnR5KQorSW5qZWN0 ZWRTY3JpcHQucGVyZm9ybVNlYXJjaCA9IGZ1bmN0aW9uKHdoaXRlc3BhY2VUcmltbWVkUXVlcnkp CiB7CiAgICAgdmFyIHRhZ05hbWVRdWVyeSA9IHdoaXRlc3BhY2VUcmltbWVkUXVlcnk7CiAgICAg dmFyIGF0dHJpYnV0ZU5hbWVRdWVyeSA9IHdoaXRlc3BhY2VUcmltbWVkUXVlcnk7CmRpZmYgLS1n aXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NvcGVDaGFpblNpZGViYXJQYW5lLmpz IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Njb3BlQ2hhaW5TaWRlYmFyUGFuZS5qcwpp bmRleCBjMzcxZTQyLi44MzU1N2U4IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvU2NvcGVDaGFpblNpZGViYXJQYW5lLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9TY29wZUNoYWluU2lkZWJhclBhbmUuanMKQEAgLTYzLDYgKzYzLDcgQEAgV2ViSW5z cGVjdG9yLlNjb3BlQ2hhaW5TaWRlYmFyUGFuZS5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAg ICAgICAgIHRpdGxlID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJDbG9zdXJlIik7CiAgICAgICAg ICAgICAgICAgZW1wdHlQbGFjZWhvbGRlciA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiTm8gVmFy aWFibGVzIik7CiAgICAgICAgICAgICAgICAgc3VidGl0bGUgPSBudWxsOworICAgICAgICAgICAg ICAgIGZvdW5kTG9jYWxTY29wZSA9IHRydWU7CiAgICAgICAgICAgICB9IGVsc2UgaWYgKGkgPT09 IChzY29wZUNoYWluLmxlbmd0aCAtIDEpKQogICAgICAgICAgICAgICAgIHRpdGxlID0gV2ViSW5z cGVjdG9yLlVJU3RyaW5nKCJHbG9iYWwiKTsKICAgICAgICAgICAgIGVsc2UgaWYgKHNjb3BlT2Jq ZWN0UHJveHkuaXNFbGVtZW50KQo= 38492 2009-08-24 12:22:57 -0700 2009-08-24 12:59:02 -0700 second part of the fix local_scope text/plain 1636 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTU3ZmY5Mi4uNjExM2JiZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxNyBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IFRp bW90aHkgSGF0Y2hlci4KIAorICAgICAgICBXZWJJbnNwZWN0b3I6IERvIGV4cGFuZCBsb2NhbCBz Y29wZSB3aGVuIGhpdHRpbmcgdGhlIGJyZWFrLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODY3OAorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9TY29wZUNoYWluU2lkZWJhclBhbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2Nv cGVDaGFpblNpZGViYXJQYW5lLnByb3RvdHlwZS51cGRhdGUpOgorCisyMDA5LTA4LTI0ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IFRpbW90aHkgSGF0Y2hlci4KKwogICAgICAgICBXZWJJbnNwZWN0b3I6IFNpbXBsaWZ5IGZpbmRU cmVlRWxlbWVudCBjb2RlLCBnZXQgcmlkIG9mIHBvdGVudGlhbCBpbmZpbml0ZSBsb29wLgogCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODY4MApkaWZm IC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Njb3BlQ2hhaW5TaWRlYmFyUGFu ZS5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY29wZUNoYWluU2lkZWJhclBhbmUu anMKaW5kZXggODM1NTdlOC4uMzg3NTMyNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1Njb3BlQ2hhaW5TaWRlYmFyUGFuZS5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvU2NvcGVDaGFpblNpZGViYXJQYW5lLmpzCkBAIC01Miw3ICs1Miw2IEBAIFdl Ykluc3BlY3Rvci5TY29wZUNoYWluU2lkZWJhclBhbmUucHJvdG90eXBlID0gewogICAgICAgICAg ICAgdmFyIHRpdGxlID0gbnVsbDsKICAgICAgICAgICAgIHZhciBzdWJ0aXRsZSA9IHNjb3BlT2Jq ZWN0UHJveHkuZGVzY3JpcHRpb247CiAgICAgICAgICAgICB2YXIgZW1wdHlQbGFjZWhvbGRlciA9 IG51bGw7Ci0gICAgICAgICAgICB2YXIgbG9jYWxTY29wZSA9IGZhbHNlOwogICAgICAgICAgICAg dmFyIGV4dHJhUHJvcGVydGllcyA9IG51bGw7CiAKICAgICAgICAgICAgIGlmIChzY29wZU9iamVj dFByb3h5LmlzTG9jYWwpIHsKQEAgLTgwLDcgKzc5LDcgQEAgV2ViSW5zcGVjdG9yLlNjb3BlQ2hh aW5TaWRlYmFyUGFuZS5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICBzZWN0aW9uLmVkaXRJblNl bGVjdGVkQ2FsbEZyYW1lV2hlblBhdXNlZCA9IHRydWU7CiAgICAgICAgICAgICBzZWN0aW9uLnBh bmUgPSB0aGlzOwogCi0gICAgICAgICAgICBpZiAoIWZvdW5kTG9jYWxTY29wZSB8fCBsb2NhbFNj b3BlKQorICAgICAgICAgICAgaWYgKCFmb3VuZExvY2FsU2NvcGUgfHwgc2NvcGVPYmplY3RQcm94 eS5pc0xvY2FsKQogICAgICAgICAgICAgICAgIHNlY3Rpb24uZXhwYW5kZWQgPSB0cnVlOwogCiAg ICAgICAgICAgICB0aGlzLnNlY3Rpb25zLnB1c2goc2VjdGlvbik7Cg==