28673 2009-08-23 17:12:56 -0700 Modifying <text rotate=""> doesn't clear the corresponding SVGAnimatedNumberList 2009-08-24 11:35:30 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 heycam webkit-unassigned eric oldest_to_newest 142260 0 heycam 2009-08-23 17:12:56 -0700 When script modifies the rotate="" attribute on a <text> (or <tspan>, etc.) element, the baseVal of the SVGAnimatedNumberList that corresponds to the attribute is not cleared before the attribute is re-parsed. E.g.: <text id="t" rotate="10 20 30"/> <script> t = document.getElementById('t'); l = t.rotate.baseVal; t.setAttribute('rotate', '40 50'); assert(l.numberOfItems == 2); // should be 2 but it's 5 </script> 142261 1 38462 heycam 2009-08-23 17:24:28 -0700 Created attachment 38462 Fix and test 142272 2 38462 darin 2009-08-23 22:20:52 -0700 Comment on attachment 38462 Fix and test > + * svg/dom/resources/text-rotate-live.js: Added. > + (getRotate): > + (getAndSetRotate): If you're not commenting on these functions individually and the file is new, then there's no need to leave this list of functions in the change log. The idea of prepare-ChangeLog is that it helps you write the ChangeLog entry, not that you should use that it generates as-is. The test code doesn't follow our usual brace style. Open braces for functions go on their own lines. Single line for loop bodies don't get braces around them. I would have put the "var" for the "i" variable inside the for loop. I believe the function results could be arrays rather than strings -- the shouldBe macro knows how to check arrays for equality. We don't use "get" in the names of functions that simply return results. None of these are significant issues, r=me on this patch as it is. 142274 3 heycam 2009-08-23 22:30:10 -0700 (In reply to comment #2) > If you're not commenting on these functions individually and the file is new, > then there's no need to leave this list of functions in the change log. The > idea of prepare-ChangeLog is that it helps you write the ChangeLog entry, not > that you should use that it generates as-is. I will keep that in mind for future patches. > The test code doesn't follow our usual brace style. OK. I see there's no mention of JS style in http://webkit.org/coding/coding-style.html but I'll admit I didn't check it before writing the code. > Open braces for functions > go on their own lines. Single line for loop bodies don't get braces around > them. I would have put the "var" for the "i" variable inside the for loop. I used to too, but now tend to put vars at the top of functions to emphasise that their scope is indeed the whole function and not just the loop. > I believe the function results could be arrays rather than strings -- the > shouldBe macro knows how to check arrays for equality. Acknowledged. I didn't look up shouldBe to see exactly what it was checking; I just copied another test that was doing string comparisons and thought that it was just safer to do that. > We don't use "get" in the names of functions that simply return results. I guess that's Java style rubbing off on me. :) > None of these are significant issues, r=me on this patch as it is. Thanks! 142343 4 38462 eric 2009-08-24 11:25:22 -0700 Comment on attachment 38462 Fix and test Looks good to me too. I wonder if other "parse" implementations are missing a clear() call. 142347 5 38462 eric 2009-08-24 11:35:28 -0700 Comment on attachment 38462 Fix and test Clearing flags on attachment: 38462 Committed r47720: <http://trac.webkit.org/changeset/47720> 142348 6 eric 2009-08-24 11:35:30 -0700 All reviewed patches have been landed. Closing bug. 38462 2009-08-23 17:24:28 -0700 2009-08-24 11:35:28 -0700 Fix and test 28673.patch text/plain 4234 heycam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzY5NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDgtMjMgIENhbWVyb24gTWNDb3JtYWNrICA8Y2FtQG1jYy5p ZC5hdT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBN b2RpZnlpbmcgPHRleHQgcm90YXRlPSIiPiBkb2Vzbid0IGNsZWFyIHRoZSBjb3JyZXNwb25kaW5n IFNWR0FuaW1hdGVkTnVtYmVyTGlzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Mjg2NzMKKworICAgICAgICBUZXN0OiBzdmcvZG9tL3RleHQtcm90YXRl LWxpdmUuaHRtbAorCisgICAgICAgICogc3ZnL1NWR051bWJlckxpc3QuY3BwOgorICAgICAgICAo V2ViQ29yZTo6U1ZHTnVtYmVyTGlzdDo6cGFyc2UpOiBDbGVhciB0aGUgbGlzdCBiZWZvcmUgYWRk aW5nIHRoZSBwYXJzZWQKKyAgICAgICAgbnVtYmVycy4KKwogMjAwOS0wOC0yMyAgSm9zZXBoIFBl Y29yYXJvICA8am9lcGVja0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRpbW90 aHkgSGF0Y2hlci4KSW5kZXg6IFdlYkNvcmUvc3ZnL1NWR051bWJlckxpc3QuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvc3ZnL1NWR051bWJlckxpc3QuY3BwCShyZXZpc2lvbiA0NzY5NikKKysr IFdlYkNvcmUvc3ZnL1NWR051bWJlckxpc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MSw2ICs0 MSw3IEBAIFNWR051bWJlckxpc3Q6On5TVkdOdW1iZXJMaXN0KCkKIHZvaWQgU1ZHTnVtYmVyTGlz dDo6cGFyc2UoY29uc3QgU3RyaW5nJiB2YWx1ZSkKIHsKICAgICBFeGNlcHRpb25Db2RlIGVjID0g MDsKKyAgICBjbGVhcihlYyk7CiAKICAgICBmbG9hdCBudW1iZXIgPSAwLjBmOwogICAgCkluZGV4 OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCShyZXZpc2lvbiA0NzY5NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDA5LTA4LTIzICBDYW1lcm9uIE1jQ29ybWFjayAgPGNh bUBtY2MuaWQuYXU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTW9kaWZ5aW5nIDx0ZXh0IHJvdGF0ZT0iIj4gZG9lc24ndCBjbGVhciB0aGUgY29ycmVz cG9uZGluZyBTVkdBbmltYXRlZE51bWJlckxpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTI4NjczCisKKyAgICAgICAgKiBzdmcvZG9tL3Jlc291cmNl cy90ZXh0LXJvdGF0ZS1saXZlLmpzOiBBZGRlZC4KKyAgICAgICAgKGdldFJvdGF0ZSk6CisgICAg ICAgIChnZXRBbmRTZXRSb3RhdGUpOgorICAgICAgICAqIHN2Zy9kb20vdGV4dC1yb3RhdGUtbGl2 ZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHN2Zy9kb20vdGV4dC1yb3RhdGUtbGl2 ZS5odG1sOiBBZGRlZC4KKwogMjAwOS0wOC0yMyAgSmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9u em9Ad2Via2l0Lm9yZz4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQuIFNraXAgbmV3IHRlc3RzIGZy b20KSW5kZXg6IExheW91dFRlc3RzL3N2Zy9kb20vdGV4dC1yb3RhdGUtbGl2ZS1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3ZnL2RvbS90ZXh0LXJvdGF0ZS1saXZlLWV4 cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3N2Zy9kb20vdGV4dC1yb3Rh dGUtbGl2ZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKK1RoaXMg dGVzdHMgdGhhdCB0aGUgU1ZHQW5pbWF0ZWROdW1iZXJMaXN0IHJldHVybmVkIGJ5IFNWR1RleHRQ b3NpdGlvbmluZ0VsZW1lbnQucm90YXRlIGlzIGxpdmUuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxs IHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBM RVRFIi4KKworCitQQVNTIGdldFJvdGF0ZSgpIGlzICcxMCwyMCwzMCcKK1BBU1MgZ2V0QW5kU2V0 Um90YXRlKCc0MCA1MCcpIGlzICc0MCw1MCcKK1BBU1MgZ2V0QW5kU2V0Um90YXRlKCc2ZTEnKSBp cyAnNjAnCitQQVNTIGdldEFuZFNldFJvdGF0ZSgnLS41ICAsIDQwRS0wJykgaXMgJy0wLjUsNDAn CitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRl eDogTGF5b3V0VGVzdHMvc3ZnL2RvbS90ZXh0LXJvdGF0ZS1saXZlLmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvc3ZnL2RvbS90ZXh0LXJvdGF0ZS1saXZlLmh0bWwJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9zdmcvZG9tL3RleHQtcm90YXRlLWxpdmUuaHRtbAkocmV2aXNpb24g MCkKQEAgLTAsMCArMSwxMyBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQg SFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0i Li4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9 Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48 L2Rpdj4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvdGV4dC1yb3RhdGUtbGl2ZS5qcyI+PC9zY3Jp cHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0Lmpz Ij48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL3N2Zy9kb20v cmVzb3VyY2VzL3RleHQtcm90YXRlLWxpdmUuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv c3ZnL2RvbS9yZXNvdXJjZXMvdGV4dC1yb3RhdGUtbGl2ZS5qcwkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL3N2Zy9kb20vcmVzb3VyY2VzL3RleHQtcm90YXRlLWxpdmUuanMJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsMjYgQEAKK2Rlc2NyaXB0aW9uKCJUaGlzIHRlc3RzIHRoYXQgdGhlIFNW R0FuaW1hdGVkTnVtYmVyTGlzdCByZXR1cm5lZCBieSBTVkdUZXh0UG9zaXRpb25pbmdFbGVtZW50 LnJvdGF0ZSBpcyBsaXZlLiIpOworCit2YXIgdGV4dEVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50TlMoImh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiwgInRleHQiKTsKK3RleHRFbGVt ZW50LnNldEF0dHJpYnV0ZSgicm90YXRlIiwgIjEwIDIwIDMwIik7CisKK3ZhciByb3RhdGUgPSB0 ZXh0RWxlbWVudC5yb3RhdGUuYmFzZVZhbDsKKworZnVuY3Rpb24gZ2V0Um90YXRlKCkgeworICAg IHZhciBpLCBhID0gW107CisgICAgZm9yIChpID0gMDsgaSA8IHJvdGF0ZS5udW1iZXJPZkl0ZW1z OyBpKyspIHsKKyAgICAgICAgYS5wdXNoKHJvdGF0ZS5nZXRJdGVtKGkpLnZhbHVlKTsKKyAgICB9 CisgICAgcmV0dXJuIFN0cmluZyhhKTsKK30KKworZnVuY3Rpb24gZ2V0QW5kU2V0Um90YXRlKHMp IHsKKyAgICB0ZXh0RWxlbWVudC5zZXRBdHRyaWJ1dGUoInJvdGF0ZSIsIHMpOworICAgIHJldHVy biBnZXRSb3RhdGUoKTsKK30KKworc2hvdWxkQmUoImdldFJvdGF0ZSgpIiwgIicxMCwyMCwzMCci KTsKK3Nob3VsZEJlKCJnZXRBbmRTZXRSb3RhdGUoJzQwIDUwJykiLCAiJzQwLDUwJyIpOworc2hv dWxkQmUoImdldEFuZFNldFJvdGF0ZSgnNmUxJykiLCAiJzYwJyIpOworc2hvdWxkQmUoImdldEFu ZFNldFJvdGF0ZSgnLS41ICAsIDQwRS0wJykiLCAiJy0wLjUsNDAnIik7CisKK3N1Y2Nlc3NmdWxs eVBhcnNlZCA9IHRydWU7Cg==