28670 2009-08-23 13:58:32 -0700 [Chromium] Multi-value select boxes cannot do non-contiguous selection 2009-08-26 06:56:28 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://code.google.com/p/chromium/issues/detail?id=15998 P2 Normal --- 0 rsesek webkit-unassigned darin eric fishd playmobil sam oldest_to_newest 142241 0 rsesek 2009-08-23 13:58:32 -0700 On Chromium Mac, you cannot perform non-contiguous selection on a multi-value list box in the normal Mac way. On the Mac, you do this kind of selection by holding down the Command key; on Windows, you do this with the Control key. In SelectElement.cpp, the #if guard that determines which of these keys to respect uses PLATFORM(MAC), which is always false for Chromium. The fix is to use PLATFORM(DARWIN). Patch coming shortly. 142245 1 38458 rsesek 2009-08-23 14:31:00 -0700 Created attachment 38458 Fix 142249 2 38458 playmobil 2009-08-23 15:21:31 -0700 Comment on attachment 38458 Fix WebKit convention is to cc relevant parties and not to assign specific reviewers, thus I'm moving Darin to the cc list. 142257 3 sam 2009-08-23 16:40:20 -0700 This does not seem like a Darwin level idea, it is very specific to the Mac. Is this how we have been solving other cases similar to this? 142258 4 rsesek 2009-08-23 16:53:05 -0700 We use at the top of the file: #if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)) I spoke to Jeremy about hit and he thought we could reduce it to just PLATFORM(DARWIN). 142269 5 darin 2009-08-23 22:13:23 -0700 (In reply to comment #4) > We use at the top of the file: > > #if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)) > > I spoke to Jeremy about hit and he thought we could reduce it to just > PLATFORM(DARWIN). Mechanically that's OK, but it's not exactly the right concept. PLATFORM(DARWIN) is really supposed to be an OS-level switch like PLATFORM(WINOS) that tells you what low level OS is on the target machine. PLATFORM(DARWIN) means Apple's Unix variant with things like frameworks and certain libraries expected to be installed. This seems to be more about which style of user interface we want. Chromium creates a non-Mac platform that wants to follow Mac user interface style because while it's virtual it is on a Mac. To make that clear I think we'll probably need a different macro in the long run. Short run, we might be OK saying PLATFORM(DARWIN) here unless there's some other port running with PLATFORM(DARWIN) defined that doesn't want this behavior. For example, it's not too farfetched to imagine trouble if you were compiling for QT or GTK on a Mac. 142302 6 rsesek 2009-08-24 05:28:47 -0700 (In reply to comment #5) > Mechanically that's OK, but it's not exactly the right concept. > PLATFORM(DARWIN) is really supposed to be an OS-level switch like > PLATFORM(WINOS) that tells you what low level OS is on the target machine. > PLATFORM(DARWIN) means Apple's Unix variant with things like frameworks and > certain libraries expected to be installed. > > This seems to be more about which style of user interface we want. Chromium > creates a non-Mac platform that wants to follow Mac user interface style > because while it's virtual it is on a Mac. > > To make that clear I think we'll probably need a different macro in the long > run. Short run, we might be OK saying PLATFORM(DARWIN) here unless there's some > other port running with PLATFORM(DARWIN) defined that doesn't want this > behavior. For example, it's not too farfetched to imagine trouble if you were > compiling for QT or GTK on a Mac. Then to be on the safe side, I think the answer is to use, like we do earlier in the same file, PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)). From what I've discovered on mailing lists, PLATFORM(MAC) is used pretty much for Safari on OS X. Perhaps the right answer long-term is to make a PLATFORM(SAFARI) so that PLATFORM(MAC) can be used in instances like this. 142303 7 38478 rsesek 2009-08-24 05:33:59 -0700 Created attachment 38478 Adjusted condition per comment 6 142329 8 darin 2009-08-24 10:47:37 -0700 (In reply to comment #6) > From what I've discovered on mailing lists, PLATFORM(MAC) is used pretty much > for Safari on OS X. Perhaps the right answer long-term is to make a > PLATFORM(SAFARI) so that PLATFORM(MAC) can be used in instances like this. This is a great oversimplification and would not be correct. For example, Safari works on Windows. And tons of Mac OS X applications use the PLATFORM(MAC) version of WebKit, not just Safari. PLATFORM(MAC) is about having WebKit on top of Mac OS X frameworks like AppKit. The Chromium port is peculiar because it's WebKit on Mac OS X, but striving to not be on top of something like AppKit because of the particular architecture of the Chrome browser, and instead of being on top of the OS frameworks, it's on top a special Chromium layer. We do have a plan to fix the platform macros and make various more specific names, which should solve this problem. Maciej Stachowiak sent mail to webkit-dev a couple months ago about it. But PLATFORM(SAFARI) would be terrible and a step in the wrong direction! 142350 9 playmobil 2009-08-24 11:39:19 -0700 Robert: The discussion of the right macros to use for cases like this seems to come up every time we need some code to be used on both Chrome/OS X & Safari since the current situation is sub-optimal. I think in the long term we need to fix this but I think the discussion of what that solution is belongs in a separate bug or on webkit-dev. Per-Darin's comment could you resubmit your first patch and use PLATFORM(DARWIN). Sam: Up till now we've resolved these issues by changing these to PLATFORM(DARWIN). Darin & Sam: Thanks for your comments, I don't want to sound like we don't care about doing the right thing for this, we most certain do want a good long term solution here! But as mentioned above, I think we should discuss this in another scope. 142358 10 38489 rsesek 2009-08-24 11:56:13 -0700 Created attachment 38489 Using just PLATFORM(DARWIN) 142366 11 38489 eric 2009-08-24 12:28:51 -0700 Comment on attachment 38489 Using just PLATFORM(DARWIN) I think this change looks fine. However some might disagree with me, given how contentious and mis-understood the PLATFORM #defines have been in the pass. I really hope that Maciej delivers his grand re-write soon to end all this needless confusion. :) 142393 12 38489 eric 2009-08-24 13:29:03 -0700 Comment on attachment 38489 Using just PLATFORM(DARWIN) Rejecting patch 38489 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None 142396 13 38489 eric 2009-08-24 13:40:07 -0700 Comment on attachment 38489 Using just PLATFORM(DARWIN) commit-queue bug. checkin occured to the ChangeLog file while the commit-queue was processing this. 142398 14 mrowe 2009-08-24 13:44:52 -0700 PLATFORM(DARWIN) really isn't the right macro to be using here. The desired is specific to the behavior of the Mac OS X interface. It may not make sense for an X11 application on Mac OS X, or directly on top of Darwin. 142400 15 38489 eric 2009-08-24 13:47:19 -0700 Comment on attachment 38489 Using just PLATFORM(DARWIN) Rejecting patch 38489 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None 142402 16 38489 mrowe 2009-08-24 13:51:43 -0700 Comment on attachment 38489 Using just PLATFORM(DARWIN) Clearing r+ since this is not correct. 142403 17 playmobil 2009-08-24 13:55:09 -0700 Mark: What do you think the right #ifdef is here? 142423 18 fishd 2009-08-24 14:57:05 -0700 Here is what we have been using thus far: #if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)) If that is not correct, we should discuss it separately, and come up with a better solution to apply globally. 142460 19 mrowe 2009-08-24 16:51:45 -0700 (In reply to comment #18) > Here is what we have been using thus far: > > #if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && PLATFORM(DARWIN)) > > If that is not correct, we should discuss it separately, and come up with a > better solution to apply globally. While not perfect, this seems more reasonable to me. 142462 20 38478 mrowe 2009-08-24 16:53:20 -0700 Comment on attachment 38478 Adjusted condition per comment 6 > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 47695) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,20 @@ > +2009-08-23 Robert Sesek <rsesek@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + [Chromium] Multi-value select boxes cannot do non-contiguous selection on Mac > + https://bugs.webkit.org/show_bug.cgi?id=28670 > + > + Change the condition regarding the key modifier check for non-contiguous > + selection on a multi-value select from PLATFORM(MAC) to PLATFORM(DARWIN), so > + that Chromium works as expected on Mac. This doesn't describe the change that was actually made, so it'll need to be updated. The actual code change looks fine. r=me 142464 21 38514 rsesek 2009-08-24 17:03:58 -0700 Created attachment 38514 FINAL- Revised Changelog Thanks, Mark. I've added a new patch with the revised Changelog. 142720 22 eric 2009-08-25 16:15:09 -0700 Is the final patch supposed to be marked for review? 142723 23 38514 rsesek 2009-08-25 16:20:40 -0700 Comment on attachment 38514 FINAL- Revised Changelog Oops, you're right. Flag set, now. 142821 24 38478 eric 2009-08-26 03:17:01 -0700 Comment on attachment 38478 Adjusted condition per comment 6 obsoleting this patch since a new one has been posted. 142822 25 38514 eric 2009-08-26 03:17:39 -0700 Comment on attachment 38514 FINAL- Revised Changelog LGTM. 142845 26 38514 eric 2009-08-26 06:56:23 -0700 Comment on attachment 38514 FINAL- Revised Changelog Clearing flags on attachment: 38514 Committed r47777: <http://trac.webkit.org/changeset/47777> 142846 27 eric 2009-08-26 06:56:28 -0700 All reviewed patches have been landed. Closing bug. 38458 2009-08-23 14:31:00 -0700 2009-08-24 05:33:59 -0700 Fix bug-28670.patch text/plain 1501 rsesek SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzY5NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDgtMjMgIFJvYmVydCBTZXNlayAgPHJzZXNla0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W0Nocm9taXVtXSBNdWx0aS12YWx1ZSBzZWxlY3QgYm94ZXMgY2Fubm90IGRvIG5vbi1jb250aWd1 b3VzIHNlbGVjdGlvbiBvbiBNYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI4NjcwCisKKyAgICAgICAgQ2hhbmdlIHRoZSBjb25kaXRpb24gcmVnYXJk aW5nIHRoZSBrZXkgbW9kaWZpZXIgY2hlY2sgZm9yIG5vbi1jb250aWd1b3VzCisgICAgICAgIHNl bGVjdGlvbiBvbiBhIG11bHRpLXZhbHVlIHNlbGVjdCBmcm9tIFBMQVRGT1JNKE1BQykgdG8gUExB VEZPUk0oREFSV0lOKSwgc28KKyAgICAgICAgdGhhdCBDaHJvbWl1bSB3b3JrcyBhcyBleHBlY3Rl ZCBvbiBNYWMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIHBhdGNoIG9ubHkgY2hhbmdl cyB0aGUgY29uZGl0aW9uIG9uIHdoaWNoIGEgY2VydGFpbiBtb3VzZQorICAgICAgICBldmVudCBt b2RpZmllciBrZXkgaXMgdXNlZC4KKworICAgICAgICAqIC4uLy4uLy4uL2RvbS9TZWxlY3RFbGVt ZW50LmNwcDoKKyAgICAgICAgKFNlbGVjdEVsZW1lbnQ6Omxpc3RCb3hEZWZhdWx0RXZlbnRIYW5k bGVyKToKKwogMjAwOS0wOC0yMyAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCkluZGV4OiBXZWJDb3Jl L2RvbS9TZWxlY3RFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9TZWxlY3RF bGVtZW50LmNwcAkocmV2aXNpb24gNDc2NDYpCisrKyBXZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjc2LDcgKzY3Niw3IEBAIHZvaWQgU2VsZWN0RWxlbWVu dDo6bGlzdEJveERlZmF1bHRFdmVudEgKICAgICAgICAgICAgIGRhdGEuc2V0QWN0aXZlU2VsZWN0 aW9uU3RhdGUodHJ1ZSk7CiAgICAgICAgICAgICAKICAgICAgICAgICAgIGJvb2wgbXVsdGlTZWxl Y3RLZXlQcmVzc2VkID0gZmFsc2U7Ci0jaWYgUExBVEZPUk0oTUFDKQorI2lmIFBMQVRGT1JNKERB UldJTikKICAgICAgICAgICAgIG11bHRpU2VsZWN0S2V5UHJlc3NlZCA9IG1vdXNlRXZlbnQtPm1l dGFLZXkoKTsKICNlbHNlCiAgICAgICAgICAgICBtdWx0aVNlbGVjdEtleVByZXNzZWQgPSBtb3Vz ZUV2ZW50LT5jdHJsS2V5KCk7Cg== 38478 2009-08-24 05:33:59 -0700 2009-08-26 03:17:01 -0700 Adjusted condition per comment 6 bug-28670.patch text/plain 1542 rsesek SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzY5NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDgtMjMgIFJvYmVydCBTZXNlayAgPHJzZXNla0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W0Nocm9taXVtXSBNdWx0aS12YWx1ZSBzZWxlY3QgYm94ZXMgY2Fubm90IGRvIG5vbi1jb250aWd1 b3VzIHNlbGVjdGlvbiBvbiBNYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI4NjcwCisKKyAgICAgICAgQ2hhbmdlIHRoZSBjb25kaXRpb24gcmVnYXJk aW5nIHRoZSBrZXkgbW9kaWZpZXIgY2hlY2sgZm9yIG5vbi1jb250aWd1b3VzCisgICAgICAgIHNl bGVjdGlvbiBvbiBhIG11bHRpLXZhbHVlIHNlbGVjdCBmcm9tIFBMQVRGT1JNKE1BQykgdG8gUExB VEZPUk0oREFSV0lOKSwgc28KKyAgICAgICAgdGhhdCBDaHJvbWl1bSB3b3JrcyBhcyBleHBlY3Rl ZCBvbiBNYWMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIHBhdGNoIG9ubHkgY2hhbmdl cyB0aGUgY29uZGl0aW9uIG9uIHdoaWNoIGEgY2VydGFpbiBtb3VzZQorICAgICAgICBldmVudCBt b2RpZmllciBrZXkgaXMgdXNlZC4KKworICAgICAgICAqIGRvbS9TZWxlY3RFbGVtZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdEVsZW1lbnQ6Omxpc3RCb3hEZWZhdWx0RXZlbnRIYW5k bGVyKToKKwogMjAwOS0wOC0yMyAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCkluZGV4OiBXZWJDb3Jl L2RvbS9TZWxlY3RFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9TZWxlY3RF bGVtZW50LmNwcAkocmV2aXNpb24gNDc2NDYpCisrKyBXZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjc2LDcgKzY3Niw3IEBAIHZvaWQgU2VsZWN0RWxlbWVu dDo6bGlzdEJveERlZmF1bHRFdmVudEgKICAgICAgICAgICAgIGRhdGEuc2V0QWN0aXZlU2VsZWN0 aW9uU3RhdGUodHJ1ZSk7CiAgICAgICAgICAgICAKICAgICAgICAgICAgIGJvb2wgbXVsdGlTZWxl Y3RLZXlQcmVzc2VkID0gZmFsc2U7Ci0jaWYgUExBVEZPUk0oTUFDKQorI2lmIFBMQVRGT1JNKE1B QykgfHwgKFBMQVRGT1JNKENIUk9NSVVNKSAmJiBQTEFURk9STShEQVJXSU4pKQogICAgICAgICAg ICAgbXVsdGlTZWxlY3RLZXlQcmVzc2VkID0gbW91c2VFdmVudC0+bWV0YUtleSgpOwogI2Vsc2UK ICAgICAgICAgICAgIG11bHRpU2VsZWN0S2V5UHJlc3NlZCA9IG1vdXNlRXZlbnQtPmN0cmxLZXko KTsK 38489 2009-08-24 11:56:13 -0700 2009-08-24 14:59:01 -0700 Using just PLATFORM(DARWIN) bug-28670.patch text/plain 1501 rsesek SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzY5NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDgtMjQgIFJvYmVydCBTZXNlayAgPHJzZXNla0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W0Nocm9taXVtXSBNdWx0aS12YWx1ZSBzZWxlY3QgYm94ZXMgY2Fubm90IGRvIG5vbi1jb250aWd1 b3VzIHNlbGVjdGlvbiBvbiBNYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI4NjcwCisKKyAgICAgICAgQ2hhbmdlIHRoZSBjb25kaXRpb24gcmVnYXJk aW5nIHRoZSBrZXkgbW9kaWZpZXIgY2hlY2sgZm9yIG5vbi1jb250aWd1b3VzCisgICAgICAgIHNl bGVjdGlvbiBvbiBhIG11bHRpLXZhbHVlIHNlbGVjdCBmcm9tIFBMQVRGT1JNKE1BQykgdG8gUExB VEZPUk0oREFSV0lOKSwgc28KKyAgICAgICAgdGhhdCBDaHJvbWl1bSB3b3JrcyBhcyBleHBlY3Rl ZCBvbiBNYWMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIHBhdGNoIG9ubHkgY2hhbmdl cyB0aGUgY29uZGl0aW9uIG9uIHdoaWNoIGEgY2VydGFpbiBtb3VzZQorICAgICAgICBldmVudCBt b2RpZmllciBrZXkgaXMgdXNlZC4KKworICAgICAgICAqIGRvbS9TZWxlY3RFbGVtZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdEVsZW1lbnQ6Omxpc3RCb3hEZWZhdWx0RXZlbnRIYW5k bGVyKToKKwogMjAwOS0wOC0yMyAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCkluZGV4OiBXZWJDb3Jl L2RvbS9TZWxlY3RFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9TZWxlY3RF bGVtZW50LmNwcAkocmV2aXNpb24gNDc2NDYpCisrKyBXZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjc2LDcgKzY3Niw3IEBAIHZvaWQgU2VsZWN0RWxlbWVu dDo6bGlzdEJveERlZmF1bHRFdmVudEgKICAgICAgICAgICAgIGRhdGEuc2V0QWN0aXZlU2VsZWN0 aW9uU3RhdGUodHJ1ZSk7CiAgICAgICAgICAgICAKICAgICAgICAgICAgIGJvb2wgbXVsdGlTZWxl Y3RLZXlQcmVzc2VkID0gZmFsc2U7Ci0jaWYgUExBVEZPUk0oTUFDKQorI2lmIFBMQVRGT1JNKERB UldJTikKICAgICAgICAgICAgIG11bHRpU2VsZWN0S2V5UHJlc3NlZCA9IG1vdXNlRXZlbnQtPm1l dGFLZXkoKTsKICNlbHNlCiAgICAgICAgICAgICBtdWx0aVNlbGVjdEtleVByZXNzZWQgPSBtb3Vz ZUV2ZW50LT5jdHJsS2V5KCk7Cg== 38514 2009-08-24 17:03:58 -0700 2009-08-26 06:56:23 -0700 FINAL- Revised Changelog bug-28670.patch text/plain 1543 rsesek SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzY5NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMDgtMjQgIFJvYmVydCBTZXNlayAgPHJzZXNla0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W0Nocm9taXVtXSBNdWx0aS12YWx1ZSBzZWxlY3QgYm94ZXMgY2Fubm90IGRvIG5vbi1jb250aWd1 b3VzIHNlbGVjdGlvbiBvbiBNYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI4NjcwCisKKyAgICAgICAgQ2hhbmdlIHRoZSBjb25kaXRpb24gcmVnYXJk aW5nIHRoZSBrZXkgbW9kaWZpZXIgY2hlY2sgZm9yIG5vbi1jb250aWd1b3VzCisgICAgICAgIHNl bGVjdGlvbiBvbiBhIG11bHRpLXZhbHVlIGxpc3QgZnJvbSBqdXN0IFBMQVRGT1JNKE1BQykgdG8K KyAgICAgICAgUExBVEZPUk0oTUFDKSB8fCAoUExBVEZPUk0oQ0hST01JVU0pICYmIFBMQVRGT1JN KERBUldJTikpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBwYXRjaCBvbmx5IGNoYW5n ZXMgdGhlIGNvbmRpdGlvbiBvbiB3aGljaCBhIGNlcnRhaW4gbW91c2UKKyAgICAgICAgZXZlbnQg bW9kaWZpZXIga2V5IGlzIHVzZWQuCisKKyAgICAgICAgKiBkb20vU2VsZWN0RWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3RFbGVtZW50OjpsaXN0Qm94RGVmYXVsdEV2ZW50SGFu ZGxlcik6CisKIDIwMDktMDgtMjMgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpJbmRleDogV2ViQ29y ZS9kb20vU2VsZWN0RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vU2VsZWN0 RWxlbWVudC5jcHAJKHJldmlzaW9uIDQ3NjQ2KQorKysgV2ViQ29yZS9kb20vU2VsZWN0RWxlbWVu dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY3Niw3ICs2NzYsNyBAQCB2b2lkIFNlbGVjdEVsZW1l bnQ6Omxpc3RCb3hEZWZhdWx0RXZlbnRICiAgICAgICAgICAgICBkYXRhLnNldEFjdGl2ZVNlbGVj dGlvblN0YXRlKHRydWUpOwogICAgICAgICAgICAgCiAgICAgICAgICAgICBib29sIG11bHRpU2Vs ZWN0S2V5UHJlc3NlZCA9IGZhbHNlOwotI2lmIFBMQVRGT1JNKE1BQykKKyNpZiBQTEFURk9STShN QUMpIHx8IChQTEFURk9STShDSFJPTUlVTSkgJiYgUExBVEZPUk0oREFSV0lOKSkKICAgICAgICAg ICAgIG11bHRpU2VsZWN0S2V5UHJlc3NlZCA9IG1vdXNlRXZlbnQtPm1ldGFLZXkoKTsKICNlbHNl CiAgICAgICAgICAgICBtdWx0aVNlbGVjdEtleVByZXNzZWQgPSBtb3VzZUV2ZW50LT5jdHJsS2V5 KCk7Cg==