28666 2009-08-23 00:25:17 -0700 Inspector: REGRESSION Formatting Function in Console is Abbreviated Too Often 2009-08-23 12:51:14 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck pfeldman aroben joepeck pfeldman timothy oldest_to_newest 142200 0 joepeck 2009-08-23 00:25:17 -0700 Current Behavior: > Math.sin function sin() { > var o = { a: Math.sin } undefined > o Object a: function sin() { > o.a function sin() { Expected Behavior: (From Safari 4.0.3) > Math.sin function sin() { [native code] } > var o = { a: Math.sin } undefined > o Object a: function sin() { > o.a function sin() { [native code] } The current behavior abbreviates too often (in fact all the time). Specifically when setting the "description" in InjectedScript.createProxyObject. Changing the Object.describe() call inside createProxyObject makes all of the examples above the unabbreviated style. Should abbreviation move out of Object.describe() and instead be used right before showing in the UI? 142215 1 pfeldman 2009-08-23 02:18:51 -0700 (In reply to comment #0) > The current behavior abbreviates too often (in fact all the time). > Specifically when setting the "description" in > InjectedScript.createProxyObject. Changing the Object.describe() call inside > createProxyObject makes all of the examples above the unabbreviated style. > Should abbreviation move out of Object.describe() and instead be used right > before showing in the UI? Thanks for reporting this. Passing information from the InjectedScript to the UI is going to be slow, especially after we add the JSON serialization there. So we don't want to push information that might not be needed for the UI. I think I just need to find the place where it got regressed and do no abbreviation there. Or do you want to investigate it? 142219 2 38451 pfeldman 2009-08-23 02:41:02 -0700 Created attachment 38451 patch 142229 3 joepeck 2009-08-23 07:48:44 -0700 This is the exact idea I thought of after I left this last night. Short and sweet. 142237 4 pfeldman 2009-08-23 12:51:14 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/InjectedScript.js Committed r47695 38451 2009-08-23 02:41:02 -0700 2009-08-23 12:31:56 -0700 patch abbreviate text/plain 2282 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTI5YWMxNS4uYzJlNzgzZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOC0yMyAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCisKKyAgICAgICAgSW5zcGVjdG9yOiBSRUdSRVNTSU9OIEZvcm1hdHRpbmcgRnVu Y3Rpb24gaW4gQ29uc29sZSBpcyBBYmJyZXZpYXRlZCBUb28gT2Z0ZW4KKworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg2NjYKKworICAgICAgICAqIGlu c3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanM6CisgICAgICAgIChJbmplY3RlZFNj cmlwdC5nZXRQcm9wZXJ0aWVzKToKKyAgICAgICAgKEluamVjdGVkU2NyaXB0LmNyZWF0ZVByb3h5 T2JqZWN0KToKKwogMjAwOS0wOC0yMSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCmRpZmYgLS1naXQg YS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMgYi9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKaW5kZXggNTk1YmZhYi4uYmFl NDRiNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2Ny aXB0LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5q cwpAQCAtNDQwLDcgKzQ0MCw3IEBAIEluamVjdGVkU2NyaXB0LmdldFByb3BlcnRpZXMgPSBmdW5j dGlvbihvYmplY3RQcm94eSwgaWdub3JlSGFzT3duUHJvcGVydHkpCiAgICAgICAgIHZhciBpc0dl dHRlciA9IG9iamVjdFsiX19sb29rdXBHZXR0ZXJfXyJdICYmIG9iamVjdC5fX2xvb2t1cEdldHRl cl9fKHByb3BlcnR5TmFtZSk7CiAgICAgICAgIGlmICghcHJvcGVydHkuaXNHZXR0ZXIpIHsKICAg ICAgICAgICAgIHZhciBjaGlsZE9iamVjdCA9IG9iamVjdFtwcm9wZXJ0eU5hbWVdOwotICAgICAg ICAgICAgdmFyIGNoaWxkT2JqZWN0UHJveHkgPSBuZXcgSW5qZWN0ZWRTY3JpcHQuY3JlYXRlUHJv eHlPYmplY3QoY2hpbGRPYmplY3QsIG9iamVjdFByb3h5Lm9iamVjdElkKTsKKyAgICAgICAgICAg IHZhciBjaGlsZE9iamVjdFByb3h5ID0gbmV3IEluamVjdGVkU2NyaXB0LmNyZWF0ZVByb3h5T2Jq ZWN0KGNoaWxkT2JqZWN0LCBvYmplY3RQcm94eS5vYmplY3RJZCwgdHJ1ZSk7CiAgICAgICAgICAg ICBjaGlsZE9iamVjdFByb3h5LnBhdGggPSBvYmplY3RQcm94eS5wYXRoID8gb2JqZWN0UHJveHku cGF0aC5zbGljZSgpIDogW107CiAgICAgICAgICAgICBjaGlsZE9iamVjdFByb3h5LnBhdGgucHVz aChwcm9wZXJ0eU5hbWUpOwogICAgICAgICAgICAgY2hpbGRPYmplY3RQcm94eS5wcm90b0RlcHRo ID0gb2JqZWN0UHJveHkucHJvdG9EZXB0aCB8fCAwOwpAQCAtOTI1LDcgKzkyNSw3IEBAIEluamVj dGVkU2NyaXB0LnB1c2hOb2RlVG9Gcm9udGVuZCA9IGZ1bmN0aW9uKG9iamVjdFByb3h5KQogfQog CiAvLyBDYWxsZWQgZnJvbSB3aXRoaW4gSW5zcGVjdG9yQ29udHJvbGxlciBvbiB0aGUgJ2luc3Bl Y3RlZCBwYWdlJyBzaWRlLgotSW5qZWN0ZWRTY3JpcHQuY3JlYXRlUHJveHlPYmplY3QgPSBmdW5j dGlvbihvYmplY3QsIG9iamVjdElkKQorSW5qZWN0ZWRTY3JpcHQuY3JlYXRlUHJveHlPYmplY3Qg PSBmdW5jdGlvbihvYmplY3QsIG9iamVjdElkLCBhYmJyZXZpYXRlKQogewogICAgIHZhciByZXN1 bHQgPSB7fTsKICAgICByZXN1bHQub2JqZWN0SWQgPSBvYmplY3RJZDsKQEAgLTkzOSw3ICs5Mzks NyBAQCBJbmplY3RlZFNjcmlwdC5jcmVhdGVQcm94eU9iamVjdCA9IGZ1bmN0aW9uKG9iamVjdCwg b2JqZWN0SWQpCiAgICAgICAgIH0KICAgICB9CiAgICAgdHJ5IHsKLSAgICAgICAgcmVzdWx0LmRl c2NyaXB0aW9uID0gT2JqZWN0LmRlc2NyaWJlKG9iamVjdCwgdHJ1ZSwgSW5qZWN0ZWRTY3JpcHQu X3dpbmRvdygpKTsKKyAgICAgICAgcmVzdWx0LmRlc2NyaXB0aW9uID0gT2JqZWN0LmRlc2NyaWJl KG9iamVjdCwgYWJicmV2aWF0ZSwgSW5qZWN0ZWRTY3JpcHQuX3dpbmRvdygpKTsKICAgICB9IGNh dGNoIChlKSB7CiAgICAgICAgIHJlc3VsdC5leGNlcHRpb24gPSBlLnRvU3RyaW5nKCk7CiAgICAg fQo=