28665 2009-08-22 23:53:59 -0700 Inspector: Throws an Error on "null" 2009-08-23 14:42:18 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned aroben eric joepeck pfeldman timothy oldest_to_newest 142193 0 joepeck 2009-08-22 23:53:59 -0700 The Console is throwing an error on "null". This seems to happen because after the result of an eval goes to InspectorController.wrapObject(), which doesn't handle null very well. Current Behavior: > null TypeError: Result of expression 'wrapper' [null] is not an object. > [null, null] [] > var o = { a: null } Object a: null > o.a TypeError: Result of expression 'wrapper' [null] is not an object. Expected Behavior (from Safari 4.0.3): > null null > [null, null] [null, null] > var o = { a:null } undefined > o Object a: null > o.a null 142195 1 38447 joepeck 2009-08-23 00:04:03 -0700 Created attachment 38447 [PATCH] One Possible Solution No other falsey value causes wrapObject() to return a null value (NaN, undefined, 0, ''). This solution tackles null before calling wrapObject. Another solution could be checking the result of wrapObject (wrapper). And yet another solution could handle null differently inside InspectorController.wrapObject(). This approach seemed simplest. Pavel, would there be a more appropriate solution? 142197 2 joepeck 2009-08-23 00:08:45 -0700 Actually that "exception: false" part isn't necessary, because thats the implicit default if its left out. So I can remove that if this is an okay way to go. 142214 3 pfeldman 2009-08-23 02:11:03 -0700 > + return { value: InjectedScript.createProxyObject(null, null), exception: false }; We don't wrap primitive values with proxy objects at the moment, why wrapping null. I would just do return { value: null }; However, that would require fixing ConsoleView's proxy detection: var isProxy = typeof output === "object"; should be replaced with var isProxy = output !== null && typeof output === "object"; 142218 4 pfeldman 2009-08-23 02:26:53 -0700 Additional note: fixing InspectorController.wrapObject would be nicer, but you would need to do that in both bindings (comparing to null are returning argument). It will still require mentioned fix in the console though. 142230 5 38453 joepeck 2009-08-23 07:55:23 -0700 Created attachment 38453 [PATCH] Pavel's JavaScript Approach 142231 6 joepeck 2009-08-23 07:58:49 -0700 (In reply to comment #4) > Additional note: fixing InspectorController.wrapObject would be nicer, but you > would need to do that in both bindings (comparing to null are returning > argument). It will still require mentioned fix in the console though. What I said earlier was not accurate. wrapObject doesn't have trouble with null, it just ends up returning the value passed in, which was null, and a null value isn't handled well afterwards. I like this approach. 142246 7 38453 eric 2009-08-23 14:42:15 -0700 Comment on attachment 38453 [PATCH] Pavel's JavaScript Approach Clearing flags on attachment: 38453 Committed r47696: <http://trac.webkit.org/changeset/47696> 142247 8 eric 2009-08-23 14:42:18 -0700 All reviewed patches have been landed. Closing bug. 38447 2009-08-23 00:04:03 -0700 2009-08-23 07:55:23 -0700 [PATCH] One Possible Solution special_case.patch text/plain 1264 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2M5Y2VhYi4uMDQ2NzZmYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wOC0yMiAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEluc3BlY3RvcjogVGhyb3dzIGFuIEVycm9yIG9uICJudWxsIgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg2NjUKKwor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanM6CisgICAgICAg IChJbmplY3RlZFNjcmlwdC5ldmFsdWF0ZSk6IHNwZWNpYWwgY2FzZSB3aGVuIGV2YWx1YXRlIHJl c3VsdHMgaW4gbnVsbAorCiAyMDA5LTA4LTIyICBBZGVsZSBQZXRlcnNvbiAgPGFkZWxlQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCmRpZmYgLS1naXQg YS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMgYi9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKaW5kZXggZGZmZWQ2NS4uNGI5 ZWRlMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2Ny aXB0LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5q cwpAQCAtNDk4LDYgKzQ5OCw4IEBAIEluamVjdGVkU2NyaXB0LmV2YWx1YXRlID0gZnVuY3Rpb24o ZXhwcmVzc2lvbikKICAgICB2YXIgcmVzdWx0ID0ge307CiAgICAgdHJ5IHsKICAgICAgICAgdmFy IHZhbHVlID0gSW5qZWN0ZWRTY3JpcHQuX3dpbmRvdygpLmV2YWwoZXhwcmVzc2lvbik7CisgICAg ICAgIGlmICh2YWx1ZSA9PT0gbnVsbCkKKyAgICAgICAgICAgIHJldHVybiB7IHZhbHVlOiBJbmpl Y3RlZFNjcmlwdC5jcmVhdGVQcm94eU9iamVjdChudWxsLCBudWxsKSwgZXhjZXB0aW9uOiBmYWxz ZSB9OwogICAgICAgICB2YXIgd3JhcHBlciA9IEluc3BlY3RvckNvbnRyb2xsZXIud3JhcE9iamVj dCh2YWx1ZSk7CiAgICAgICAgIGlmICh0eXBlb2Ygd3JhcHBlciA9PT0gIm9iamVjdCIgJiYgd3Jh cHBlci5leGNlcHRpb24pCiAgICAgICAgICAgICByZXN1bHQuZXhjZXB0aW9uID0gd3JhcHBlci5l eGNlcHRpb247Cg== 38453 2009-08-23 07:55:23 -0700 2009-08-23 14:42:15 -0700 [PATCH] Pavel's JavaScript Approach pavels_way.patch text/plain 1700 joepeck ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2M5Y2VhYi4uOGZjMWVjYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wOC0yMiAgSm9zZXBoIFBlY29y YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEluc3BlY3RvcjogVGhyb3dzIGFuIEVycm9yIG9uICJudWxsIgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg2NjUKKwor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanM6CisgICAgICAg IChJbmplY3RlZFNjcmlwdC5ldmFsdWF0ZSk6CisKIDIwMDktMDgtMjIgIEFkZWxlIFBldGVyc29u ICA8YWRlbGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nv bi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5q cyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcwppbmRleCBmYjVl MWMxLi42ZmUxOTJkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29u c29sZVZpZXcuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3 LmpzCkBAIC0zODQsNyArMzg0LDcgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3LnByb3RvdHlw ZSA9IHsKIAogICAgIF9mb3JtYXQ6IGZ1bmN0aW9uKG91dHB1dCwgZm9yY2VPYmplY3RGb3JtYXQp CiAgICAgewotICAgICAgICB2YXIgaXNQcm94eSA9IHR5cGVvZiBvdXRwdXQgPT09ICJvYmplY3Qi OworICAgICAgICB2YXIgaXNQcm94eSA9IChvdXRwdXQgIT0gbnVsbCAmJiB0eXBlb2Ygb3V0cHV0 ID09PSAib2JqZWN0Iik7CiAKICAgICAgICAgaWYgKGZvcmNlT2JqZWN0Rm9ybWF0KQogICAgICAg ICAgICAgdmFyIHR5cGUgPSAib2JqZWN0IjsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9JbmplY3RlZFNjcmlwdC5qcwppbmRleCBkZmZlZDY1Li4wYjNjMjBjIDEwMDY0NAotLS0gYS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMKKysrIGIvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzCkBAIC00OTgsNiArNDk4LDgg QEAgSW5qZWN0ZWRTY3JpcHQuZXZhbHVhdGUgPSBmdW5jdGlvbihleHByZXNzaW9uKQogICAgIHZh ciByZXN1bHQgPSB7fTsKICAgICB0cnkgewogICAgICAgICB2YXIgdmFsdWUgPSBJbmplY3RlZFNj cmlwdC5fd2luZG93KCkuZXZhbChleHByZXNzaW9uKTsKKyAgICAgICAgaWYgKHZhbHVlID09PSBu dWxsKQorICAgICAgICAgICAgcmV0dXJuIHsgdmFsdWU6IG51bGwgfTsKICAgICAgICAgdmFyIHdy YXBwZXIgPSBJbnNwZWN0b3JDb250cm9sbGVyLndyYXBPYmplY3QodmFsdWUpOwogICAgICAgICBp ZiAodHlwZW9mIHdyYXBwZXIgPT09ICJvYmplY3QiICYmIHdyYXBwZXIuZXhjZXB0aW9uKQogICAg ICAgICAgICAgcmVzdWx0LmV4Y2VwdGlvbiA9IHdyYXBwZXIuZXhjZXB0aW9uOwo=