28654 2009-08-22 05:26:51 -0700 [Qt] MIME handling in qtwebkit network layer case-sensitivity 2012-01-10 11:26:54 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED http://www.buienradar.nl/images.aspx?jaar=-3&bliksem=0&voor=&soort=verwachting1x1 Qt, QtTriaged P2 Normal --- 1 rich webkit-qt-unassigned abarth commit-queue eric hausmann jesus kent.hansen laszlo.gombos luiz markus robert tonikitoo webkit.review.bot oldest_to_newest 142111 0 38432 rich 2009-08-22 05:26:51 -0700 Created attachment 38432 Patch to fix the bug The code in webkit assumes MIME types will be lower case, but QNetworkAccessManager returns the mime type exactly as it is sent by the remote server. The RFC says mime types are case-insensitive, so in the case of the URL above which sends image/GIF things should work just fine. Unfortunately that is not the case, qtwebkit believes this mime type to be unsupported wheras image/gif is fine. The fix is simply to lowercase the mimetype as it is passed from QNAM to webkit. 165838 1 hausmann 2009-11-23 05:56:26 -0800 Richard, your patch needs a ChangeLog and a testcase/unit-test, and the patch should probably be marked for review :) 165901 2 rich 2009-11-23 12:42:10 -0800 Yeah, the difficulty here is that in order to avoid the test case being more complex than the issue itself we need a server. I was hoping that the server used by the QNAM performance tests would be available for testing qtwebkit stuff but that never happened. This leaves me with the webkit layout test server which i'm told supports php so should be doable. I don't have that setup right now, so this is waiting until I or someone else gets it setup and can write the test. 197119 3 hausmann 2010-03-08 04:28:48 -0800 One way of testing it is through a synthetic QNetworkAccessManager instance, like it's done in some of the unit tests, returning a fake http response. 225722 4 markus 2010-05-14 02:02:40 -0700 Check out tst_qnetworkreply the MiniHttpServer. You don't need a custom QNAM. 249987 5 61258 robert 2010-07-12 13:11:58 -0700 Created attachment 61258 Patch 250010 6 61258 hausmann 2010-07-12 13:34:41 -0700 Comment on attachment 61258 Patch Excellent, thanks Robert! r=me. I hope it'll work with the other ports :) 250657 7 61258 commit-queue 2010-07-13 11:56:52 -0700 Comment on attachment 61258 Patch Clearing flags on attachment: 61258 Committed r63229: <http://trac.webkit.org/changeset/63229> 250658 8 commit-queue 2010-07-13 11:56:57 -0700 All reviewed patches have been landed. Closing bug. 250672 9 webkit.review.bot 2010-07-13 12:17:28 -0700 http://trac.webkit.org/changeset/63229 might have broken GTK Linux 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/63228 http://trac.webkit.org/changeset/63229 38432 2009-08-22 05:26:51 -0700 2010-07-12 13:11:51 -0700 Patch to fix the bug handle-mixedcase-mime.patch text/plain 804 rich ZGlmZiAtLWdpdCBhL3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcCBiL3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcAppbmRleCA4OThl NWY0Li5hYWE5MWVkIDEwMDY0NAotLS0gYS9zcmMvM3JkcGFydHkvd2Via2l0L1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAKKysrIGIvc3JjLzNyZHBh cnR5L3dlYmtpdC9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRs ZXIuY3BwCkBAIC0yNzYsNyArMjc2LDcgQEAgdm9pZCBRTmV0d29ya1JlcGx5SGFuZGxlcjo6c2Vu ZFJlc3BvbnNlSWZOZWVkZWQoKQogICAgIGlmIChzdWdnZXN0ZWRGaWxlbmFtZS5pc0VtcHR5KCkp CiAgICAgICAgIHN1Z2dlc3RlZEZpbGVuYW1lID0gdXJsLmxhc3RQYXRoQ29tcG9uZW50KCk7CiAK LSAgICBSZXNvdXJjZVJlc3BvbnNlIHJlc3BvbnNlKHVybCwgbWltZVR5cGUsCisgICAgUmVzb3Vy Y2VSZXNwb25zZSByZXNwb25zZSh1cmwsIG1pbWVUeXBlLmxvd2VyKCksCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBtX3JlcGx5LT5oZWFkZXIoUU5ldHdvcmtSZXF1ZXN0OjpDb250ZW50 TGVuZ3RoSGVhZGVyKS50b0xvbmdMb25nKCksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBlbmNvZGluZywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN1Z2dlc3RlZEZpbGVu YW1lKTsK 61258 2010-07-12 13:11:58 -0700 2010-07-13 11:56:52 -0700 Patch bug-28654-20100712211158.patch text/plain 3329 robert ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NmUwOWY4ZWUxOTU2OWU1YjI5NzQ0M2RlN2VlNzgzNTNkZmNiYTRjLi4zMzMwMWQz MTQ3MjJiNDQyZWVjOGY5NjYyNmY5YWMyNDFjMWIzZWVhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTAtMDctMTIgIFJpY2hhcmQgTW9vcmUgPHJpY2hAa2RlLm9yZz4sIFJvYmVydCBIb2dhbiAg PHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtRdF0gTUlNRSBoYW5kbGluZyBpbiBxdHdlYmtpdCBuZXR3b3JrIGxheWVy IGNhc2Utc2Vuc2l0aXZpdHkKKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mjg2NTQKKworICAgICAgICBNb2RpZnkgZXhpc3RpbmcgdGVzdCB1cHBlcmNh c2UtbWltZS10eXBlLmh0bWwgdG8gdGVzdCBmb3IgdGhlCisgICAgICAgIGxvd2VyLWNhc2luZyBl eHBsaWNpdGx5LgorCisgICAgICAgICogaHR0cC90ZXN0cy9taW1lL3VwcGVyY2FzZS1taW1lLXR5 cGUtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvbWltZS91cHBlcmNhc2UtbWlt ZS10eXBlLmh0bWw6CisKIDIwMTAtMDctMTIgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pbWUvdXBwZXJjYXNlLW1pbWUtdHlwZS1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pbWUvdXBwZXJjYXNlLW1pbWUtdHlwZS1leHBl Y3RlZC50eHQKaW5kZXggYzdhYjc1MmY4MDYyYjAyNjU5YTg2YmRmZTgxM2Q4NTMxN2VmZWRkMy4u MjIzZDYyMGI5MzlmMDQzMTJkMjIyYzY3OTJiNmFmNDRkODBmZjhiZCAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9taW1lL3VwcGVyY2FzZS1taW1lLXR5cGUtZXhwZWN0ZWQudHh0 CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWltZS91cHBlcmNhc2UtbWltZS10eXBlLWV4 cGVjdGVkLnR4dApAQCAtMSArMSwyIEBACit1cHBlcmNhc2UtbWltZS10eXBlLnBocCBoYXMgTUlN RSB0eXBlIHRleHQvaHRtbAogSWYgdGhpcyB0ZXh0IGlzIHNob3duLCB0aGF0IG1lYW5zIHRoZSBu ZXcgZG9jdW1lbnQgd2FzIHN1Y2Nlc3NmdWxseSBsb2FkZWQuCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL21pbWUvdXBwZXJjYXNlLW1pbWUtdHlwZS5odG1sIGIvTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9taW1lL3VwcGVyY2FzZS1taW1lLXR5cGUuaHRtbAppbmRleCA5ZWYzYjg3 YmRiNTVlMWFiMGM1MjcxYTkxN2E3NjlmYmY1NDY0ZGI0Li4xNmU1YTkyYmRhYWQyMWEzODFhMWZk ZjZhYTE1MzU2OGRlMjMxY2Y3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21p bWUvdXBwZXJjYXNlLW1pbWUtdHlwZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMv bWltZS91cHBlcmNhc2UtbWltZS10eXBlLmh0bWwKQEAgLTIsNiArMiw3IEBACiA8c2NyaXB0Pgog aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgIGxheW91dFRlc3RDb250cm9s bGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wUmVzb3Vy Y2VSZXNwb25zZU1JTUVUeXBlcygpOwogICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1Rl eHQoKTsKIH0KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCBiNDY4ZDAyMjQ1N2FlNmEzZTYzZmY3MTU5MjRkZjFjNTQwNDE2Y2Q1Li41NTk3 MzdlNDJlMWUyNDY3NTE1YmMzNGIwZWIyYTAzMTI2MTYzYTA0IDEwMDY0NAotLS0gYS9XZWJDb3Jl L0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEw LTA3LTEyICBSaWNoYXJkIE1vb3JlIDxyaWNoQGtkZS5vcmc+LCBSb2JlcnQgSG9nYW4gIDxyb2Jl cnRAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbUXRdIE1JTUUgaGFuZGxpbmcgaW4gcXR3ZWJraXQgbmV0d29yayBsYXllciBjYXNl LXNlbnNpdGl2aXR5CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI4NjU0CisKKyAgICAgICAgTGlrZSBvdGhlciBwbGF0Zm9ybXMsIFF0IG5lZWRzIHRv IGNvbnZlcnQgTUlNRSB0eXBlcyB0byBsb3dlciBjYXNlCisgICAgICAgIHNvIHRoZXkgd2lsbCBi ZSBoYW5kbGVkIGJ5IFdlYkNvcmUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L1FO ZXR3b3JrUmVwbHlIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlFOZXR3b3JrUmVwbHlI YW5kbGVyOjpzZW5kUmVzcG9uc2VJZk5lZWRlZCk6CisKIDIwMTAtMDctMTIgIEFuZHJlYXMgS2xp bmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2 ZXIgSHVudC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29y a1JlcGx5SGFuZGxlci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtS ZXBseUhhbmRsZXIuY3BwCmluZGV4IDFhZTI0ZmYzM2I4OGUzMTE3ZDM2YzBlMDU0NjA2NGNhZWQ1 YzEzZjYuLjliY2VkMGU4NjlmMjIwMmVkZTM3OGU4YmFmNGNjMDQwNGMyZWM3NzEgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAK KysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNw cApAQCAtMzA5LDcgKzMwOSw3IEBAIHZvaWQgUU5ldHdvcmtSZXBseUhhbmRsZXI6OnNlbmRSZXNw b25zZUlmTmVlZGVkKCkKICAgICB9CiAKICAgICBLVVJMIHVybChtX3JlcGx5LT51cmwoKSk7Ci0g ICAgUmVzb3VyY2VSZXNwb25zZSByZXNwb25zZSh1cmwsIG1pbWVUeXBlLAorICAgIFJlc291cmNl UmVzcG9uc2UgcmVzcG9uc2UodXJsLCBtaW1lVHlwZS5sb3dlcigpLAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgbV9yZXBseS0+aGVhZGVyKFFOZXR3b3JrUmVxdWVzdDo6Q29udGVudExl bmd0aEhlYWRlcikudG9Mb25nTG9uZygpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZW5jb2RpbmcsIFN0cmluZygpKTsKIAo=