28650 2009-08-21 17:55:09 -0700 Remove cross-thread code from CrossOriginPreflightResultCache 2009-08-24 10:21:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dimich dimich ap oldest_to_newest 142083 0 dimich 2009-08-21 17:55:09 -0700 .. since it was there because XHR used it (and it can be used from Workers) and now it is only used from DocumentThreadedLoader, so it only is used on a main thread. 142084 1 38427 dimich 2009-08-21 17:59:14 -0700 Created attachment 38427 Proposed patch 142088 2 38427 levin 2009-08-21 18:08:19 -0700 Comment on attachment 38427 Proposed patch > diff --git a/WebCore/loader/CrossOriginPreflightResultCache.cpp b/WebCore/loader/CrossOriginPreflightResultCache.cpp > + static CrossOriginPreflightResultCache& cache = *new CrossOriginPreflightResultCache; Please use DEFINE_STATIC_LOCAL here. 142321 3 dimich 2009-08-24 10:21:13 -0700 Changed to DYNAMIC_STATIC_LOCAL and landed: http://trac.webkit.org/changeset/47659 38427 2009-08-21 17:59:14 -0700 2009-08-21 18:08:19 -0700 Proposed patch patch.txt text/plain 4032 dimich ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Yzk1MDZiZC4uNTk4ZjcyZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0wOC0yMSAgRG1pdHJ5IFRpdG92 ICA8ZGltaWNoQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 Mjg2NTAKKyAgICAgICAgUmVtb3ZlIGNyb3NzLXRocmVhZCBjb2RlIGZyb20gQ3Jvc3NPcmlnaW5Q cmVmbGlnaHRSZXN1bHRDYWNoZS4KKyAgICAgICAgUmVtb3ZlZCBtdXRleGVzLCBhdG9taWMgaW5p dGlhbGl6ZXIgYW5kIHN0cmluZyBjb3B5LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhlIHdv cmtlciB0ZXN0cyBjb3ZlciB0aGlzLgorCisgICAgICAgICogbG9hZGVyL0Nyb3NzT3JpZ2luUHJl ZmxpZ2h0UmVzdWx0Q2FjaGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6YWRkVG9BY2Nlc3NDb250 cm9sQWxsb3dMaXN0KToKKyAgICAgICAgKFdlYkNvcmU6OkNyb3NzT3JpZ2luUHJlZmxpZ2h0UmVz dWx0Q2FjaGU6OnNoYXJlZCk6CisgICAgICAgIChXZWJDb3JlOjpDcm9zc09yaWdpblByZWZsaWdo dFJlc3VsdENhY2hlOjphcHBlbmRFbnRyeSk6CisgICAgICAgIChXZWJDb3JlOjpDcm9zc09yaWdp blByZWZsaWdodFJlc3VsdENhY2hlOjpjYW5Ta2lwUHJlZmxpZ2h0KToKKyAgICAgICAgKFdlYkNv cmU6OkNyb3NzT3JpZ2luUHJlZmxpZ2h0UmVzdWx0Q2FjaGU6OmVtcHR5KToKKyAgICAgICAgKiBs b2FkZXIvQ3Jvc3NPcmlnaW5QcmVmbGlnaHRSZXN1bHRDYWNoZS5oOgorCiAyMDA5LTA4LTIwICBC cmlhbiBXZWluc3RlaW4gIDxid2VpbnN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBBZGVsZSBQZXRlcnNvbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL0Nyb3NzT3Jp Z2luUHJlZmxpZ2h0UmVzdWx0Q2FjaGUuY3BwIGIvV2ViQ29yZS9sb2FkZXIvQ3Jvc3NPcmlnaW5Q cmVmbGlnaHRSZXN1bHRDYWNoZS5jcHAKaW5kZXggNGJkMDViMi4uNTIzNGQzMyAxMDA2NDQKLS0t IGEvV2ViQ29yZS9sb2FkZXIvQ3Jvc3NPcmlnaW5QcmVmbGlnaHRSZXN1bHRDYWNoZS5jcHAKKysr IGIvV2ViQ29yZS9sb2FkZXIvQ3Jvc3NPcmlnaW5QcmVmbGlnaHRSZXN1bHRDYWNoZS5jcHAKQEAg LTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlICJDcm9zc09yaWdpbkFjY2Vzc0NvbnRyb2wuaCIKICNp bmNsdWRlICJSZXNvdXJjZVJlc3BvbnNlLmgiCiAjaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+ CisjaW5jbHVkZSA8d3RmL1RocmVhZGluZy5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAg LTY0LDggKzY1LDcgQEAgc3RhdGljIHZvaWQgYWRkVG9BY2Nlc3NDb250cm9sQWxsb3dMaXN0KGNv bnN0IFN0cmluZyYgc3RyaW5nLCB1bnNpZ25lZCBzdGFydCwgdW4KICAgICB3aGlsZSAoZW5kICYm IGlzU3BhY2VPck5ld2xpbmUoKCpzdHJpbmdJbXBsKVtlbmRdKSkKICAgICAgICAgLS1lbmQ7CiAK LSAgICAvLyBzdWJzdHJpbmdDb3B5KCkgaXMgY2FsbGVkIG9uIHRoZSBzdHJpbmdzIGJlY2F1c2Ug dGhlIGNhY2hlIGlzIGFjY2Vzc2VkIG9uIG11bHRpcGxlIHRocmVhZHMuCi0gICAgc2V0LmFkZChz dHJpbmcuc3Vic3RyaW5nQ29weShzdGFydCwgZW5kIC0gc3RhcnQgKyAxKSk7CisgICAgc2V0LmFk ZChzdHJpbmcuc3Vic3RyaW5nKHN0YXJ0LCBlbmQgLSBzdGFydCArIDEpKTsKIH0KIAogdGVtcGxh dGU8Y2xhc3MgSGFzaFR5cGU+CkBAIC0xMzcsMjAgKzEzNywyMCBAQCBib29sIENyb3NzT3JpZ2lu UHJlZmxpZ2h0UmVzdWx0Q2FjaGVJdGVtOjphbGxvd3NSZXF1ZXN0KGJvb2wgaW5jbHVkZUNyZWRl bnRpYWxzLAogCiBDcm9zc09yaWdpblByZWZsaWdodFJlc3VsdENhY2hlJiBDcm9zc09yaWdpblBy ZWZsaWdodFJlc3VsdENhY2hlOjpzaGFyZWQoKQogewotICAgIEF0b21pY2FsbHlJbml0aWFsaXpl ZFN0YXRpYyhDcm9zc09yaWdpblByZWZsaWdodFJlc3VsdENhY2hlJiwgY2FjaGUgPSAqbmV3IENy b3NzT3JpZ2luUHJlZmxpZ2h0UmVzdWx0Q2FjaGUpOworICAgIHN0YXRpYyBDcm9zc09yaWdpblBy ZWZsaWdodFJlc3VsdENhY2hlJiBjYWNoZSA9ICpuZXcgQ3Jvc3NPcmlnaW5QcmVmbGlnaHRSZXN1 bHRDYWNoZTsKKyAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwogICAgIHJldHVybiBjYWNoZTsK IH0KIAogdm9pZCBDcm9zc09yaWdpblByZWZsaWdodFJlc3VsdENhY2hlOjphcHBlbmRFbnRyeShj b25zdCBTdHJpbmcmIG9yaWdpbiwgY29uc3QgS1VSTCYgdXJsLCBDcm9zc09yaWdpblByZWZsaWdo dFJlc3VsdENhY2hlSXRlbSogcHJlZmxpZ2h0UmVzdWx0KQogewotICAgIE11dGV4TG9ja2VyIGxv Y2sobV9tdXRleCk7Ci0gICAgLy8gTm90ZSB0aGF0IHRoZSBlbnRyeSBtYXkgYWxyZWFkeSBiZSBw cmVzZW50IGluIHRoZSBIYXNoTWFwIGlmIGFub3RoZXIgdGhyZWFkIGlzIGFjY2Vzc2luZyB0aGUg c2FtZSBsb2NhdGlvbi4KLSAgICBtX3ByZWZsaWdodEhhc2hNYXAuc2V0KHN0ZDo6bWFrZV9wYWly KG9yaWdpbi5jb3B5KCksIHVybC5jb3B5KCkpLCBwcmVmbGlnaHRSZXN1bHQpOworICAgIEFTU0VS VChpc01haW5UaHJlYWQoKSk7CisgICAgbV9wcmVmbGlnaHRIYXNoTWFwLnNldChzdGQ6Om1ha2Vf cGFpcihvcmlnaW4sIHVybCksIHByZWZsaWdodFJlc3VsdCk7CiB9CiAKIGJvb2wgQ3Jvc3NPcmln aW5QcmVmbGlnaHRSZXN1bHRDYWNoZTo6Y2FuU2tpcFByZWZsaWdodChjb25zdCBTdHJpbmcmIG9y aWdpbiwgY29uc3QgS1VSTCYgdXJsLCBib29sIGluY2x1ZGVDcmVkZW50aWFscywgY29uc3QgU3Ry aW5nJiBtZXRob2QsIGNvbnN0IEhUVFBIZWFkZXJNYXAmIHJlcXVlc3RIZWFkZXJzKQogewotICAg IE11dGV4TG9ja2VyIGxvY2sobV9tdXRleCk7CisgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsK ICAgICBDcm9zc09yaWdpblByZWZsaWdodFJlc3VsdEhhc2hNYXA6Oml0ZXJhdG9yIGNhY2hlSXQg PSBtX3ByZWZsaWdodEhhc2hNYXAuZmluZChzdGQ6Om1ha2VfcGFpcihvcmlnaW4sIHVybCkpOwog ICAgIGlmIChjYWNoZUl0ID09IG1fcHJlZmxpZ2h0SGFzaE1hcC5lbmQoKSkKICAgICAgICAgcmV0 dXJuIGZhbHNlOwpAQCAtMTY1LDcgKzE2NSw3IEBAIGJvb2wgQ3Jvc3NPcmlnaW5QcmVmbGlnaHRS ZXN1bHRDYWNoZTo6Y2FuU2tpcFByZWZsaWdodChjb25zdCBTdHJpbmcmIG9yaWdpbiwgY29uCiAK IHZvaWQgQ3Jvc3NPcmlnaW5QcmVmbGlnaHRSZXN1bHRDYWNoZTo6ZW1wdHkoKQogewotICAgIE11 dGV4TG9ja2VyIGxvY2sobV9tdXRleCk7CisgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKICAg ICBkZWxldGVBbGxWYWx1ZXMobV9wcmVmbGlnaHRIYXNoTWFwKTsKICAgICBtX3ByZWZsaWdodEhh c2hNYXAuY2xlYXIoKTsKIH0KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL0Nyb3NzT3JpZ2lu UHJlZmxpZ2h0UmVzdWx0Q2FjaGUuaCBiL1dlYkNvcmUvbG9hZGVyL0Nyb3NzT3JpZ2luUHJlZmxp Z2h0UmVzdWx0Q2FjaGUuaAppbmRleCBmNzFkMWM4Li45N2I1MjZhIDEwMDY0NAotLS0gYS9XZWJD b3JlL2xvYWRlci9Dcm9zc09yaWdpblByZWZsaWdodFJlc3VsdENhY2hlLmgKKysrIGIvV2ViQ29y ZS9sb2FkZXIvQ3Jvc3NPcmlnaW5QcmVmbGlnaHRSZXN1bHRDYWNoZS5oCkBAIC03Miw3ICs3Miw2 IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdHlwZWRlZiBIYXNoTWFwPHN0ZDo6cGFp cjxTdHJpbmcsIEtVUkw+LCBDcm9zc09yaWdpblByZWZsaWdodFJlc3VsdENhY2hlSXRlbSo+IENy b3NzT3JpZ2luUHJlZmxpZ2h0UmVzdWx0SGFzaE1hcDsKIAogICAgICAgICBDcm9zc09yaWdpblBy ZWZsaWdodFJlc3VsdEhhc2hNYXAgbV9wcmVmbGlnaHRIYXNoTWFwOwotICAgICAgICBNdXRleCBt X211dGV4OwogICAgIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK