<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>286497</bug_id>
          
          <creation_ts>2025-01-24 12:58:28 -0800</creation_ts>
          <short_desc>[WebDriver][BiDi] run-webdriver-tests: Selenium WebDriver-BiDi tests require extra pytest option</short_desc>
          <delta_ts>2025-01-28 08:32:25 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebDriver</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Lauro Moura">lmoura</reporter>
          <assigned_to name="Lauro Moura">lmoura</assigned_to>
          <cc>bburg</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2089616</commentid>
    <comment_count>0</comment_count>
    <who name="Lauro Moura">lmoura</who>
    <bug_when>2025-01-24 12:58:28 -0800</bug_when>
    <thetext>The selenium test suite update from 288959@main added some WebDriver-BiDi tests. The suite uses the custom `--bidi=true` pytest argument to tell Selenium to start the WebDriver session for testing with this feature enabled.

Currently, this option is not passed to Selenium in WebDriverTestRunnerSelenium/WebDriverSeleniumExecutor. So, running Selenium&apos;s WebDriver-BiDi tests fails, regardless of having the feature enabled through `ENABLE_WEBDRIVER_BIDI=1`.

We can&apos;t also set it as a fixed flag, as it would make the classic tests to fail in ENABLE_WEBDRIVER_BIDI=0 builds (due to failure to set up the WebDriver-BiDi session).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2089699</commentid>
    <comment_count>1</comment_count>
    <who name="Lauro Moura">lmoura</who>
    <bug_when>2025-01-24 19:33:33 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/39207</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2089700</commentid>
    <comment_count>2</comment_count>
    <who name="Lauro Moura">lmoura</who>
    <bug_when>2025-01-24 19:55:15 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/39538</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2089951</commentid>
    <comment_count>3</comment_count>
    <who name="Lauro Moura">lmoura</who>
    <bug_when>2025-01-27 06:10:53 -0800</bug_when>
    <thetext>(In reply to Lauro Moura from comment #1)
&gt; Pull request: https://github.com/WebKit/WebKit/pull/39207

Please ignore this PR, as it is related to bug286163 and was attached to this bug by accident. The correct one is https://github.com/WebKit/WebKit/pull/39538</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2090182</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2025-01-28 08:31:19 -0800</bug_when>
    <thetext>Committed 289454@main (9a82bd160050): &lt;https://commits.webkit.org/289454@main&gt;

Reviewed commits have been landed. Closing PR #39538 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2090184</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2025-01-28 08:32:25 -0800</bug_when>
    <thetext>&lt;rdar://problem/143761444&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>