286274 2025-01-20 13:46:47 -0800 [WebDriver] Properly use smart pointers instead of raw pointers for the HTTPServer, WebSocketServer, and WebDriverService 2025-04-24 18:50:02 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=291925 InRadar P2 Normal --- 1 lmoura lmoura bburg webkit-bug-importer oldest_to_newest 2088567 0 lmoura 2025-01-20 13:46:47 -0800 In WebDriverBiDi's a number of classes (WebDriverService, HTTPServer, WebSocketServer) held each other through plain references, and, in the case of WebSocketServer, mixed with WeakPtr usage. We should make them use smart pointers correctly, per our safer cpp guidelines: https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines#use-smart-pointers-instead-of-raw-pointers-for-all-data-members Patch incoming. 2088616 1 lmoura 2025-01-20 19:05:30 -0800 Pull request: https://github.com/WebKit/WebKit/pull/39310 2090030 2 webkit-bug-importer 2025-01-27 13:47:11 -0800 <rdar://problem/143715487> 2113019 3 lmoura 2025-04-24 18:50:02 -0700 (In reply to Lauro Moura from comment #1) > Pull request: https://github.com/WebKit/WebKit/pull/39310 This PR was closed in favor of a simpler fix in bug291925. We can revisit it later